New tests to replace view_test runtime: 15->0.125s #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding a new test runner to make running tests easier. Test runner from https://github.com/birdsarah/django-flexible-discover-runner Would have used django-discover-runner but it didn't work with current tests, used django-flexible-discover-runner which combines discover-runner with django's default behavior. Run tests in exactly the same manner e.g. ./manage.py test publicweb but no longer need to import tests in __init__.py but do need to maintain the naming convention of test files ending in _test.py (or update the pattern in test_runner.py)
Previously, the tests were using fixtures. Switch to using factories with the helper library factory-boy.
Previously, the 8 tests in view_test were taking 12 seconds to run. By removing the dependency on the DecisionTestCase, and the user of the test client, the run time has been dramatically reduced. NOTE - this includes three failing tests. One looks like a bug in the code, the other two would round out the tests but are much easier done with a small code change in views.py If we could do this on all the tests, the test suite would drop in run time to under 1s!!
| def test_status_is_correctly_set_on_view_get_for_decision_list(self): | ||
| """ | ||
| It's very hard to atomically test the get method. Two options: | ||
| 1) Move L146 of the get method into get_context_data (preferred) |
There was a problem hiding this comment.
That won't work because get_queryset uses self.status.
|
This is a subset of #116 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the 8 tests in view_test were taking 12 seconds to run. By removing the dependency on the DecisionTestCase, and the user of the test client, the run time has been
dramatically reduced.
If we could do this on all the tests, the test suite would drop in run time to under 1s!!
NOTE - this includes three failing tests. One looks like a bug in the code, the other two would round out the tests but are much easier done with a small code change in views.py
Once we've code-reviewed this, we probably want to get the tests passing before we merge.