Fixes to notification email about joining organization #140
Conversation
username (rather than their first and last name, which may not be set) in notification email. Also remove sentence that didn't make any sense in that context. (Fix for http://aptivate.kanbantool.com/boards/5986-econsensus#tasks-1257223)
|
There are few things missing. It is missing sender's email address so it is not possible to contact that person. It would also be better to fallback to username when first name and last name are not available since username alone on service I am not yet using likely doesn't tell me much. Not sure about help email address. We certainly shouldn't add it before it exists and it should be configurable. |
|
This isn't a message for a service that the user is not yet using. It's the message someone gets if they already are using econsensus, and have merely been added to another org. I'm not sure about giving the sender's email address, since (as far as I'm aware) email addresses are normally only visible to org administrators. |
|
It doesn't really change the problem since it's not anonymity of eConsensus that would be the problem. I understand the reservation about email, but don't really have a strong view one way or the other (could argue for both). However if we drop this requirement, then that should be reflected on story card. |
|
I've hit a weird thing. I implemented falling back on username, and for consistency I wanted to do this in invitation and reminder emails. However, in testing this locally I've found that invitations aren't being sent out (although reminders are). I need to dig into this, to find out what's going on. Update: this problem exists in the develop branch, so rather than try to address it here I've created a new card (https://aptivate.kanbantool.com/boards/5986-econsensus#tasks-2155377) |
|
I've moved the suggestion about having a "help" email address to its own card (https://aptivate.kanbantool.com/boards/5986-econsensus#tasks-2155433) |
|
I've opened pull request #176 as I couldn't figure out how to add further commits to this one. |
There was a suggestion in the card, which I haven't implemented, to have a special help email address for an econsensus installation. (I'm not quite sure what status the suggestion had.)