Update the mirror test goldens, fix --capture on Python 3 #1244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
None of the commands' output is ever treated as binary, so we can just always decode it as text. Signed-off-by: Ryan Gonzalez <ryan.gonzalez@collabora.com>
They were either using outdated package versions or now-removed Debian releases. (Perhaps it would be worth removing `stretch` from elsewhere, too, but those links seem to be to the archive and thus shouldn't actually be an issue?) Signed-off-by: Ryan Gonzalez <ryan.gonzalez@collabora.com>
6 tasks
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1244 +/- ##
==========================================
+ Coverage 74.85% 74.93% +0.07%
==========================================
Files 143 143
Lines 16187 16181 -6
==========================================
+ Hits 12117 12125 +8
+ Misses 3134 3122 -12
+ Partials 936 934 -2 ☔ View full report in Codecov by Sentry. |
|
(not sure why codecov is failing, this PR did not touch any Go code files.) |
|
oh ! I was working on the same, but I moved all unstable internet sources to s3, so we have reproducible testing. however, I wonder if your python change would still be needed. could you check ? |
|
I guess this is not needed anymore, thanks anyway ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
CI was failing due to the mirror test goldens being outdated, so those were updated, as well as
--capturebeing fixed on Python 3.Checklist
AUTHORS