Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix reflist diffs failing to compact when one of the inputs ends #1275

Merged
merged 2 commits into from
Apr 24, 2024
Merged

Fix reflist diffs failing to compact when one of the inputs ends #1275

merged 2 commits into from
Apr 24, 2024

Commits on Apr 24, 2024

  1. Skip loading reflists when listing published repos 

    The output doesn't actually depend on the reflists, and loading them for
every published repo starts to take substantial time and memory.

Signed-off-by: Ryan Gonzalez <ryan.gonzalez@collabora.com>
    @refi64 @neolynx
    refi64 authored and neolynx committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    1325f7b View commit details
    Browse the repository at this point in the history

  2. Fix reflist diffs failing to compact when one of the inputs ends 

    The previous reflist logic would early-exit the loop body if one of the
lists was empty, but that skips the compacting logic entirely.

Instead of doing the early-exit, we can leave a list's ref as nil when
the list end is reached and then flip the comparison result, which will
essentially treat it as being greater than all others. This should
preserve the general behavior without omitting the compaction.

Signed-off-by: Ryan Gonzalez <ryan.gonzalez@collabora.com>
    @refi64 @neolynx
    refi64 authored and neolynx committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    a599bb1 View commit details
    Browse the repository at this point in the history