refactor: get rid of bytes_to_hex.ts

aptos-labs · Sep 15, 2022 · 5090886 · 5090886
1 parent bbd6842
commit 5090886
Show file tree

Hide file tree

Showing 7 changed files with 4 additions and 84 deletions.
diff --git a/ecosystem/typescript/sdk/src/aptos_account.ts b/ecosystem/typescript/sdk/src/aptos_account.ts
@@ -4,8 +4,8 @@
 import nacl from "tweetnacl";
 import sha3 from "js-sha3";
 import * as bip39 from "@scure/bip39";
+import { bytesToHex } from "@noble/hashes/utils";
 import { derivePath } from "./utils/hd-key";
-import { bytesToHex } from "./bytes_to_hex.js";
 import { HexString, MaybeHexString } from "./hex_string";
 import * as Gen from "./generated/index";
 import { Memoize } from "./utils";

diff --git a/ecosystem/typescript/sdk/src/bytes_to_hex.test.ts b/ecosystem/typescript/sdk/src/bytes_to_hex.test.ts
diff --git a/ecosystem/typescript/sdk/src/bytes_to_hex.ts b/ecosystem/typescript/sdk/src/bytes_to_hex.ts
diff --git a/ecosystem/typescript/sdk/src/hex_string.ts b/ecosystem/typescript/sdk/src/hex_string.ts
@@ -1,7 +1,7 @@
 // Copyright (c) Aptos
 // SPDX-License-Identifier: Apache-2.0
 
-import { bytesToHex, hexToBytes } from "./bytes_to_hex.js";
+import { bytesToHex, hexToBytes } from "@noble/hashes/utils";
 import { HexEncodedBytes } from "./generated";
 
 // eslint-disable-next-line no-use-before-define

diff --git a/ecosystem/typescript/sdk/src/index.ts b/ecosystem/typescript/sdk/src/index.ts
@@ -4,7 +4,6 @@
 // All parts of our package are accessible as imports, but we re-export our higher level API here for convenience
 export * from "./aptos_account";
 export * from "./aptos_client";
-export * from "./bytes_to_hex.js";
 export * from "./coin_client";
 export * from "./faucet_client";
 export * from "./hex_string";

diff --git a/ecosystem/typescript/sdk/src/transaction_builder/transaction_builder.test.ts b/ecosystem/typescript/sdk/src/transaction_builder/transaction_builder.test.ts
@@ -3,7 +3,7 @@
 
 /* eslint-disable max-len */
 import nacl from "tweetnacl";
-import { bytesToHex } from "../bytes_to_hex.js";
+import { bytesToHex, hexToBytes } from "@noble/hashes/utils";
 import { bcsSerializeUint64, bcsToBytes, Bytes } from "./bcs";
 import { HexString } from "../hex_string";
 
@@ -31,10 +31,6 @@ const ADDRESS_4 = "0x01";
 const PRIVATE_KEY = "9bf49a6a0755f953811fce125f2683d50429c3bb49e074147e0089a52eae155f";
 const TXN_EXPIRE = "18446744073709551615";
 
-function hexToBytes(hex: string) {
-  return new HexString(hex).toUint8Array();
-}
-
 function hexSignedTxn(signedTxn: Uint8Array): string {
   return bytesToHex(signedTxn);
 }

diff --git a/ecosystem/typescript/sdk/src/transaction_builder/transaction_vector.test.ts b/ecosystem/typescript/sdk/src/transaction_builder/transaction_vector.test.ts
@@ -11,7 +11,7 @@
 import path from "path";
 import nacl from "tweetnacl";
 import fs from "fs";
-import { bytesToHex } from "../bytes_to_hex.js";
+import { bytesToHex } from "@noble/hashes/utils";
 import {
   AccountAddress,
   ChainId,