[event v2] double emitting in account, coin, fungible asset and object and migrate move-examples #10532

lightmark · 2023-10-16T22:22:36Z

Description

step 1 of #10529
leave other modules for grabs.

Test Plan

ut

lightmark · 2023-10-16T22:23:44Z

aptos-move/framework/aptos-framework/sources/object.move

@@ -157,6 +157,7 @@ module aptos_framework::object {
    }

    /// Emitted whenever the object's owner field is changed.
+    #[event]


note: not sure reusing this struct or create a new one. seems unnecessary to me but a different opinion is welcomed.

go for it...

junkil-park · 2023-10-19T09:08:11Z

aptos-move/move-examples/defi/sources/locked_coins.move

    /// Event emitted when a lock is canceled.
-    struct CancelLockupEvent has drop, store {
+    struct CancelLockup has drop, store {


Is it going to be the convention to drop the suffix "Event"?

My current pattern for aptos-framework is:

If the current event struct doesn't need add new field to migrate to v2, I will just add #[event] attribute directly to that struct to spare the hassle of creating a new struct.

otherwise, create a new struct without Event suffix since attribute can tell whether it is an event or not and you cannot share the same event name in the same module.

Does it make sense?

Make sense!
What if the current event v1 struct (for example AbcEvent) needs to add a new field? It will become AbcEventV2 or AbcV2?

there is no way for them to add field. I think any new v2 does not need Event string in their name.

aptos-move/move-examples/token_objects/ambassador/sources/ambassador.move

codecov · 2024-01-11T03:41:05Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0b5bb47) 69.7% compared to head (5c572e6) 69.7%.
Report is 16 commits behind head on main.

❗ Current head 5c572e6 differs from pull request most recent head 0e7026b. Consider uploading reports for the commit 0e7026b to get more accurate results

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #10532   +/-   ##
=======================================
  Coverage    69.7%    69.7%           
=======================================
  Files        2111     2111           
  Lines      401246   401243    -3     
=======================================
+ Hits       279797   279867   +70     
+ Misses     121449   121376   -73

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

github-actions · 2024-01-17T01:56:39Z

✅ Forge suite `compat` success on `aptos-node-v1.8.3` ==> `0e7026b64f6ab00e5ecd1d3ecac93b54d9296ab9`

Compatibility test results for aptos-node-v1.8.3 ==> 0e7026b64f6ab00e5ecd1d3ecac93b54d9296ab9 (PR)
1. Check liveness of validators at old version: aptos-node-v1.8.3
compatibility::simple-validator-upgrade::liveness-check : committed: 4453 txn/s, latency: 7039 ms, (p50: 7500 ms, p90: 10000 ms, p99: 15900 ms), latency samples: 178140
2. Upgrading first Validator to new version: 0e7026b64f6ab00e5ecd1d3ecac93b54d9296ab9
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 1777 txn/s, latency: 15822 ms, (p50: 19300 ms, p90: 21900 ms, p99: 22700 ms), latency samples: 92420
3. Upgrading rest of first batch to new version: 0e7026b64f6ab00e5ecd1d3ecac93b54d9296ab9
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 1566 txn/s, latency: 16248 ms, (p50: 19100 ms, p90: 22000 ms, p99: 30000 ms), latency samples: 92400
4. upgrading second batch to new version: 0e7026b64f6ab00e5ecd1d3ecac93b54d9296ab9
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 2999 txn/s, latency: 10554 ms, (p50: 11400 ms, p90: 15800 ms, p99: 18100 ms), latency samples: 119980
5. check swarm health
Compatibility test for aptos-node-v1.8.3 ==> 0e7026b64f6ab00e5ecd1d3ecac93b54d9296ab9 passed
Test Ok

github-actions · 2024-01-17T02:00:25Z

✅ Forge suite `realistic_env_max_load` success on `0e7026b64f6ab00e5ecd1d3ecac93b54d9296ab9`

two traffics test: inner traffic : committed: 7111 txn/s, latency: 5366 ms, (p50: 4800 ms, p90: 7000 ms, p99: 14400 ms), latency samples: 3079120
two traffics test : committed: 100 txn/s, latency: 2244 ms, (p50: 2200 ms, p90: 2500 ms, p99: 2800 ms), latency samples: 1800
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.261, avg: 0.210", "QsPosToProposal: max: 0.147, avg: 0.142", "ConsensusProposalToOrdered: max: 0.572, avg: 0.538", "ConsensusOrderedToCommit: max: 0.508, avg: 0.486", "ConsensusProposalToCommit: max: 1.052, avg: 1.024"]
Max round gap was 2 [limit 4] at version 1101903. Max no progress secs was 9.009265 [limit 10] at version 1101903.
Test Ok

github-actions · 2024-01-17T02:15:57Z

❌ Forge suite `framework_upgrade` failure on `aptos-node-v1.8.3` ==> `0e7026b64f6ab00e5ecd1d3ecac93b54d9296ab9`

Compatibility test results for aptos-node-v1.8.3 ==> 0e7026b64f6ab00e5ecd1d3ecac93b54d9296ab9 (PR)
Upgrade the nodes to version: 0e7026b64f6ab00e5ecd1d3ecac93b54d9296ab9
Test Failed: API error: Unknown error error sending request for url (http://aptos-node-3-validator.forge-framework-upgrade-pr-10532.svc:8080/v1/estimate_gas_price): operation timed out

Stack backtrace:
   0: <unknown>
   1: <unknown>
   2: <unknown>
   3: <unknown>
   4: <unknown>
   5: <unknown>
   6: <unknown>
   7: <unknown>
   8: <unknown>
   9: <unknown>
  10: <unknown>
  11: <unknown>
  12: <unknown>
  13: <unknown>
  14: __libc_start_main
  15: <unknown>
Trailing Log Lines:
   7: <unknown>
   8: <unknown>
   9: <unknown>
  10: <unknown>
  11: <unknown>
  12: <unknown>
  13: <unknown>
  14: __libc_start_main
  15: <unknown>


Swarm logs can be found here: See fgi output for more information.
thread 'main' panicked at testsuite/forge/src/backend/k8s/swarm.rs:676:18:
called `Result::unwrap()` on an `Err` value: ApiError: namespaces "forge-framework-upgrade-pr-10532" not found: NotFound (ErrorResponse { status: "Failure", message: "namespaces \"forge-framework-upgrade-pr-10532\" not found", reason: "NotFound", code: 404 })

Caused by:
    namespaces "forge-framework-upgrade-pr-10532" not found: NotFound

Stack backtrace:
   0: <unknown>
   1: <unknown>
   2: <unknown>
   3: <unknown>
   4: <unknown>
   5: <unknown>
   6: <unknown>
   7: <unknown>
   8: <unknown>
   9: <unknown>
  10: <unknown>
  11: <unknown>
  12: <unknown>
  13: <unknown>
  14: <unknown>
  15: __libc_start_main
  16: <unknown>
stack backtrace:
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.
Debugging output:

This reverts commit c7375b8.

…#12918) * Revert "[event_v2] migrate account, coin, object (#10532)" This reverts commit c7375b8. * update objects.rs and transacitons.rs

lightmark requested review from alinush, davidiw, movekevin and wrwg as code owners October 16, 2023 22:22

lightmark commented Oct 16, 2023

View reviewed changes

lightmark force-pushed the event_v2_migration branch from e4a02ff to 911b145 Compare October 17, 2023 16:33

lightmark requested a review from junkil-park as a code owner October 17, 2023 16:33

lightmark requested review from banool, gregnazario and 0xmaayan as code owners October 17, 2023 20:12

lightmark force-pushed the event_v2_migration branch 2 times, most recently from f315ddf to bf8bb8c Compare October 18, 2023 03:39

lightmark requested a review from msmouse as a code owner October 18, 2023 03:39

lightmark force-pushed the event_v2_migration branch 2 times, most recently from 831be80 to bde8dd6 Compare October 18, 2023 06:10

junkil-park reviewed Oct 19, 2023

View reviewed changes

lightmark mentioned this pull request Oct 24, 2023

Migrate all Move examples to event v2 #10647

Closed

lightmark changed the title ~~[event v2] double emitting in account, coin, fungible asset and object~~ [event v2] double emitting in account, coin, fungible asset and object and migrate move-examples Oct 24, 2023

movekevin reviewed Oct 24, 2023

View reviewed changes

aptos-move/move-examples/token_objects/ambassador/sources/ambassador.move Outdated Show resolved Hide resolved

lightmark force-pushed the event_v2_migration branch 4 times, most recently from 83c8378 to 0354ae7 Compare October 25, 2023 18:28

lightmark force-pushed the event_v2_migration branch from 0354ae7 to f7f0134 Compare October 31, 2023 23:07

lightmark requested a review from CapCap November 1, 2023 20:39

lightmark enabled auto-merge (squash) November 6, 2023 22:44

This comment has been minimized.

Sign in to view

lightmark force-pushed the event_v2_migration branch from 5c572e6 to 1fcfb55 Compare January 11, 2024 20:23

This comment has been minimized.

Sign in to view

[event_v2] migrate account, coin, object

80133bf

lightmark force-pushed the event_v2_migration branch from 1fcfb55 to 80133bf Compare January 12, 2024 08:36

This comment has been minimized.

Sign in to view

indexer v1 does not support event v2.

0e7026b

This comment has been minimized.

Sign in to view

lightmark merged commit c7375b8 into main Jan 17, 2024
51 of 52 checks passed

lightmark deleted the event_v2_migration branch January 17, 2024 02:08

junkil-park added a commit that referenced this pull request Feb 21, 2024

Revert "[event_v2] migrate account, coin, object (#10532)"

e23d1e4

This reverts commit c7375b8.

sherry-x pushed a commit that referenced this pull request Feb 21, 2024

Revert "[event_v2] migrate account, coin, object (#10532)" (#12140)

0d252a0

This reverts commit c7375b8.

lightmark added a commit that referenced this pull request Apr 16, 2024

Revert "[event_v2] migrate account, coin, object (#10532)"

990b1b3

This reverts commit c7375b8.

larry-aptos mentioned this pull request May 10, 2024

[event_v2] indexer logic update to handle migration aptos-labs/aptos-indexer-processors#360

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[event v2] double emitting in account, coin, fungible asset and object and migrate move-examples #10532

[event v2] double emitting in account, coin, fungible asset and object and migrate move-examples #10532

lightmark commented Oct 16, 2023 •

edited

Loading

lightmark Oct 16, 2023

davidiw Nov 27, 2023

junkil-park Oct 19, 2023

lightmark Oct 19, 2023

junkil-park Oct 20, 2023

lightmark Oct 20, 2023

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

codecov bot commented Jan 11, 2024 •

edited

Loading

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

github-actions bot commented Jan 17, 2024

github-actions bot commented Jan 17, 2024

github-actions bot commented Jan 17, 2024

[event v2] double emitting in account, coin, fungible asset and object and migrate move-examples #10532

[event v2] double emitting in account, coin, fungible asset and object and migrate move-examples #10532

Conversation

lightmark commented Oct 16, 2023 • edited Loading

Description

Test Plan

lightmark Oct 16, 2023

Choose a reason for hiding this comment

davidiw Nov 27, 2023

Choose a reason for hiding this comment

junkil-park Oct 19, 2023

Choose a reason for hiding this comment

lightmark Oct 19, 2023

Choose a reason for hiding this comment

junkil-park Oct 20, 2023

Choose a reason for hiding this comment

lightmark Oct 20, 2023

Choose a reason for hiding this comment

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

codecov bot commented Jan 11, 2024 • edited Loading

Codecov Report

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

github-actions bot commented Jan 17, 2024

✅ Forge suite compat success on aptos-node-v1.8.3 ==> 0e7026b64f6ab00e5ecd1d3ecac93b54d9296ab9

github-actions bot commented Jan 17, 2024

✅ Forge suite realistic_env_max_load success on 0e7026b64f6ab00e5ecd1d3ecac93b54d9296ab9

github-actions bot commented Jan 17, 2024

❌ Forge suite framework_upgrade failure on aptos-node-v1.8.3 ==> 0e7026b64f6ab00e5ecd1d3ecac93b54d9296ab9

lightmark commented Oct 16, 2023 •

edited

Loading

codecov bot commented Jan 11, 2024 •

edited

Loading

✅ Forge suite `compat` success on `aptos-node-v1.8.3` ==> `0e7026b64f6ab00e5ecd1d3ecac93b54d9296ab9`

✅ Forge suite `realistic_env_max_load` success on `0e7026b64f6ab00e5ecd1d3ecac93b54d9296ab9`

❌ Forge suite `framework_upgrade` failure on `aptos-node-v1.8.3` ==> `0e7026b64f6ab00e5ecd1d3ecac93b54d9296ab9`