Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

System transaction internal only #10963

Merged
merged 17 commits into from
Nov 18, 2023
Merged

System transaction internal only #10963

merged 17 commits into from
Nov 18, 2023

Conversation

zjma
Copy link
Contributor

@zjma zjma commented Nov 17, 2023

Previous attempts:
#10940
#10951

@zjma zjma added the CICD:run-e2e-tests when this label is present github actions will run all land-blocking e2e tests from the PR label Nov 17, 2023

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

✅ Forge suite realistic_env_max_load success on f1be7e9fd81884f1f525bb84329250c4d2f00cfd

two traffics test: inner traffic : committed: 8239 txn/s, latency: 4764 ms, (p50: 4500 ms, p90: 5700 ms, p99: 10200 ms), latency samples: 3559620
two traffics test : committed: 100 txn/s, latency: 2336 ms, (p50: 2200 ms, p90: 2800 ms, p99: 3400 ms), latency samples: 1800
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.206, avg: 0.196", "QsPosToProposal: max: 0.158, avg: 0.145", "ConsensusProposalToOrdered: max: 0.602, avg: 0.578", "ConsensusOrderedToCommit: max: 0.531, avg: 0.507", "ConsensusProposalToCommit: max: 1.133, avg: 1.085"]
Max round gap was 1 [limit 4] at version 1695643. Max no progress secs was 4.12125 [limit 10] at version 1695643.
Test Ok

Copy link
Contributor

✅ Forge suite compat success on aptos-node-v1.7.3 ==> f1be7e9fd81884f1f525bb84329250c4d2f00cfd

Compatibility test results for aptos-node-v1.7.3 ==> f1be7e9fd81884f1f525bb84329250c4d2f00cfd (PR)
1. Check liveness of validators at old version: aptos-node-v1.7.3
compatibility::simple-validator-upgrade::liveness-check : committed: 4331 txn/s, latency: 7218 ms, (p50: 7800 ms, p90: 9800 ms, p99: 11400 ms), latency samples: 168940
2. Upgrading first Validator to new version: f1be7e9fd81884f1f525bb84329250c4d2f00cfd
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 1774 txn/s, latency: 15897 ms, (p50: 19300 ms, p90: 21900 ms, p99: 22500 ms), latency samples: 92280
3. Upgrading rest of first batch to new version: f1be7e9fd81884f1f525bb84329250c4d2f00cfd
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 1775 txn/s, latency: 15675 ms, (p50: 19200 ms, p90: 21900 ms, p99: 22500 ms), latency samples: 92340
4. upgrading second batch to new version: f1be7e9fd81884f1f525bb84329250c4d2f00cfd
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 2870 txn/s, latency: 8980 ms, (p50: 9700 ms, p90: 10900 ms, p99: 12200 ms), latency samples: 140640
5. check swarm health
Compatibility test for aptos-node-v1.7.3 ==> f1be7e9fd81884f1f525bb84329250c4d2f00cfd passed
Test Ok

Copy link

codecov bot commented Nov 18, 2023

Codecov Report

Attention: 24 lines in your changes are missing coverage. Please review.

Comparison is base (6a8d3a1) 68.9% compared to head (ee4c627) 71.6%.
Report is 1 commits behind head on main.

❗ Current head ee4c627 differs from pull request most recent head f1be7e9. Consider uploading reports for the commit f1be7e9 to get more accurate results

Files Patch % Lines
aptos-move/aptos-vm/src/aptos_vm.rs 0.0% 18 Missing ⚠️
crates/aptos-rosetta/src/types/objects.rs 0.0% 2 Missing ⚠️
api/types/src/convert.rs 0.0% 1 Missing ⚠️
execution/executor/src/components/chunk_output.rs 0.0% 1 Missing ⚠️
...ackup-cli/src/backup_types/transaction/analysis.rs 0.0% 1 Missing ⚠️
types/src/transaction/mod.rs 0.0% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main   #10963       +/-   ##
===========================================
+ Coverage    68.9%    71.6%     +2.6%     
===========================================
  Files         753     2032     +1279     
  Lines      172231   384909   +212678     
===========================================
+ Hits       118803   275674   +156871     
- Misses      53428   109235    +55807     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

✅ Forge suite framework_upgrade success on aptos-node-v1.7.3 ==> f1be7e9fd81884f1f525bb84329250c4d2f00cfd

Compatibility test results for aptos-node-v1.7.3 ==> f1be7e9fd81884f1f525bb84329250c4d2f00cfd (PR)
Upgrade the nodes to version: f1be7e9fd81884f1f525bb84329250c4d2f00cfd
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 7027 txn/s, latency: 4796 ms, (p50: 4800 ms, p90: 7800 ms, p99: 8400 ms), latency samples: 245960
5. check swarm health
Compatibility test for aptos-node-v1.7.3 ==> f1be7e9fd81884f1f525bb84329250c4d2f00cfd passed
Test Ok

@zjma zjma merged commit 2a33258 into main Nov 18, 2023
53 of 54 checks passed
@zjma zjma deleted the system-transaction-internal-only branch November 18, 2023 00:13
gedigi pushed a commit that referenced this pull request Nov 21, 2023
* system transaction initial

* update

* ....

* update

* exclude proposal changes

* update

* update

* enum as part of API, and todos in indexer

* update

* update

* api update

* system txn internal only

* update

* update

* update

* formats update
rtso pushed a commit that referenced this pull request Nov 22, 2023
* system transaction initial

* update

* ....

* update

* exclude proposal changes

* update

* update

* enum as part of API, and todos in indexer

* update

* update

* api update

* system txn internal only

* update

* update

* update

* formats update
bowenyang007 pushed a commit that referenced this pull request Dec 7, 2023
* system transaction initial

* update

* ....

* update

* exclude proposal changes

* update

* update

* enum as part of API, and todos in indexer

* update

* update

* api update

* system txn internal only

* update

* update

* update

* formats update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CICD:run-e2e-tests when this label is present github actions will run all land-blocking e2e tests from the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants