Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dep] upgrade serde, serde-reflection and related deps #11137

Merged
merged 6 commits into from Jan 4, 2024

Conversation

ibalajiarun
Copy link
Contributor

@ibalajiarun ibalajiarun commented Nov 30, 2023

Description

Test Plan

Existing tests work after the upgrade.

@ibalajiarun
Copy link
Contributor Author

ibalajiarun commented Nov 30, 2023

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

@ibalajiarun ibalajiarun force-pushed the balaji/update-serde branch 2 times, most recently from c6011f1 to e140afd Compare December 1, 2023 19:59
@ibalajiarun ibalajiarun changed the title update serde and fix related errors [dep] upgrade serde and serde-reflection Dec 1, 2023
@ibalajiarun ibalajiarun marked this pull request as ready for review December 13, 2023 01:37
@ibalajiarun ibalajiarun force-pushed the balaji/update-serde branch 2 times, most recently from a7522bf to 3b2a326 Compare December 13, 2023 02:18
@ibalajiarun ibalajiarun added the CICD:run-forge-e2e-perf Run the e2e perf forge only label Dec 13, 2023

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

@@ -758,7 +756,6 @@ debug-assertions = true
debug = true

[patch.crates-io]
serde-reflection = { git = "https://github.com/aptos-labs/serde-reflection", rev = "839aed62a20ddccf043c08961cfe74875741ccba" }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we did this to ensure that the Move repo used this as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see. It wasn't overriding actually, so I thought it wasn't needed. Fixed it now by pointing dependency in move-bytecode-utils crate to workspace.

Thanks for the stamp. I need to land this first: aptos-labs/aptos-indexer-processors#218.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

@ibalajiarun ibalajiarun force-pushed the balaji/update-serde branch 2 times, most recently from 0c23cbe to 4b8cdf2 Compare January 4, 2024 06:09
@ibalajiarun ibalajiarun changed the title [dep] upgrade serde and serde-reflection [dep] upgrade serde, serde-reflection and related deps Jan 4, 2024

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

github-actions bot commented Jan 4, 2024

✅ Forge suite compat success on aptos-node-v1.8.3 ==> cd5973fc64f697eace0d5468954e89758af0106b

Compatibility test results for aptos-node-v1.8.3 ==> cd5973fc64f697eace0d5468954e89758af0106b (PR)
1. Check liveness of validators at old version: aptos-node-v1.8.3
compatibility::simple-validator-upgrade::liveness-check : committed: 4724 txn/s, latency: 6999 ms, (p50: 6600 ms, p90: 10700 ms, p99: 15100 ms), latency samples: 174820
2. Upgrading first Validator to new version: cd5973fc64f697eace0d5468954e89758af0106b
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 1778 txn/s, latency: 15900 ms, (p50: 19400 ms, p90: 21900 ms, p99: 22600 ms), latency samples: 92460
3. Upgrading rest of first batch to new version: cd5973fc64f697eace0d5468954e89758af0106b
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 1779 txn/s, latency: 15843 ms, (p50: 19200 ms, p90: 22000 ms, p99: 22600 ms), latency samples: 92520
4. upgrading second batch to new version: cd5973fc64f697eace0d5468954e89758af0106b
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 3592 txn/s, latency: 8808 ms, (p50: 9600 ms, p90: 12600 ms, p99: 13000 ms), latency samples: 143680
5. check swarm health
Compatibility test for aptos-node-v1.8.3 ==> cd5973fc64f697eace0d5468954e89758af0106b passed
Test Ok

Copy link
Contributor

github-actions bot commented Jan 4, 2024

✅ Forge suite realistic_env_max_load success on cd5973fc64f697eace0d5468954e89758af0106b

two traffics test: inner traffic : committed: 8253 txn/s, latency: 4704 ms, (p50: 4500 ms, p90: 5600 ms, p99: 11700 ms), latency samples: 3565420
two traffics test : committed: 100 txn/s, latency: 2378 ms, (p50: 2100 ms, p90: 2500 ms, p99: 9100 ms), latency samples: 1740
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.220, avg: 0.199", "QsPosToProposal: max: 0.133, avg: 0.127", "ConsensusProposalToOrdered: max: 0.586, avg: 0.550", "ConsensusOrderedToCommit: max: 0.482, avg: 0.461", "ConsensusProposalToCommit: max: 1.035, avg: 1.011"]
Max round gap was 1 [limit 4] at version 1578046. Max no progress secs was 6.674282 [limit 10] at version 1578046.
Test Ok

Copy link
Contributor

github-actions bot commented Jan 4, 2024

❌ Forge suite framework_upgrade failure on aptos-node-v1.8.3 ==> cd5973fc64f697eace0d5468954e89758af0106b

Compatibility test results for aptos-node-v1.8.3 ==> cd5973fc64f697eace0d5468954e89758af0106b (PR)
Upgrade the nodes to version: cd5973fc64f697eace0d5468954e89758af0106b
Test Failed: API error: Unknown error error sending request for url (http://aptos-node-3-validator.forge-framework-upgrade-pr-11137.svc:8080/v1/accounts/0000000000000000000000000000000000000000000000000000000000000001/resource/0x1::block::BlockResource): error trying to connect: dns error: failed to lookup address information: Name or service not known

Stack backtrace:
   0: <unknown>
   1: <unknown>
   2: <unknown>
   3: <unknown>
   4: <unknown>
   5: <unknown>
   6: <unknown>
   7: <unknown>
   8: <unknown>
   9: <unknown>
  10: <unknown>
  11: <unknown>
  12: <unknown>
  13: <unknown>
  14: __libc_start_main
  15: <unknown>
Trailing Log Lines:
   7: <unknown>
   8: <unknown>
   9: <unknown>
  10: <unknown>
  11: <unknown>
  12: <unknown>
  13: <unknown>
  14: __libc_start_main
  15: <unknown>


Swarm logs can be found here: See fgi output for more information.
{"level":"INFO","source":{"package":"aptos_forge","file":"testsuite/forge/src/backend/k8s/cluster_helper.rs:292"},"thread_name":"main","hostname":"forge-framework-upgrade-pr-11137-1704351715-aptos-node-v1-8-3","timestamp":"2024-01-04T07:30:24.599348Z","message":"Deleting namespace forge-framework-upgrade-pr-11137: Some(NamespaceStatus { conditions: Some([NamespaceCondition { last_transition_time: Some(Time(2024-01-04T07:30:21Z)), message: Some(\"All resources successfully discovered\"), reason: Some(\"ResourcesDiscovered\"), status: \"False\", type_: \"NamespaceDeletionDiscoveryFailure\" }, NamespaceCondition { last_transition_time: Some(Time(2024-01-04T07:30:21Z)), message: Some(\"All legacy kube types successfully parsed\"), reason: Some(\"ParsedGroupVersions\"), status: \"False\", type_: \"NamespaceDeletionGroupVersionParsingFailure\" }, NamespaceCondition { last_transition_time: Some(Time(2024-01-04T07:30:21Z)), message: Some(\"All content successfully deleted, may be waiting on finalization\"), reason: Some(\"ContentDeleted\"), status: \"False\", type_: \"NamespaceDeletionContentFailure\" }, NamespaceCondition { last_transition_time: Some(Time(2024-01-04T07:30:21Z)), message: Some(\"Some resources are remaining: persistentvolumeclaims. has 4 resource instances\"), reason: Some(\"SomeResourcesRemain\"), status: \"True\", type_: \"NamespaceContentRemaining\" }, NamespaceCondition { last_transition_time: Some(Time(2024-01-04T07:30:21Z)), message: Some(\"Some content in the namespace has finalizers remaining: kubernetes.io/pvc-protection in 4 resource instances\"), reason: Some(\"SomeFinalizersRemain\"), status: \"True\", type_: \"NamespaceFinalizersRemaining\" }]), phase: Some(\"Terminating\") })"}
{"level":"INFO","source":{"package":"aptos_forge","file":"testsuite/forge/src/backend/k8s/cluster_helper.rs:400"},"thread_name":"main","hostname":"forge-framework-upgrade-pr-11137-1704351715-aptos-node-v1-8-3","timestamp":"2024-01-04T07:30:24.599407Z","message":"aptos-node resources for Forge removed in namespace: forge-framework-upgrade-pr-11137"}

failures:
    framework_upgrade::framework-upgrade

test result: FAILED. 0 passed; 1 failed; 0 filtered out

Failed to run tests:
Tests Failed
Error: Tests Failed

Stack backtrace:
   0: <unknown>
   1: <unknown>
   2: <unknown>
   3: <unknown>
   4: <unknown>
   5: <unknown>
   6: __libc_start_main
   7: <unknown>
Debugging output:

@ibalajiarun ibalajiarun merged commit 5718388 into main Jan 4, 2024
51 of 55 checks passed
@ibalajiarun ibalajiarun deleted the balaji/update-serde branch January 4, 2024 18:43
@banool
Copy link
Contributor

banool commented Jan 4, 2024

Woo!!!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CICD:run-forge-e2e-perf Run the e2e perf forge only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aptos-core is stuck on serde < 1.0.53 due to a change in 1.0.53 that breaks testsuite/generate-format
4 participants