Concurrent FungibleAsset balance #11183

igor-aptos · 2023-12-04T19:46:28Z

Description

Test Plan

trunk-io · 2023-12-04T19:46:32Z

⏱️ 2h 6m total CI duration on this PR

Job	Cumulative Duration	Recent Runs
rust-unit-tests	1h 10m	🟩 🟩
windows-build	20m	🟩
rust-images / rust-all	9m	🟩
rust-lints	8m	🟩
check-dynamic-deps	6m	🟩 🟩
run-tests-main-branch	4m	🟩
check	4m	🟩
general-lints	2m	🟩
docs-lint	41s	🟩
semgrep/ci	25s	🟩
file_change_determinator	14s	🟩
file_change_determinator	11s	🟩
file_change_determinator	10s	🟩
permission-check	4s	🟩
permission-check	3s	🟩
permission-check	2s	🟩
permission-check	2s	🟩
determine-docker-build-metadata	1s	🟩
permission-check	1s	🟩

🚨 1 job on the last run was significantly faster/slower than expected

Job	Duration	vs 7d avg	Delta
rust-lints	8m	7m

_{settings ⋅ feedback ⋅ docs ⋅ learn more about trunk.io}

igor-aptos · 2023-12-04T19:46:39Z

Current dependencies on/for this PR:

main
- PR Concurrent FungibleAsset balance #11183 👈

This stack of pull requests is managed by Graphite.

github-actions · 2024-01-19T01:49:31Z

This issue is stale because it has been open 45 days with no activity. Remove the stale label, comment or push a commit - otherwise this will be closed in 15 days.

lightmark · 2024-02-22T16:51:34Z

aptos-move/framework/aptos-framework/sources/fungible_asset.move

+    struct DepositEventV2 has drop, store {
+        metadata_address: address,
+        amount: u64,
+    }


Suggested change

struct DepositEventV2 has drop, store {

metadata_address: address,

amount: u64,

}

struct Deposit has drop, store {

metadata: address,

amount: u64,

}

Let's agree on the naming convention.hah

georgemitenkov · 2024-02-25T13:55:21Z

aptos-move/framework/aptos-framework/sources/fungible_asset.move

@@ -111,6 +111,13 @@ module aptos_framework::fungible_asset {
        frozen: bool,
    }

+    #[resource_group_member(group = aptos_framework::object::ObjectGroup)]
+    /// The store object that holds concurrent fungible asset balance


nit: . is missing

btw, in Move, can we place annotation after the docstring?

georgemitenkov · 2024-02-25T13:56:55Z

aptos-move/framework/aptos-framework/sources/fungible_asset.move

@@ -155,6 +162,14 @@ module aptos_framework::fungible_asset {
        frozen: bool,
    }

+    fun default_to_concurrent_fungible_supply(): bool {


Why add these functions? To me features::concurrent_fungible_assets_enabled() seems easier to parse?

in case we want to add multiple flags, to separately decide which path to take

georgemitenkov · 2024-02-25T13:57:21Z

aptos-move/framework/aptos-framework/sources/fungible_asset.move

@@ -289,6 +304,12 @@ module aptos_framework::fungible_asset {
        exists<FungibleStore>(store)
    }

+    #[view]
+    /// Return whether the provided address has a store initialized.


the comment is wrong, also what is store?

georgemitenkov · 2024-02-25T14:00:22Z

aptos-move/framework/aptos-framework/sources/fungible_asset.move

+    public fun balance<T: key>(store: Object<T>): u64 acquires FungibleStore, ConcurrentFungibleBalance {
+        let store_addr = object::object_address(&store);
+        if (concurrent_fungible_balance_exists(store_addr)) {
+            let balance = borrow_global<ConcurrentFungibleBalance>(store_addr);


I usually prefer

let balance = &borrow_global<ConcurrentFungibleBalance>(store_addr).balance; aggregator_v2::read(balance)

because balance.balance looks super weird. Either things need to be called differently, or we can access the field directly when we borrow global

georgemitenkov · 2024-02-25T14:01:29Z

aptos-move/framework/aptos-framework/sources/fungible_asset.move

-        if (store_exists(object::object_address(&store))) {
+    public fun balance<T: key>(store: Object<T>): u64 acquires FungibleStore, ConcurrentFungibleBalance {
+        let store_addr = object::object_address(&store);
+        if (concurrent_fungible_balance_exists(store_addr)) {


We should check here that && store_exists(store_addr) as well?

This can be part of concurrent_fungible_balance_exists function?

that should be a general invariant, but not sure we want to/need to explicitly check it here?

georgemitenkov · 2024-02-25T14:07:03Z

aptos-move/framework/aptos-framework/sources/fungible_asset.move

@@ -386,22 +424,23 @@ module aptos_framework::fungible_asset {
            event::destroy_handle(deposit_events);
            event::destroy_handle(withdraw_events);
            event::destroy_handle(frozen_events);
-        }
+


nit: remove this newline?

georgemitenkov · 2024-02-25T14:08:33Z

aptos-move/framework/aptos-framework/sources/fungible_asset.move

+            aggregator_v2::add(&mut balance.balance, amount);
+        } else {
+            let store = borrow_global_mut<FungibleStore>(store_addr);
+            store.balance = store.balance + amount;


We don't care about overflows? Interesting, why?

will later do sth like
https://github.com/aptos-labs/aptos-core/blob/main/aptos-move/framework/aptos-framework/sources/coin.move#L547
cc @junkil-park

georgemitenkov · 2024-02-25T14:08:55Z

aptos-move/framework/aptos-framework/sources/fungible_asset.move

-        let store = borrow_global_mut<FungibleStore>(store_addr);
-        store.balance = store.balance + amount;
+
+        if (concurrent_fungible_balance_exists(store_addr)) {


ditto about checking store exists and avoiding balance.balance

georgemitenkov · 2024-02-25T14:11:47Z

aptos-move/framework/aptos-framework/sources/fungible_asset.move

+            let balance = borrow_global_mut<ConcurrentFungibleBalance>(store_addr);
+            assert!(aggregator_v2::try_sub(&mut balance.balance, amount), error::invalid_argument(EINSUFFICIENT_BALANCE));
+        } else {
+            let store = borrow_global_mut<FungibleStore>(store_addr);


We don't check store exists here, is the check somewhere else?

yes. delegate to caller

georgemitenkov · 2024-02-25T14:12:35Z

aptos-move/framework/aptos-framework/sources/fungible_asset.move

+        let store_object_address = object::address_from_extend_ref(ref);
+        let store_object_signer = object::generate_signer_for_extending(ref);
+        assert!(features::concurrent_fungible_assets_enabled(), error::invalid_argument(ECONCURRENT_SUPPLY_NOT_ENABLED));
+        assert!(exists<FungibleStore>(store_object_address), error::not_found(ESTORE_NOT_FOUND));


reuse store_exists?

aptos-move/framework/aptos-framework/sources/fungible_asset.move

@@ -656,6 +708,25 @@ module aptos_framework::fungible_asset {
        move_to(&metadata_object_signer, supply);
    }

+    public fun upgrade_store_to_concurrent(
+        ref: &ExtendRef,


lightmark · 2024-02-23T17:13:39Z

aptos-move/framework/aptos-framework/doc/fungible_asset.md


+<<<<<<< HEAD


lightmark · 2024-03-04T19:14:34Z

aptos-move/framework/aptos-framework/doc/fungible_asset.md

@@ -11,18 +11,32 @@ metadata object can be any object that equipped with <code><a href="fungible_ass
 -  [Resource `ConcurrentSupply`](#0x1_fungible_asset_ConcurrentSupply)
 -  [Resource `Metadata`](#0x1_fungible_asset_Metadata)
 -  [Resource `FungibleStore`](#0x1_fungible_asset_FungibleStore)
+<<<<<<< HEAD


lightmark · 2024-03-04T19:16:42Z

aptos-move/framework/aptos-framework/sources/fungible_asset.move

+            aggregator_v2::add(&mut balance.balance, amount);
+        } else {
+            let store = borrow_global_mut<FungibleStore>(store_addr);
+            store.balance = store.balance + amount;


will later do sth like
https://github.com/aptos-labs/aptos-core/blob/main/aptos-move/framework/aptos-framework/sources/coin.move#L547
cc @junkil-park

lightmark · 2024-03-04T19:17:06Z

aptos-move/framework/aptos-framework/sources/fungible_asset.move

+            let balance = borrow_global_mut<ConcurrentFungibleBalance>(store_addr);
+            assert!(aggregator_v2::try_sub(&mut balance.balance, amount), error::invalid_argument(EINSUFFICIENT_BALANCE));
+        } else {
+            let store = borrow_global_mut<FungibleStore>(store_addr);


yes. delegate to caller

codecov · 2024-03-05T01:17:41Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 33.1%. Comparing base (d3bb8f6) to head (c6b9ae5).
Report is 6 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff            @@
##             main   #11183     +/-   ##
=========================================
- Coverage    33.1%    33.1%   -0.1%     
=========================================
  Files        1753     1754      +1     
  Lines      337871   337934     +63     
=========================================
- Hits       112000   111959     -41     
- Misses     225871   225975    +104

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

alnoki

How about strategic inlining to reduce gas bloat?

A lot of these helper functions can easily be inlined, and failing to optimize them here will have adverse consequences downstream because they are inner calls for lots of call flows across the framework

(Each function call comes with a fixed gas cost due to stack allocation, but inline functions are effectively free because they are essentially copy-pasted at compile time)

aptos-move/framework/aptos-framework/sources/fungible_asset.move


+    fun default_to_concurrent_fungible_supply(): bool {
+        features::concurrent_fungible_assets_enabled()
+    }
+
+    fun default_to_concurrent_fungible_balance(): bool {
+        features::concurrent_fungible_assets_enabled()
+    }
+
+    fun auto_upgrade_to_concurrent_fungible_balance(): bool {
+        features::concurrent_fungible_assets_enabled()
+    }


alnoki · 2024-03-05T17:38:10Z

aptos-move/framework/aptos-framework/sources/fungible_asset.move

+    #[view]
+    /// Return whether the provided address has a concurrent fungible balance initialized,
+    /// at the fungible store address.
+    public fun concurrent_fungible_balance_exists(store: address): bool {
+        exists<ConcurrentFungibleBalance>(store)
+    }


Suggested change

#[view]

/// Return whether the provided address has a concurrent fungible balance initialized,

/// at the fungible store address.

public fun concurrent_fungible_balance_exists(store: address): bool {

exists<ConcurrentFungibleBalance>(store)

}

#[view]

/// Return whether the provided address has a concurrent fungible balance initialized,

/// at the fungible store address.

public fun concurrent_fungible_balance_exists(store: address): bool {

exists<ConcurrentFungibleBalance>(store)

}

inline fun concurrent_fungible_balance_exists_inline(store: address): bool {

exists<ConcurrentFungibleBalance>(store)

}

inline fun store_exists_inline(store: address): bool {

exists<FungibleStore>(store)

}

How about adding inline versions here as well, which can be used in control flow statements?

alnoki · 2024-03-05T17:40:07Z

aptos-move/framework/aptos-framework/sources/fungible_asset.move

+        if (concurrent_fungible_balance_exists(store_addr)) {
+            let balance_resource = borrow_global<ConcurrentFungibleBalance>(store_addr);
+            aggregator_v2::read(&balance_resource.balance)
+        } else if (store_exists(store_addr)) {


Suggested change

if (concurrent_fungible_balance_exists(store_addr)) {

let balance_resource = borrow_global<ConcurrentFungibleBalance>(store_addr);

aggregator_v2::read(&balance_resource.balance)

} else if (store_exists(store_addr)) {

if (concurrent_fungible_balance_exists_inline(store_addr)) {

let balance_resource = borrow_global<ConcurrentFungibleBalance>(store_addr);

aggregator_v2::read(&balance_resource.balance)

} else if (store_exists_inline(store_addr)) {

To reduce gas bloat

you are so paranoid, hah

@alnoki has a point, we have many single-block functions, which are extra costs and extra performance losses. Why not inline if we could

alnoki · 2024-03-05T17:41:28Z

aptos-move/framework/aptos-framework/sources/fungible_asset.move

+
+        if (concurrent_fungible_balance_exists(addr)) {
+            let ConcurrentFungibleBalance { balance } = move_from<ConcurrentFungibleBalance>(addr);


Suggested change

if (concurrent_fungible_balance_exists(addr)) {

let ConcurrentFungibleBalance { balance } = move_from<ConcurrentFungibleBalance>(addr);

if (concurrent_fungible_balance_exists_inline(addr)) {

let ConcurrentFungibleBalance { balance } = move_from<ConcurrentFungibleBalance>(addr);

To reduce gas bloat?

alnoki · 2024-03-05T17:42:01Z

aptos-move/framework/aptos-framework/sources/fungible_asset.move

-        let store = borrow_global_mut<FungibleStore>(store_addr);
-        store.balance = store.balance + amount;
+
+        if (auto_upgrade_to_concurrent_fungible_balance() || concurrent_fungible_balance_exists(store_addr)) {


Suggested change

if (auto_upgrade_to_concurrent_fungible_balance() || concurrent_fungible_balance_exists(store_addr)) {

if (auto_upgrade_to_concurrent_fungible_balance() || concurrent_fungible_balance_exists_inline(store_addr)) {

To reduce gas bloat

alnoki · 2024-03-05T17:43:01Z

aptos-move/framework/aptos-framework/sources/fungible_asset.move


+        if (auto_upgrade_to_concurrent_fungible_balance() || concurrent_fungible_balance_exists(store_addr)) {


Suggested change

if (auto_upgrade_to_concurrent_fungible_balance() || concurrent_fungible_balance_exists(store_addr)) {

if (auto_upgrade_to_concurrent_fungible_balance() || concurrent_fungible_balance_exists_inline(store_addr)) {

To reduce gas bloat

igor-aptos · 2024-03-08T18:41:55Z

@alnoki I'll include inlines to individual functions, but I'll skip creating duplicate functions for that.

once @lightmark changes land as well, we will stress test this, and see if it makes any difference, seems probably minor.

igor-aptos · 2024-03-08T20:36:00Z

I'll add more context on one design choice, and anyone has feedback/thoughts, let me know.

With the current code, once this flag is enabled, and stores get migrated, individual store will contain two resources in the resource group:
FungibleStore and ConcurrentFungibleBalance.

we cannot remove balance field from FungibleStore - so it will still be present there, just deprecated, and always 0.

Alternative would be to have create ConcurrentFungibleStore, to replace FungibleStore, with all the same fields, just a different type for the balance. That way, in the future FungibleStore is deprecated and doesn't exist onchain, and store only contains clean ConcurrentFungibleStore resource.

That is in general doable, except for the create_store function, which currently returns Object<FungibleStore>. Object is just a wrapped address, but it asserts that object exists at that address, and so:

if someone has stored this reference in their code, doing migration internally would break it (I think?)
we cannot change signature of create_store, so we would need to permanently support creating deprecated store, and then migrating it on next call, and having separate create_concurrent_store to be used instead.

Any thoughts?

github-actions · 2024-05-29T02:45:42Z

✅ Forge suite `compat` success on `3ffe0986b5fe4acb76544ae7ae85d73b91a6a411` ==> `c6b9ae57cab7e9863aa17633a64aa81c7a6ed7d6`

Compatibility test results for 3ffe0986b5fe4acb76544ae7ae85d73b91a6a411 ==> c6b9ae57cab7e9863aa17633a64aa81c7a6ed7d6 (PR)
1. Check liveness of validators at old version: 3ffe0986b5fe4acb76544ae7ae85d73b91a6a411
compatibility::simple-validator-upgrade::liveness-check : committed: 6856.570716880554 txn/s, latency: 4811.060124443712 ms, (p50: 4800 ms, p90: 8000 ms, p99: 8500 ms), latency samples: 242680
2. Upgrading first Validator to new version: c6b9ae57cab7e9863aa17633a64aa81c7a6ed7d6
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 3401.803287405923 txn/s, latency: 9155.552263581489 ms, (p50: 9600 ms, p90: 13800 ms, p99: 14200 ms), latency samples: 139160
3. Upgrading rest of first batch to new version: c6b9ae57cab7e9863aa17633a64aa81c7a6ed7d6
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 2662.575701144134 txn/s, latency: 11135.824768188302 ms, (p50: 12600 ms, p90: 15000 ms, p99: 15700 ms), latency samples: 112160
4. upgrading second batch to new version: c6b9ae57cab7e9863aa17633a64aa81c7a6ed7d6
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 6321.084312654622 txn/s, latency: 5152.101468950749 ms, (p50: 4800 ms, p90: 8800 ms, p99: 10100 ms), latency samples: 233500
5. check swarm health
Compatibility test for 3ffe0986b5fe4acb76544ae7ae85d73b91a6a411 ==> c6b9ae57cab7e9863aa17633a64aa81c7a6ed7d6 passed
Test Ok

github-actions · 2024-05-29T02:47:34Z

✅ Forge suite `realistic_env_max_load` success on `c6b9ae57cab7e9863aa17633a64aa81c7a6ed7d6`

two traffics test: inner traffic : committed: 8075.8350789713395 txn/s, latency: 4841.267981576979 ms, (p50: 4500 ms, p90: 6600 ms, p99: 10500 ms), latency samples: 3502140
two traffics test : committed: 99.96212672063903 txn/s, latency: 1899.8264367816091 ms, (p50: 1900 ms, p90: 2100 ms, p99: 4800 ms), latency samples: 1740
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.217, avg: 0.207", "QsPosToProposal: max: 0.313, avg: 0.232", "ConsensusProposalToOrdered: max: 0.453, avg: 0.408", "ConsensusOrderedToCommit: max: 0.377, avg: 0.352", "ConsensusProposalToCommit: max: 0.790, avg: 0.760"]
Max round gap was 1 [limit 4] at version 1761529. Max no progress secs was 4.67488 [limit 15] at version 1761529.
Test Ok

github-actions · 2024-05-29T02:49:19Z

✅ Forge suite `framework_upgrade` success on `3ffe0986b5fe4acb76544ae7ae85d73b91a6a411` ==> `c6b9ae57cab7e9863aa17633a64aa81c7a6ed7d6`

Compatibility test results for 3ffe0986b5fe4acb76544ae7ae85d73b91a6a411 ==> c6b9ae57cab7e9863aa17633a64aa81c7a6ed7d6 (PR)
Upgrade the nodes to version: c6b9ae57cab7e9863aa17633a64aa81c7a6ed7d6
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1290.4309344846658 txn/s, submitted: 1292.1034056087897 txn/s, failed submission: 1.6724711241238033 txn/s, expired: 1.6724711241238033 txn/s, latency: 2535.329355674875 ms, (p50: 1800 ms, p90: 4500 ms, p99: 7900 ms), latency samples: 108020
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1089.4420297440763 txn/s, submitted: 1091.6563428126617 txn/s, failed submission: 2.2143130685855206 txn/s, expired: 2.2143130685855206 txn/s, latency: 2764.316463414634 ms, (p50: 2100 ms, p90: 4800 ms, p99: 9700 ms), latency samples: 98400
5. check swarm health
Compatibility test for 3ffe0986b5fe4acb76544ae7ae85d73b91a6a411 ==> c6b9ae57cab7e9863aa17633a64aa81c7a6ed7d6 passed
Upgrade the remaining nodes to version: c6b9ae57cab7e9863aa17633a64aa81c7a6ed7d6
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1146.117462852096 txn/s, submitted: 1148.107250113992 txn/s, failed submission: 1.989787261896 txn/s, expired: 1.989787261896 txn/s, latency: 2582.8349054783953 ms, (p50: 2000 ms, p90: 4500 ms, p99: 7700 ms), latency samples: 103680
Test Ok

igor-aptos requested review from davidiw, movekevin and wrwg as code owners December 4, 2023 19:46

igor-aptos requested a review from lightmark December 4, 2023 19:47

igor-aptos marked this pull request as draft December 4, 2023 19:48

github-actions bot added the Stale label Jan 19, 2024

igor-aptos removed the Stale label Feb 2, 2024

igor-aptos mentioned this pull request Feb 2, 2024

[aip-43] Separate Concurrent Fungible Assets feature flag, for later release #11871

Merged

lightmark reviewed Feb 22, 2024

View reviewed changes

igor-aptos force-pushed the igor/concurrent_fungible_balance branch from 642b937 to 21cdef5 Compare February 22, 2024 23:27

igor-aptos changed the title ~~[draft] Concurrent FungibleAsset balance~~ Concurrent FungibleAsset balance Feb 23, 2024

igor-aptos marked this pull request as ready for review February 23, 2024 00:01

igor-aptos requested review from georgemitenkov and lightmark February 23, 2024 00:01

georgemitenkov reviewed Feb 25, 2024

View reviewed changes

alnoki mentioned this pull request Mar 2, 2024

[Framework] Add on-the-fly fungible store concurrency upgrade to general case #12348

Merged

alnoki suggested changes Mar 2, 2024

View reviewed changes

aptos-move/framework/aptos-framework/sources/fungible_asset.move Outdated

@@ -656,6 +708,25 @@ module aptos_framework::fungible_asset {

move_to(&metadata_object_signer, supply);

}

public fun upgrade_store_to_concurrent(

ref: &ExtendRef,

This comment was marked as resolved.

Sign in to view

lightmark reviewed Mar 4, 2024

View reviewed changes

igor-aptos force-pushed the igor/concurrent_fungible_balance branch from 195429b to b1f5998 Compare March 5, 2024 01:47

igor-aptos requested review from lightmark and georgemitenkov March 5, 2024 01:48

alnoki suggested changes Mar 5, 2024

View reviewed changes

igor-aptos force-pushed the igor/concurrent_fungible_balance branch from b1f5998 to 4b7ae39 Compare March 8, 2024 18:47

igor-aptos requested a review from junkil-park March 8, 2024 20:38

This comment has been minimized.

Sign in to view

igor-aptos force-pushed the igor/is_at_least_api branch from 386060c to 9f49c9c Compare May 28, 2024 22:37

Base automatically changed from igor/is_at_least_api to main May 28, 2024 23:12

igor-aptos added 3 commits May 28, 2024 16:31

concurrent fungible balance

fde7a6a

removing auto-upgrade checks. adding a test

6d034f8

fixing unit test

04873c5

igor-aptos force-pushed the igor/concurrent_fungible_balance branch from 7b8045d to 04873c5 Compare May 28, 2024 23:44

igor-aptos enabled auto-merge (squash) May 28, 2024 23:45

This comment has been minimized.

Sign in to view

verifier fixes

c6b9ae5

igor-aptos force-pushed the igor/concurrent_fungible_balance branch from b48a610 to c6b9ae5 Compare May 29, 2024 02:20

This comment has been minimized.

Sign in to view

igor-aptos merged commit 6ba90fc into main May 29, 2024
53 of 54 checks passed

igor-aptos deleted the igor/concurrent_fungible_balance branch May 29, 2024 02:54


		if (concurrent_fungible_balance_exists(addr)) {
		let ConcurrentFungibleBalance { balance } = move_from<ConcurrentFungibleBalance>(addr);

	if (auto_upgrade_to_concurrent_fungible_balance() \|\| concurrent_fungible_balance_exists(store_addr)) {
	if (auto_upgrade_to_concurrent_fungible_balance() \|\| concurrent_fungible_balance_exists_inline(store_addr)) {


		<<<<<<< HEAD

Concurrent FungibleAsset balance #11183

Concurrent FungibleAsset balance #11183

Conversation

igor-aptos commented Dec 4, 2023

Description

Test Plan

trunk-io bot commented Dec 4, 2023 • edited

igor-aptos commented Dec 4, 2023

github-actions bot commented Jan 19, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

This comment was marked as resolved.

Choose a reason for hiding this comment

This comment was marked as resolved.

Choose a reason for hiding this comment

This comment was marked as resolved.

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codecov bot commented Mar 5, 2024 • edited

Codecov Report

alnoki left a comment • edited

Choose a reason for hiding this comment

This comment was marked as resolved.

alnoki Mar 5, 2024 • edited

Choose a reason for hiding this comment

alnoki Mar 5, 2024 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

alnoki Mar 5, 2024 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

igor-aptos commented Mar 8, 2024

igor-aptos commented Mar 8, 2024 • edited

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

github-actions bot commented May 29, 2024

✅ Forge suite compat success on 3ffe0986b5fe4acb76544ae7ae85d73b91a6a411 ==> c6b9ae57cab7e9863aa17633a64aa81c7a6ed7d6

github-actions bot commented May 29, 2024

✅ Forge suite realistic_env_max_load success on c6b9ae57cab7e9863aa17633a64aa81c7a6ed7d6

github-actions bot commented May 29, 2024

✅ Forge suite framework_upgrade success on 3ffe0986b5fe4acb76544ae7ae85d73b91a6a411 ==> c6b9ae57cab7e9863aa17633a64aa81c7a6ed7d6

trunk-io bot commented Dec 4, 2023 •

edited

codecov bot commented Mar 5, 2024 •

edited

alnoki left a comment •

edited

alnoki Mar 5, 2024 •

edited

alnoki Mar 5, 2024 •

edited

alnoki Mar 5, 2024 •

edited

igor-aptos commented Mar 8, 2024 •

edited

✅ Forge suite `compat` success on `3ffe0986b5fe4acb76544ae7ae85d73b91a6a411` ==> `c6b9ae57cab7e9863aa17633a64aa81c7a6ed7d6`

✅ Forge suite `realistic_env_max_load` success on `c6b9ae57cab7e9863aa17633a64aa81c7a6ed7d6`

✅ Forge suite `framework_upgrade` success on `3ffe0986b5fe4acb76544ae7ae85d73b91a6a411` ==> `c6b9ae57cab7e9863aa17633a64aa81c7a6ed7d6`