-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce max_execution_gas / max_io_gas on v1.8 #11581
Conversation
⏱️ 3h 3m total CI duration on this PR
🚨 1 job on the last run was significantly faster/slower than expected
|
@@ -167,12 +167,12 @@ crate::gas_schedule::macros::define_gas_parameters!( | |||
[ | |||
max_execution_gas: InternalGas, | |||
{ 7.. => "max_execution_gas" }, | |||
20_000_000_000, | |||
5_000_000_000, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to bump the gas swchedule version as well I think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't update the gas feature version, otherwise we create more confusion and potentially enable gated features accidentally.
32f5422
to
4a3ebc4
Compare
4a3ebc4
to
e492a3b
Compare
e492a3b
to
eeec87a
Compare
eeec87a
to
5fd3c03
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
✅ Forge suite
|
✅ Forge suite
|
✅ Forge suite
|
in support of AIP, with more explanations there.
New values come to approximatelly 90ms for execution limit, and 100ms for io limit.
Description
Test Plan