Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce max_execution_gas / max_io_gas on v1.8 #11581

Merged
merged 1 commit into from
Jan 17, 2024

Conversation

igor-aptos
Copy link
Contributor

@igor-aptos igor-aptos commented Jan 5, 2024

in support of AIP, with more explanations there.

New values come to approximatelly 90ms for execution limit, and 100ms for io limit.

Description

Test Plan

Copy link

trunk-io bot commented Jan 5, 2024

⏱️ 3h 3m total CI duration on this PR
Job Cumulative Duration Recent Runs
rust-unit-tests 1h 54m 🟥🟥🟥🟥
rust-lints 39m 🟩🟩🟩🟩
run-tests-main-branch 13m 🟩🟩🟩🟩
general-lints 11m 🟩🟩🟩🟩
docs-lint 3m 🟩🟩🟩🟩
semgrep/ci 1m 🟩🟩🟩🟩
file_change_determinator 44s 🟩🟩🟩🟩
file_change_determinator 44s 🟩🟩🟩🟩
permission-check 17s 🟩🟩🟩🟩
permission-check 11s 🟩🟩🟩🟩
permission-check 10s 🟩🟩🟩🟩
permission-check 10s 🟩🟩🟩🟩

🚨 1 job on the last run was significantly faster/slower than expected

Job Duration vs 7d avg Delta
rust-lints 11m 8m +27%

settingsfeedbackdocs ⋅ learn more about trunk.io

@@ -167,12 +167,12 @@ crate::gas_schedule::macros::define_gas_parameters!(
[
max_execution_gas: InternalGas,
{ 7.. => "max_execution_gas" },
20_000_000_000,
5_000_000_000,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to bump the gas swchedule version as well I think?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't update the gas feature version, otherwise we create more confusion and potentially enable gated features accidentally.

@igor-aptos igor-aptos force-pushed the igor/v1.8_reduce_txn_max_limit branch 2 times, most recently from 32f5422 to 4a3ebc4 Compare January 8, 2024 17:45
@igor-aptos igor-aptos force-pushed the igor/v1.8_reduce_txn_max_limit branch from 4a3ebc4 to e492a3b Compare January 12, 2024 18:50
@igor-aptos igor-aptos force-pushed the igor/v1.8_reduce_txn_max_limit branch from e492a3b to eeec87a Compare January 16, 2024 21:37
@igor-aptos igor-aptos force-pushed the igor/v1.8_reduce_txn_max_limit branch from eeec87a to 5fd3c03 Compare January 17, 2024 00:06
@igor-aptos igor-aptos enabled auto-merge (squash) January 17, 2024 17:08

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

✅ Forge suite compat success on aptos-node-v1.7.3 ==> 5fd3c034d93f481143c8c62f9d03d9c59a680be7

Compatibility test results for aptos-node-v1.7.3 ==> 5fd3c034d93f481143c8c62f9d03d9c59a680be7 (PR)
1. Check liveness of validators at old version: aptos-node-v1.7.3
compatibility::simple-validator-upgrade::liveness-check : committed: 5006 txn/s, latency: 6271 ms, (p50: 6000 ms, p90: 9000 ms, p99: 14100 ms), latency samples: 190240
2. Upgrading first Validator to new version: 5fd3c034d93f481143c8c62f9d03d9c59a680be7
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 1772 txn/s, latency: 15704 ms, (p50: 18600 ms, p90: 21900 ms, p99: 22500 ms), latency samples: 92180
3. Upgrading rest of first batch to new version: 5fd3c034d93f481143c8c62f9d03d9c59a680be7
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 1773 txn/s, latency: 16169 ms, (p50: 19200 ms, p90: 22300 ms, p99: 22600 ms), latency samples: 92240
4. upgrading second batch to new version: 5fd3c034d93f481143c8c62f9d03d9c59a680be7
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 3294 txn/s, latency: 9530 ms, (p50: 9600 ms, p90: 13300 ms, p99: 13800 ms), latency samples: 135060
5. check swarm health
Compatibility test for aptos-node-v1.7.3 ==> 5fd3c034d93f481143c8c62f9d03d9c59a680be7 passed
Test Ok

Copy link
Contributor

✅ Forge suite realistic_env_max_load success on 5fd3c034d93f481143c8c62f9d03d9c59a680be7

two traffics test: inner traffic : committed: 7047 txn/s, latency: 5569 ms, (p50: 5400 ms, p90: 6600 ms, p99: 12000 ms), latency samples: 3044660
two traffics test : committed: 100 txn/s, latency: 2692 ms, (p50: 2300 ms, p90: 2900 ms, p99: 13900 ms), latency samples: 1740
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.252, avg: 0.213", "QsPosToProposal: max: 0.145, avg: 0.127", "ConsensusProposalToOrdered: max: 0.570, avg: 0.511", "ConsensusOrderedToCommit: max: 0.527, avg: 0.507", "ConsensusProposalToCommit: max: 1.034, avg: 1.018"]
Max round gap was 1 [limit 4] at version 1438361. Max no progress secs was 3.782402 [limit 10] at version 1438361.
Test Ok

@igor-aptos igor-aptos merged commit 68991b7 into aptos-release-v1.8 Jan 17, 2024
90 checks passed
@igor-aptos igor-aptos deleted the igor/v1.8_reduce_txn_max_limit branch January 17, 2024 17:43
Copy link
Contributor

✅ Forge suite framework_upgrade success on aptos-node-v1.7.3 ==> 5fd3c034d93f481143c8c62f9d03d9c59a680be7

Compatibility test results for aptos-node-v1.7.3 ==> 5fd3c034d93f481143c8c62f9d03d9c59a680be7 (PR)
Upgrade the nodes to version: 5fd3c034d93f481143c8c62f9d03d9c59a680be7
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 4886 txn/s, latency: 6583 ms, (p50: 6600 ms, p90: 9600 ms, p99: 14100 ms), latency samples: 180800
5. check swarm health
Compatibility test for aptos-node-v1.7.3 ==> 5fd3c034d93f481143c8c62f9d03d9c59a680be7 passed
Test Ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants