Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Execution] Increase the default concurrency to 32 #12200

Merged
merged 1 commit into from
Feb 24, 2024

Conversation

sitalkedia
Copy link
Contributor

Description

Since we have upgraded our default machine spec, we need to bump up the concurrency level to utilize the additional cores. 32 concurrency level worked the best from our previewnet load test.

Test Plan

Run Forge.

Copy link

trunk-io bot commented Feb 23, 2024

⏱️ 14h 52m total CI duration on this PR
Job Cumulative Duration Recent Runs
rust-unit-tests 2h 51m 🟩🟩🟩 (+3 more)
windows-build 2h 22m 🟩🟩🟥🟩🟩 (+3 more)
rust-smoke-tests 2h 7m 🟩🟩🟩🟩
execution-performance / single-node-performance 1h 38m 🟩🟩🟩🟩🟩
forge-compat-test / forge 58m 🟩🟩🟩🟩
rust-images / rust-all 54m 🟩🟩🟩🟩
forge-e2e-test / forge 53m 🟩🟩🟩🟩
run-tests-main-branch 41m 🟥🟥🟥🟥🟥 (+1 more)
rust-lints 40m 🟥🟥🟩 (+3 more)
cli-e2e-tests / run-cli-tests 32m 🟩🟩🟩🟩
check 26m 🟩🟩🟩 (+3 more)
check-dynamic-deps 17m 🟩🟩🟩🟩🟩 (+3 more)
general-lints 13m 🟩🟩🟩🟩 (+3 more)
node-api-compatibility-tests / node-api-compatibility-tests 7m 🟩🟩🟩🟩
file_change_determinator 5m 🟩🟩🟩🟩🟩
semgrep/ci 4m 🟩🟩🟩🟩🟩 (+3 more)
file_change_determinator 1m 🟩🟩🟩🟩🟩 (+3 more)
file_change_determinator 1m 🟩🟩🟩🟩 (+3 more)
execution-performance / file_change_determinator 48s 🟩🟩🟩🟩🟩
permission-check 40s 🟩🟩🟩🟩🟩
permission-check 34s 🟩🟩🟩🟩🟩 (+3 more)
permission-check 27s 🟩🟩🟩🟩🟩 (+3 more)
permission-check 26s 🟩🟩🟩🟩🟩 (+3 more)
permission-check 20s 🟩🟩🟩🟩🟩 (+3 more)
determine-docker-build-metadata 9s 🟩🟩🟩🟩🟩

🚨 4 jobs on the last run were significantly faster/slower than expected

Job Duration vs 7d avg Delta
file_change_determinator 4m 11s +2202%
node-api-compatibility-tests / node-api-compatibility-tests 5m 58s +397%
run-tests-main-branch 8m 4m +114%
windows-build 24m 20m +20%

settingsfeedbackdocs ⋅ learn more about trunk.io

Copy link
Contributor

@bchocho bchocho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sitalkedia sitalkedia enabled auto-merge (squash) February 23, 2024 20:37

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

✅ Forge suite realistic_env_max_load success on 8cf99ae659a0ec21420200eb2472ded9fa2dbb01

two traffics test: inner traffic : committed: 7817 txn/s, latency: 5019 ms, (p50: 4800 ms, p90: 5900 ms, p99: 9600 ms), latency samples: 3377080
two traffics test : committed: 100 txn/s, latency: 1946 ms, (p50: 1900 ms, p90: 2100 ms, p99: 2300 ms), latency samples: 1820
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.260, avg: 0.207", "QsPosToProposal: max: 0.523, avg: 0.465", "ConsensusProposalToOrdered: max: 0.588, avg: 0.549", "ConsensusOrderedToCommit: max: 0.359, avg: 0.342", "ConsensusProposalToCommit: max: 0.916, avg: 0.891"]
Max round gap was 1 [limit 4] at version 1605299. Max no progress secs was 4.304182 [limit 15] at version 1605299.
Test Ok

Copy link
Contributor

✅ Forge suite compat success on aptos-node-v1.9.5 ==> 8cf99ae659a0ec21420200eb2472ded9fa2dbb01

Compatibility test results for aptos-node-v1.9.5 ==> 8cf99ae659a0ec21420200eb2472ded9fa2dbb01 (PR)
1. Check liveness of validators at old version: aptos-node-v1.9.5
compatibility::simple-validator-upgrade::liveness-check : committed: 5525 txn/s, latency: 4943 ms, (p50: 4900 ms, p90: 7500 ms, p99: 14400 ms), latency samples: 243120
2. Upgrading first Validator to new version: 8cf99ae659a0ec21420200eb2472ded9fa2dbb01
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 611 txn/s, submitted: 614 txn/s, expired: 3 txn/s, latency: 36330 ms, (p50: 38500 ms, p90: 58800 ms, p99: 60000 ms), latency samples: 55641
3. Upgrading rest of first batch to new version: 8cf99ae659a0ec21420200eb2472ded9fa2dbb01
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 252 txn/s, submitted: 466 txn/s, expired: 214 txn/s, latency: 33459 ms, (p50: 36000 ms, p90: 52800 ms, p99: 63900 ms), latency samples: 25970
4. upgrading second batch to new version: 8cf99ae659a0ec21420200eb2472ded9fa2dbb01
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 2300 txn/s, latency: 13089 ms, (p50: 12900 ms, p90: 18600 ms, p99: 18900 ms), latency samples: 110440
5. check swarm health
Compatibility test for aptos-node-v1.9.5 ==> 8cf99ae659a0ec21420200eb2472ded9fa2dbb01 passed
Test Ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants