Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Execution] Increase the default concurrency to 32 #12211

Merged
merged 1 commit into from
Feb 24, 2024

Conversation

sitalkedia
Copy link
Contributor

Description

Since we have upgraded our default machine spec, we need to bump up the concurrency level to utilize the additional cores. 32 concurrency level worked the best from our previewnet load test.

Test Plan

Forge

Copy link

trunk-io bot commented Feb 23, 2024

⏱️ 7h 1m total CI duration on this PR
Job Cumulative Duration Recent Runs
rust-unit-tests 1h 6m 🟩
rust-smoke-tests 57m 🟩
windows-build 54m 🟩🟩
forge-framework-upgrade-test / forge 51m 🟥
execution-performance / single-node-performance 26m 🟥🟥
rust-images / rust-all 23m 🟩🟩
forge-compat-test / forge 23m 🟩
forge-e2e-test / forge 22m 🟩
cli-e2e-tests / run-cli-tests 20m 🟩
run-tests-main-branch 19m 🟥🟥🟥
rust-lints 18m 🟥🟥
check 11m 🟥🟥
general-lints 10m 🟩🟩
node-api-compatibility-tests / node-api-compatibility-tests 6m 🟩🟩
check-dynamic-deps 3m 🟩🟩
semgrep/ci 3m 🟩🟩
file_change_determinator 2m 🟩🟩🟩
file_change_determinator 2m 🟩🟩
permission-check 36s 🟩🟩
determine-docker-build-metadata 33s 🟩🟩
execution-performance / file_change_determinator 22s 🟩🟩
file_change_determinator 20s 🟩🟩
execution-performance / sequential-execution-performance 14s 🟩🟩
execution-performance / parallel-execution-performance 14s 🟩🟩
permission-check 14s 🟩🟩🟩
permission-check 13s 🟩🟩🟩
permission-check 8s 🟩🟩🟩
permission-check 8s 🟩🟩🟩
🚨 8 jobs on the last run were significantly faster/slower than expected
Job Duration vs 7d avg Delta
file_change_determinator 2m 10s +1144%
node-api-compatibility-tests / node-api-compatibility-tests 5m 56s +421%
cli-e2e-tests / run-cli-tests 13m 7m +105%
run-tests-main-branch 6m 4m +62%
check 6m 4m +51%
rust-unit-tests 46m 32m +47%
windows-build 29m 20m +42%
rust-smoke-tests 37m 30m +22%

settingsfeedbackdocs ⋅ learn more about trunk.io

@sitalkedia sitalkedia changed the base branch from main to aptos-release-v1.9 February 23, 2024 23:09
@sitalkedia sitalkedia changed the title Concurrency upgrade 1.9 [Execution] Increase the default concurrency to 32 Feb 23, 2024
@sitalkedia sitalkedia enabled auto-merge (squash) February 23, 2024 23:32

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

✅ Forge suite realistic_env_max_load success on ae026cc37a3e753703719ad503bc73d8d8b181af

two traffics test: inner traffic : committed: 8165 txn/s, latency: 4777 ms, (p50: 4500 ms, p90: 5700 ms, p99: 12700 ms), latency samples: 3527360
two traffics test : committed: 100 txn/s, latency: 2092 ms, (p50: 2000 ms, p90: 2500 ms, p99: 2900 ms), latency samples: 1780
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.259, avg: 0.206", "QsPosToProposal: max: 0.200, avg: 0.168", "ConsensusProposalToOrdered: max: 0.603, avg: 0.551", "ConsensusOrderedToCommit: max: 0.433, avg: 0.414", "ConsensusProposalToCommit: max: 1.022, avg: 0.966"]
Max round gap was 1 [limit 4] at version 1667078. Max no progress secs was 9.242454 [limit 10] at version 1667078.
Test Ok

Copy link
Contributor

✅ Forge suite compat success on aptos-node-v1.8.3 ==> ae026cc37a3e753703719ad503bc73d8d8b181af

Compatibility test results for aptos-node-v1.8.3 ==> ae026cc37a3e753703719ad503bc73d8d8b181af (PR)
1. Check liveness of validators at old version: aptos-node-v1.8.3
compatibility::simple-validator-upgrade::liveness-check : committed: 4924 txn/s, latency: 6648 ms, (p50: 7100 ms, p90: 10200 ms, p99: 10700 ms), latency samples: 182220
2. Upgrading first Validator to new version: ae026cc37a3e753703719ad503bc73d8d8b181af
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 1859 txn/s, latency: 15835 ms, (p50: 19000 ms, p90: 22000 ms, p99: 22300 ms), latency samples: 92960
3. Upgrading rest of first batch to new version: ae026cc37a3e753703719ad503bc73d8d8b181af
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 1551 txn/s, latency: 18596 ms, (p50: 19000 ms, p90: 29900 ms, p99: 30100 ms), latency samples: 93060
4. upgrading second batch to new version: ae026cc37a3e753703719ad503bc73d8d8b181af
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 2905 txn/s, latency: 10949 ms, (p50: 9900 ms, p90: 16800 ms, p99: 19400 ms), latency samples: 122040
5. check swarm health
Compatibility test for aptos-node-v1.8.3 ==> ae026cc37a3e753703719ad503bc73d8d8b181af passed
Test Ok

@sitalkedia sitalkedia merged commit 0ad1162 into aptos-release-v1.9 Feb 24, 2024
47 of 52 checks passed
@sitalkedia sitalkedia deleted the concurrency_upgrade_1.9 branch February 24, 2024 00:39
Copy link
Contributor

❌ Forge suite framework_upgrade failure on aptos-node-v1.8.3 ==> ae026cc37a3e753703719ad503bc73d8d8b181af

Compatibility test results for aptos-node-v1.8.3 ==> ae026cc37a3e753703719ad503bc73d8d8b181af (PR)
Upgrade the nodes to version: ae026cc37a3e753703719ad503bc73d8d8b181af
Test Failed: API error: Unknown error error sending request for url (http://aptos-node-3-validator.forge-framework-upgrade-pr-12211.svc:8080/v1/estimate_gas_price): error trying to connect: dns error: failed to lookup address information: Name or service not known

Stack backtrace:
   0: <unknown>
   1: <unknown>
   2: <unknown>
   3: <unknown>
   4: <unknown>
   5: <unknown>
   6: <unknown>
   7: <unknown>
   8: <unknown>
   9: <unknown>
  10: <unknown>
  11: <unknown>
  12: __libc_start_main
  13: <unknown>
Trailing Log Lines:
   5: <unknown>
   6: <unknown>
   7: <unknown>
   8: <unknown>
   9: <unknown>
  10: <unknown>
  11: <unknown>
  12: __libc_start_main
  13: <unknown>


Swarm logs can be found here: See fgi output for more information.
thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: ApiError: namespaces "forge-framework-upgrade-pr-12211" not found: NotFound (ErrorResponse { status: "Failure", message: "namespaces \"forge-framework-upgrade-pr-12211\" not found", reason: "NotFound", code: 404 })

Caused by:
    namespaces "forge-framework-upgrade-pr-12211" not found: NotFound

Stack backtrace:
   0: <unknown>
   1: <unknown>
   2: <unknown>
   3: <unknown>
   4: <unknown>
   5: <unknown>
   6: <unknown>
   7: <unknown>
   8: <unknown>
   9: <unknown>
  10: <unknown>
  11: <unknown>
  12: <unknown>
  13: <unknown>
  14: <unknown>
  15: __libc_start_main
  16: <unknown>', testsuite/forge/src/backend/k8s/swarm.rs:676:18
stack backtrace:
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.
Debugging output:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants