Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[License Check] Update license check for exact matches. #12690

Merged
merged 3 commits into from Mar 26, 2024

Conversation

JoshLind
Copy link
Contributor

@JoshLind JoshLind commented Mar 26, 2024

Description

This PR updates the license checker to ensure that all files contain either: (i) the shared license header; or (ii) the Aptos-specific license header. This is now possible that Lucas-C/pre-commit-hooks#68 has been resolved 😄

The PR offers the following commits:

  1. Update the license checker and template files.
  2. Update the broken/invalid license headers.
  3. Continue to update the broken/invalid license headers.

Testing Plan

Existing test infrastructure.

Copy link

trunk-io bot commented Mar 26, 2024

⏱️ 10h 18m total CI duration on this PR
Job Cumulative Duration Recent Runs
rust-unit-tests 2h 3m 🟥🟩🟩 (+2 more)
windows-build 1h 42m 🟩🟩🟩🟩🟩 (+2 more)
rust-move-tests 1h 30m 🟩🟩🟩 (+2 more)
rust-move-unit-coverage 1h 13m 🟩🟩
rust-lints 37m 🟥🟩🟩🟩🟩 (+2 more)
rust-smoke-tests 31m 🟩
run-tests-main-branch 30m 🟩🟩🟩🟩🟩 (+2 more)
execution-performance / single-node-performance 22m 🟩
rust-images / rust-all 19m 🟩
check 18m 🟥🟥🟩🟩🟩 (+2 more)
forge-e2e-test / forge 15m 🟩
check-dynamic-deps 15m 🟩🟩🟩🟩🟩 (+2 more)
general-lints 14m 🟩🟩🟩🟩🟩 (+2 more)
forge-compat-test / forge 14m 🟩
cli-e2e-tests / run-cli-tests 7m 🟩
semgrep/ci 3m 🟩🟩🟩🟩🟩 (+2 more)
file_change_determinator 1m 🟩🟩🟩🟩🟩 (+2 more)
file_change_determinator 1m 🟩🟩🟩🟩🟩 (+2 more)
node-api-compatibility-tests / node-api-compatibility-tests 50s 🟩
permission-check 30s 🟩🟩🟩🟩🟩 (+2 more)
permission-check 27s 🟩🟩🟩🟩🟩 (+2 more)
permission-check 24s 🟩🟩🟩🟩🟩 (+2 more)
permission-check 18s 🟩🟩🟩🟩🟩 (+2 more)
file_change_determinator 9s 🟩
execution-performance / file_change_determinator 8s 🟩
permission-check 2s 🟩
determine-docker-build-metadata 2s 🟩

🚨 3 jobs on the last run were significantly faster/slower than expected

Job Duration vs 7d avg Delta
rust-images / rust-all 19m 16m +21%
rust-move-tests 14m 18m -22%
windows-build 12m 21m -41%

settingsfeedbackdocs ⋅ learn more about trunk.io

@JoshLind JoshLind marked this pull request as ready for review March 26, 2024 21:44
@JoshLind JoshLind requested a review from a team March 26, 2024 21:50
Copy link

codecov bot commented Mar 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.1%. Comparing base (c1e6011) to head (05787c6).
Report is 1 commits behind head on main.

❗ Current head 05787c6 differs from pull request most recent head 18c288a. Consider uploading reports for the commit 18c288a to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #12690   +/-   ##
=======================================
  Coverage    64.1%    64.1%           
=======================================
  Files         819      819           
  Lines      183129   183129           
=======================================
  Hits       117397   117397           
  Misses      65732    65732           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JoshLind JoshLind enabled auto-merge (rebase) March 26, 2024 22:59

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

✅ Forge suite compat success on aptos-node-v1.9.5 ==> 18c288a108c6baf2709b9d8f96f516135cd17e5f

Compatibility test results for aptos-node-v1.9.5 ==> 18c288a108c6baf2709b9d8f96f516135cd17e5f (PR)
1. Check liveness of validators at old version: aptos-node-v1.9.5
compatibility::simple-validator-upgrade::liveness-check : committed: 6924 txn/s, latency: 4805 ms, (p50: 4800 ms, p90: 7500 ms, p99: 8100 ms), latency samples: 242360
2. Upgrading first Validator to new version: 18c288a108c6baf2709b9d8f96f516135cd17e5f
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 1810 txn/s, latency: 16640 ms, (p50: 17700 ms, p90: 22200 ms, p99: 22700 ms), latency samples: 92360
3. Upgrading rest of first batch to new version: 18c288a108c6baf2709b9d8f96f516135cd17e5f
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 517 txn/s, submitted: 723 txn/s, expired: 205 txn/s, latency: 28854 ms, (p50: 25900 ms, p90: 53600 ms, p99: 57100 ms), latency samples: 42974
4. upgrading second batch to new version: 18c288a108c6baf2709b9d8f96f516135cd17e5f
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 1942 txn/s, latency: 14594 ms, (p50: 15400 ms, p90: 19800 ms, p99: 20500 ms), latency samples: 97120
5. check swarm health
Compatibility test for aptos-node-v1.9.5 ==> 18c288a108c6baf2709b9d8f96f516135cd17e5f passed
Test Ok

Copy link
Contributor

✅ Forge suite realistic_env_max_load success on 18c288a108c6baf2709b9d8f96f516135cd17e5f

two traffics test: inner traffic : committed: 7909 txn/s, latency: 4964 ms, (p50: 4800 ms, p90: 5700 ms, p99: 10200 ms), latency samples: 3409160
two traffics test : committed: 100 txn/s, latency: 2020 ms, (p50: 1800 ms, p90: 2100 ms, p99: 6500 ms), latency samples: 1740
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.209, avg: 0.202", "QsPosToProposal: max: 0.260, avg: 0.241", "ConsensusProposalToOrdered: max: 0.487, avg: 0.444", "ConsensusOrderedToCommit: max: 0.313, avg: 0.300", "ConsensusProposalToCommit: max: 0.760, avg: 0.744"]
Max round gap was 1 [limit 4] at version 1647417. Max no progress secs was 4.622276 [limit 15] at version 1647417.
Test Ok

@JoshLind JoshLind merged commit 0fe7029 into main Mar 26, 2024
101 checks passed
@JoshLind JoshLind deleted the fix_copyright_issues branch March 26, 2024 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants