New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[License Check] Update license check for exact matches. #12690
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoshLind
force-pushed
the
fix_copyright_issues
branch
from
March 26, 2024 21:23
6963268
to
dd0ae4e
Compare
JoshLind
requested review from
alinush,
rex1fernando,
msmouse,
lightmark,
grao1991,
zjma,
mstraka100,
zekun000,
sasha8,
ibalajiarun,
gregnazario,
davidiw,
movekevin,
wrwg,
vgao1996 and
georgemitenkov
as code owners
March 26, 2024 21:23
msmouse
approved these changes
Mar 26, 2024
JoshLind
force-pushed
the
fix_copyright_issues
branch
from
March 26, 2024 21:48
eb3a86a
to
9d01c9a
Compare
JoshLind
force-pushed
the
fix_copyright_issues
branch
from
March 26, 2024 22:01
9d01c9a
to
05787c6
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12690 +/- ##
=======================================
Coverage 64.1% 64.1%
=======================================
Files 819 819
Lines 183129 183129
=======================================
Hits 117397 117397
Misses 65732 65732 ☔ View full report in Codecov by Sentry. |
JoshLind
force-pushed
the
fix_copyright_issues
branch
from
March 26, 2024 22:34
05787c6
to
18c288a
Compare
grao1991
approved these changes
Mar 26, 2024
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
✅ Forge suite
|
✅ Forge suite
|
21 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the license checker to ensure that all files contain either: (i) the shared license header; or (ii) the Aptos-specific license header. This is now possible that Lucas-C/pre-commit-hooks#68 has been resolved 😄
The PR offers the following commits:
Testing Plan
Existing test infrastructure.