Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[consensus] add missing checks for commit cert #13379

Merged
merged 1 commit into from
May 28, 2024
Merged

[consensus] add missing checks for commit cert #13379

merged 1 commit into from
May 28, 2024

Conversation

zekun000
Copy link
Contributor

@zekun000 zekun000 commented May 21, 2024

Cherry-pick a fix for an issue that a malicious node can use ordered cert as commit cert to panic other validators because we assert if the execution result is different from the cert (ordered cert has dummy values)

Copy link

trunk-io bot commented May 21, 2024

Copy link
Contributor

@igor-aptos igor-aptos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add in the description of the PR what the issue was and how this fixes it?

@sherry-x sherry-x enabled auto-merge (squash) May 22, 2024 22:32

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

✅ Forge suite compat success on 3ffe0986b5fe4acb76544ae7ae85d73b91a6a411 ==> 12637b4b08c1e779ad45d8653b4e10ba784afc00

Compatibility test results for 3ffe0986b5fe4acb76544ae7ae85d73b91a6a411 ==> 12637b4b08c1e779ad45d8653b4e10ba784afc00 (PR)
1. Check liveness of validators at old version: 3ffe0986b5fe4acb76544ae7ae85d73b91a6a411
compatibility::simple-validator-upgrade::liveness-check : committed: 6560.119522964896 txn/s, latency: 5003.338857564191 ms, (p50: 4900 ms, p90: 5900 ms, p99: 7200 ms), latency samples: 230560
2. Upgrading first Validator to new version: 12637b4b08c1e779ad45d8653b4e10ba784afc00
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 3390.078719917915 txn/s, latency: 9170.365741274878 ms, (p50: 9400 ms, p90: 13900 ms, p99: 14200 ms), latency samples: 138680
3. Upgrading rest of first batch to new version: 12637b4b08c1e779ad45d8653b4e10ba784afc00
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 3323.530598708836 txn/s, latency: 9386.42022911833 ms, (p50: 9400 ms, p90: 14200 ms, p99: 14500 ms), latency samples: 137920
4. upgrading second batch to new version: 12637b4b08c1e779ad45d8653b4e10ba784afc00
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 6350.480850521189 txn/s, latency: 5128.499215246637 ms, (p50: 4800 ms, p90: 8400 ms, p99: 9700 ms), latency samples: 231920
5. check swarm health
Compatibility test for 3ffe0986b5fe4acb76544ae7ae85d73b91a6a411 ==> 12637b4b08c1e779ad45d8653b4e10ba784afc00 passed
Test Ok

Copy link
Contributor

✅ Forge suite realistic_env_max_load success on 12637b4b08c1e779ad45d8653b4e10ba784afc00

two traffics test: inner traffic : committed: 7889.34557597471 txn/s, latency: 4958.659187254351 ms, (p50: 4800 ms, p90: 6600 ms, p99: 10500 ms), latency samples: 3419520
two traffics test : committed: 100.0060702245383 txn/s, latency: 1927.0288888888888 ms, (p50: 1900 ms, p90: 2200 ms, p99: 3900 ms), latency samples: 1800
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.214, avg: 0.204", "QsPosToProposal: max: 0.268, avg: 0.246", "ConsensusProposalToOrdered: max: 0.450, avg: 0.410", "ConsensusOrderedToCommit: max: 0.403, avg: 0.383", "ConsensusProposalToCommit: max: 0.810, avg: 0.793"]
Max round gap was 1 [limit 4] at version 1643154. Max no progress secs was 4.568968 [limit 15] at version 1643154.
Test Ok

Copy link
Contributor

✅ Forge suite framework_upgrade success on 3ffe0986b5fe4acb76544ae7ae85d73b91a6a411 ==> 12637b4b08c1e779ad45d8653b4e10ba784afc00

Compatibility test results for 3ffe0986b5fe4acb76544ae7ae85d73b91a6a411 ==> 12637b4b08c1e779ad45d8653b4e10ba784afc00 (PR)
Upgrade the nodes to version: 12637b4b08c1e779ad45d8653b4e10ba784afc00
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1149.435453652345 txn/s, submitted: 1152.1210505066729 txn/s, failed submission: 2.6855968543279087 txn/s, expired: 2.6855968543279087 txn/s, latency: 2672.8723520249223 ms, (p50: 2100 ms, p90: 4800 ms, p99: 8700 ms), latency samples: 102720
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1063.8183941381712 txn/s, submitted: 1066.007320875081 txn/s, failed submission: 2.188926736909817 txn/s, expired: 2.188926736909817 txn/s, latency: 2784.132561728395 ms, (p50: 2000 ms, p90: 5600 ms, p99: 9800 ms), latency samples: 97200
5. check swarm health
Compatibility test for 3ffe0986b5fe4acb76544ae7ae85d73b91a6a411 ==> 12637b4b08c1e779ad45d8653b4e10ba784afc00 passed
Upgrade the remaining nodes to version: 12637b4b08c1e779ad45d8653b4e10ba784afc00
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 635.7976147453237 txn/s, submitted: 637.5612697099432 txn/s, failed submission: 1.763654964619483 txn/s, expired: 1.763654964619483 txn/s, latency: 4762.072156726768 ms, (p50: 4200 ms, p90: 8400 ms, p99: 9600 ms), latency samples: 57680
Test Ok

@sherry-x sherry-x merged commit 0ee977e into main May 28, 2024
50 of 51 checks passed
@sherry-x sherry-x deleted the zekun/fix branch May 28, 2024 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants