Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix) Reorder the parameters and adapt them to Nextest. #13400

Merged
merged 5 commits into from
May 29, 2024

Conversation

zi0Black
Copy link
Contributor

Description

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Other (specify)

How Has This Been Tested?

Local tests + tests on this PR

Key Areas to Review

N/A

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

@zi0Black zi0Black added the CICD:run-coverage run tests with test coverage instrumentation label May 23, 2024
@zi0Black zi0Black requested a review from a team as a code owner May 23, 2024 12:58
Copy link

trunk-io bot commented May 23, 2024

⏱️ 1h 25m total CI duration on this PR
Job Cumulative Duration Recent Runs
rust-unit-coverage 17m 🟩
rust-move-unit-coverage 17m 🟩
rust-smoke-coverage 17m 🟩
rust-move-tests 7m 🟩
run-tests-main-branch 6m 🟩
rust-lints 6m 🟩
test-target-determinator 4m 🟩
rust-targeted-unit-tests 4m 🟩
check-dynamic-deps 3m 🟩🟩
general-lints 2m 🟩
semgrep/ci 49s 🟩🟩
rust-images / rust-all 32s 🟩
upload-to-codecov 16s 🟩
file_change_determinator 11s 🟩
file_change_determinator 9s 🟩
file_change_determinator 9s 🟩
permission-check 7s 🟩
permission-check 7s 🟩🟩
permission-check 5s 🟩🟩
permission-check 3s 🟩
permission-check 2s 🟩
determine-docker-build-metadata 1s 🟩

🚨 3 jobs on the last run were significantly faster/slower than expected

Job Duration vs 7d avg Delta
run-tests-main-branch 6m 4m +35%
rust-targeted-unit-tests 4m 18m -80%
rust-images / rust-all 32s 13m -96%

settingsfeedbackdocs ⋅ learn more about trunk.io

Copy link

codecov bot commented May 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.4%. Comparing base (d6ce1b9) to head (74a26cc).
Report is 18 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main   #13400       +/-   ##
===========================================
+ Coverage    32.9%    71.4%    +38.4%     
===========================================
  Files        1768     2308      +540     
  Lines      339264   453596   +114332     
===========================================
+ Hits       111949   323916   +211967     
+ Misses     227315   129680    -97635     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zi0Black zi0Black added CICD:run-coverage run tests with test coverage instrumentation and removed CICD:run-coverage run tests with test coverage instrumentation labels May 23, 2024
@zi0Black zi0Black added CICD:run-coverage run tests with test coverage instrumentation and removed CICD:run-coverage run tests with test coverage instrumentation labels May 24, 2024
@zi0Black zi0Black added CICD:run-coverage run tests with test coverage instrumentation and removed CICD:run-coverage run tests with test coverage instrumentation labels May 28, 2024
@sherry-x sherry-x enabled auto-merge (squash) May 29, 2024 17:20

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

✅ Forge suite compat success on 3ffe0986b5fe4acb76544ae7ae85d73b91a6a411 ==> 74a26cc0da9c81b29aa7a3b3380adf931e27a184

Compatibility test results for 3ffe0986b5fe4acb76544ae7ae85d73b91a6a411 ==> 74a26cc0da9c81b29aa7a3b3380adf931e27a184 (PR)
1. Check liveness of validators at old version: 3ffe0986b5fe4acb76544ae7ae85d73b91a6a411
compatibility::simple-validator-upgrade::liveness-check : committed: 6542.9122852657665 txn/s, latency: 4745.85123888183 ms, (p50: 4800 ms, p90: 5300 ms, p99: 8100 ms), latency samples: 251840
2. Upgrading first Validator to new version: 74a26cc0da9c81b29aa7a3b3380adf931e27a184
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 3366.279410100376 txn/s, latency: 9269.37798540146 ms, (p50: 9600 ms, p90: 13900 ms, p99: 14200 ms), latency samples: 137000
3. Upgrading rest of first batch to new version: 74a26cc0da9c81b29aa7a3b3380adf931e27a184
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 3344.692868753504 txn/s, latency: 9262.81146608315 ms, (p50: 9400 ms, p90: 13900 ms, p99: 14200 ms), latency samples: 137100
4. upgrading second batch to new version: 74a26cc0da9c81b29aa7a3b3380adf931e27a184
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 6496.432845921486 txn/s, latency: 5073.292521423007 ms, (p50: 4800 ms, p90: 8100 ms, p99: 9300 ms), latency samples: 231060
5. check swarm health
Compatibility test for 3ffe0986b5fe4acb76544ae7ae85d73b91a6a411 ==> 74a26cc0da9c81b29aa7a3b3380adf931e27a184 passed
Test Ok

Copy link
Contributor

✅ Forge suite realistic_env_max_load success on 74a26cc0da9c81b29aa7a3b3380adf931e27a184

two traffics test: inner traffic : committed: 7513.33197320324 txn/s, latency: 5213.4378359673465 ms, (p50: 5100 ms, p90: 6800 ms, p99: 10300 ms), latency samples: 3251060
two traffics test : committed: 99.94375518836988 txn/s, latency: 1895.4868131868132 ms, (p50: 1900 ms, p90: 2100 ms, p99: 2400 ms), latency samples: 1820
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.213, avg: 0.204", "QsPosToProposal: max: 0.287, avg: 0.255", "ConsensusProposalToOrdered: max: 0.456, avg: 0.417", "ConsensusOrderedToCommit: max: 0.399, avg: 0.379", "ConsensusProposalToCommit: max: 0.812, avg: 0.796"]
Max round gap was 1 [limit 4] at version 1487799. Max no progress secs was 4.504017 [limit 15] at version 1487799.
Test Ok

@sherry-x sherry-x merged commit a01524a into main May 29, 2024
137 of 151 checks passed
@sherry-x sherry-x deleted the fix-nextest-parameters branch May 29, 2024 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CICD:run-coverage run tests with test coverage instrumentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants