Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry pick lower gas for keyless TXNs by 3x in transaction.rs (#13397) #13405

Merged
merged 2 commits into from
May 23, 2024

Conversation

alinush
Copy link
Contributor

@alinush alinush commented May 23, 2024

Description

Cherry-picking #13397 onto v1.12.

@alinush alinush enabled auto-merge (squash) May 23, 2024 20:06
@sherry-x
Copy link
Contributor

could you please also add the gas upgrade step in the keyless.yaml, so your change will be applied at the time we enable keyless https://github.com/aptos-labs/aptos-core/blob/aptos-release-v1.12/aptos-move/aptos-release-builder/data/keyless.yaml

add a - DefaultGas in the update_sequence

This comment has been minimized.

This comment has been minimized.

@alinush
Copy link
Contributor Author

alinush commented May 23, 2024

could you please also add the gas upgrade step in the keyless.yaml, so your change will be applied at the time we enable keyless https://github.com/aptos-labs/aptos-core/blob/aptos-release-v1.12/aptos-move/aptos-release-builder/data/keyless.yaml

add a - DefaultGas in the update_sequence

Done!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

✅ Forge suite compat success on 01b24e7e3548382dd25440b39a0438a993387f12 ==> a67ed84bc93ef39d6909e48cb84eaba6c3e354eb

Compatibility test results for 01b24e7e3548382dd25440b39a0438a993387f12 ==> a67ed84bc93ef39d6909e48cb84eaba6c3e354eb (PR)
1. Check liveness of validators at old version: 01b24e7e3548382dd25440b39a0438a993387f12
compatibility::simple-validator-upgrade::liveness-check : committed: 6794 txn/s, latency: 4869 ms, (p50: 4800 ms, p90: 7800 ms, p99: 9300 ms), latency samples: 237820
2. Upgrading first Validator to new version: a67ed84bc93ef39d6909e48cb84eaba6c3e354eb
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 2897 txn/s, latency: 10713 ms, (p50: 10200 ms, p90: 14500 ms, p99: 15200 ms), latency samples: 130380
3. Upgrading rest of first batch to new version: a67ed84bc93ef39d6909e48cb84eaba6c3e354eb
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 3464 txn/s, latency: 9044 ms, (p50: 9700 ms, p90: 13400 ms, p99: 14200 ms), latency samples: 135100
4. upgrading second batch to new version: a67ed84bc93ef39d6909e48cb84eaba6c3e354eb
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 5394 txn/s, latency: 6270 ms, (p50: 5400 ms, p90: 9400 ms, p99: 10800 ms), latency samples: 183400
5. check swarm health
Compatibility test for 01b24e7e3548382dd25440b39a0438a993387f12 ==> a67ed84bc93ef39d6909e48cb84eaba6c3e354eb passed
Test Ok

Copy link
Contributor

✅ Forge suite realistic_env_max_load success on a67ed84bc93ef39d6909e48cb84eaba6c3e354eb

two traffics test: inner traffic : committed: 7652 txn/s, latency: 5122 ms, (p50: 4800 ms, p90: 6600 ms, p99: 10400 ms), latency samples: 3305800
two traffics test : committed: 100 txn/s, latency: 1847 ms, (p50: 1800 ms, p90: 2000 ms, p99: 2200 ms), latency samples: 1720
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.213, avg: 0.203", "QsPosToProposal: max: 0.327, avg: 0.275", "ConsensusProposalToOrdered: max: 0.462, avg: 0.424", "ConsensusOrderedToCommit: max: 0.368, avg: 0.350", "ConsensusProposalToCommit: max: 0.800, avg: 0.775"]
Max round gap was 1 [limit 4] at version 1639114. Max no progress secs was 4.390274 [limit 15] at version 1639114.
Test Ok

Copy link
Contributor

✅ Forge suite framework_upgrade success on 01b24e7e3548382dd25440b39a0438a993387f12 ==> a67ed84bc93ef39d6909e48cb84eaba6c3e354eb

Compatibility test results for 01b24e7e3548382dd25440b39a0438a993387f12 ==> a67ed84bc93ef39d6909e48cb84eaba6c3e354eb (PR)
Upgrade the nodes to version: a67ed84bc93ef39d6909e48cb84eaba6c3e354eb
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1361 txn/s, submitted: 1364 txn/s, failed submission: 2 txn/s, expired: 2 txn/s, latency: 2321 ms, (p50: 1800 ms, p90: 4200 ms, p99: 6000 ms), latency samples: 117100
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1312 txn/s, submitted: 1314 txn/s, failed submission: 2 txn/s, expired: 2 txn/s, latency: 2424 ms, (p50: 1800 ms, p90: 4300 ms, p99: 6300 ms), latency samples: 114180
5. check swarm health
Compatibility test for 01b24e7e3548382dd25440b39a0438a993387f12 ==> a67ed84bc93ef39d6909e48cb84eaba6c3e354eb passed
Upgrade the remaining nodes to version: a67ed84bc93ef39d6909e48cb84eaba6c3e354eb
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1288 txn/s, submitted: 1289 txn/s, failed submission: 1 txn/s, expired: 1 txn/s, latency: 2403 ms, (p50: 1800 ms, p90: 4200 ms, p99: 6600 ms), latency samples: 114660
Test Ok

@sherry-x sherry-x disabled auto-merge May 23, 2024 22:53
@sherry-x sherry-x merged commit f1abc91 into aptos-release-v1.12 May 23, 2024
98 of 100 checks passed
@sherry-x sherry-x deleted the alin/cherry-pick-keyless-3x-lower-gas branch May 23, 2024 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants