Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick lower gas for keyless TXNs in v1.13 #13536

Merged
merged 3 commits into from
Jun 3, 2024

Conversation

alinush
Copy link
Contributor

@alinush alinush commented Jun 3, 2024

Cherry picks #13397 into v1.13.

Copy link

trunk-io bot commented Jun 3, 2024

⏱️ 7h 5m total CI duration on this PR
Job Cumulative Duration Recent Runs
windows-build 2h 7m 🟩🟩🟩
execution-performance / single-node-performance 1h 18m 🟥🟥🟥
rust-targeted-unit-tests 33m 🟩
rust-move-tests 20m 🟩
rust-smoke-tests 19m 🟥
rust-images / rust-all 18m 🟩
run-tests-main-branch 17m 🟩🟩🟩
forge-framework-upgrade-test / forge 16m 🟩
rust-lints 15m 🟩
forge-e2e-test / forge 14m 🟩
forge-compat-test / forge 12m 🟩
cli-e2e-tests / run-cli-tests 9m 🟥
execution-performance / test-target-determinator 8m 🟩🟩🟩
rust-build-cached-packages 8m 🟩
check 8m 🟩
check-dynamic-deps 6m 🟩🟩🟩🟩
test-target-determinator 6m 🟩
general-lints 6m 🟩🟩🟩
semgrep/ci 1m 🟩🟩🟩🟩
node-api-compatibility-tests / node-api-compatibility-tests 51s 🟩
file_change_determinator 40s 🟩🟩🟩🟩
file_change_determinator 36s 🟩🟩🟩🟩
file_change_determinator 30s 🟩🟩🟩
permission-check 13s 🟩🟩🟩
determine-docker-build-metadata 12s 🟩🟩🟩
permission-check 11s 🟩🟩🟩🟩
permission-check 11s 🟩🟩🟩🟩
permission-check 11s 🟩🟩🟩🟩
permission-check 11s 🟩🟩🟩🟩
🚨 6 jobs on the last run were significantly faster/slower than expected
Job Duration vs 7d avg Delta
rust-targeted-unit-tests 27m 18m +46%
rust-move-tests 13m 9m +38%
rust-lints 8m 7m +29%
cli-e2e-tests / run-cli-tests 9m 7m +29%
execution-performance / single-node-performance 26m 22m +22%
windows-build 45m 37m +21%

settingsfeedbackdocs ⋅ learn more about trunk.io

@sherry-x sherry-x requested a review from vgao1996 June 3, 2024 23:13
@alinush alinush changed the title Lower gas for keyless TXNs by 3x in transaction.rs (#13397) Cherry-pick lower gas for keyless TXNs in v1.13 Jun 3, 2024
@alinush alinush enabled auto-merge (squash) June 3, 2024 23:16

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

github-actions bot commented Jun 3, 2024

✅ Forge suite compat success on c90dafdb2f450e4d3aa16b1a7cff8e3cad2b882e ==> 0329f5b865b67b72ca7e770550d228e7a0d5e38f

Compatibility test results for c90dafdb2f450e4d3aa16b1a7cff8e3cad2b882e ==> 0329f5b865b67b72ca7e770550d228e7a0d5e38f (PR)
1. Check liveness of validators at old version: c90dafdb2f450e4d3aa16b1a7cff8e3cad2b882e
compatibility::simple-validator-upgrade::liveness-check : committed: 6736.412385788635 txn/s, latency: 4900.915710499649 ms, (p50: 4800 ms, p90: 8100 ms, p99: 8700 ms), latency samples: 256580
2. Upgrading first Validator to new version: 0329f5b865b67b72ca7e770550d228e7a0d5e38f
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 2857.492995803457 txn/s, latency: 10796.827923063945 ms, (p50: 12000 ms, p90: 14200 ms, p99: 14700 ms), latency samples: 118540
3. Upgrading rest of first batch to new version: 0329f5b865b67b72ca7e770550d228e7a0d5e38f
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 3340.4922335806114 txn/s, latency: 9293.281808372896 ms, (p50: 9400 ms, p90: 14000 ms, p99: 14300 ms), latency samples: 139020
4. upgrading second batch to new version: 0329f5b865b67b72ca7e770550d228e7a0d5e38f
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 4743.7219728526 txn/s, latency: 6839.026931529031 ms, (p50: 5100 ms, p90: 12800 ms, p99: 17000 ms), latency samples: 172920
5. check swarm health
Compatibility test for c90dafdb2f450e4d3aa16b1a7cff8e3cad2b882e ==> 0329f5b865b67b72ca7e770550d228e7a0d5e38f passed
Test Ok

Copy link
Contributor

github-actions bot commented Jun 3, 2024

✅ Forge suite realistic_env_max_load success on 0329f5b865b67b72ca7e770550d228e7a0d5e38f

two traffics test: inner traffic : committed: 7451.374465703552 txn/s, latency: 5260.956430519574 ms, (p50: 5100 ms, p90: 6700 ms, p99: 12000 ms), latency samples: 3219180
two traffics test : committed: 99.92496761048093 txn/s, latency: 1982.8583333333333 ms, (p50: 1900 ms, p90: 2100 ms, p99: 5100 ms), latency samples: 1680
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.222, avg: 0.206", "QsPosToProposal: max: 0.484, avg: 0.315", "ConsensusProposalToOrdered: max: 0.479, avg: 0.445", "ConsensusOrderedToCommit: max: 0.428, avg: 0.396", "ConsensusProposalToCommit: max: 0.877, avg: 0.842"]
Max round gap was 2 [limit 4] at version 1636806. Max no progress secs was 4.830214 [limit 15] at version 1621738.
Test Ok

Copy link
Contributor

github-actions bot commented Jun 3, 2024

✅ Forge suite framework_upgrade success on c90dafdb2f450e4d3aa16b1a7cff8e3cad2b882e ==> 0329f5b865b67b72ca7e770550d228e7a0d5e38f

Compatibility test results for c90dafdb2f450e4d3aa16b1a7cff8e3cad2b882e ==> 0329f5b865b67b72ca7e770550d228e7a0d5e38f (PR)
Upgrade the nodes to version: 0329f5b865b67b72ca7e770550d228e7a0d5e38f
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1200.0627556631641 txn/s, submitted: 1202.9237158362105 txn/s, failed submission: 2.8609601730462377 txn/s, expired: 2.8609601730462377 txn/s, latency: 2615.6316064551625 ms, (p50: 1800 ms, p90: 4600 ms, p99: 8100 ms), latency samples: 109060
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1200.9274622478863 txn/s, submitted: 1204.2853580880042 txn/s, failed submission: 3.3578958401179166 txn/s, expired: 3.3578958401179166 txn/s, latency: 2663.286379069303 ms, (p50: 2100 ms, p90: 4700 ms, p99: 10200 ms), latency samples: 100140
5. check swarm health
Compatibility test for c90dafdb2f450e4d3aa16b1a7cff8e3cad2b882e ==> 0329f5b865b67b72ca7e770550d228e7a0d5e38f passed
Upgrade the remaining nodes to version: 0329f5b865b67b72ca7e770550d228e7a0d5e38f
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1227.516093490997 txn/s, submitted: 1230.376923396946 txn/s, failed submission: 2.8608299059488997 txn/s, expired: 2.8608299059488997 txn/s, latency: 2569.267174614557 ms, (p50: 2100 ms, p90: 4500 ms, p99: 8300 ms), latency samples: 111560
Test Ok

@alinush alinush merged commit 6c8e787 into aptos-release-v1.13 Jun 3, 2024
48 of 51 checks passed
@alinush alinush deleted the alin/keyless-gas-v1.13 branch June 3, 2024 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants