13521 [bug] - Post Mint Reveal NFT - Generalizing Testcases

[Alexzander-Stone]

Description

Reference to 13521 issue.

Tests for post_mint_reveal_nft smart contract were using a hardcoded test address (0xcafe). Updated to be a generic, defined by the named address post_mint_reveal_nft.

Type of Change

• New feature
• Bug fix
• Breaking change
• Performance improvement
• Refactoring
• Dependency update
• Documentation update
• Tests

Which Components or Systems Does This Change Impact?

• Validator Node
• Full Node (API, Indexer, etc.)
• Move/Aptos Virtual Machine
• Aptos Framework
• Aptos CLI/SDK
• Developer Infrastructure
• Other (specify) - move_examples

How Has This Been Tested?

Move tests using various admin_account addresses for post_mint_reveal_nft.

Key Areas to Review

Small changes to test cases for generic address usage, rather than hardcoded 0xcafe.

Checklist

• I have read and followed the CONTRIBUTING doc
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I identified and added all stakeholders and component owners affected by this change as reviewers
• I tested both happy and unhappy path of the functionality
• I have made corresponding changes to the documentation

[trunk-io]

⏱️ 3h 36m total CI duration on this PR

Job	Cumulative Duration	Recent Runs
rust-smoke-tests	44m	🟩
rust-move-tests	33m	⬜ 🟩 🟩
forge-e2e-test / forge	22m	🟥
execution-performance / test-target-determinator	22m	🟩
rust-images / rust-all	13m	🟩
rust-targeted-unit-tests	13m	🟩 🟩
rust-lints	12m	🟩 🟥
forge-compat-test / forge	12m	🟩
run-tests-main-branch	11m	🟩 🟩
cli-e2e-tests / run-cli-tests	9m	🟩
test-target-determinator	5m	🟩
check-dynamic-deps	5m	🟩 🟩 🟩
check	4m	🟩
general-lints	4m	🟩 🟩
rust-build-cached-packages	4m	🟥
semgrep/ci	1m	🟩 🟩 🟩
node-api-compatibility-tests / node-api-compatibility-tests	1m	🟩
file_change_determinator	22s	🟩 🟩
file_change_determinator	21s	⬜ 🟩 🟩
file_change_determinator	12s	🟩
permission-check	12s	🟩 🟩 🟩
permission-check	10s	🟩 🟩 🟩
permission-check	9s	⬜ 🟩 🟩
execution-performance / single-node-performance	9s	🟩
permission-check	7s	⬜ 🟩 🟩
forge-framework-upgrade-test / forge	6s	🟩
permission-check	2s	🟩
determine-docker-build-metadata	2s	🟩

🚨 10 jobs on the last run were significantly faster/slower than expected

Job	Duration	vs 7d avg	Delta
execution-performance / test-target-determinator	22m	4m
rust-move-tests	16m	9m
forge-e2e-test / forge	22m	15m
test-target-determinator	5m	4m
cli-e2e-tests / run-cli-tests	9m	6m
run-tests-main-branch	6m	5m
rust-smoke-tests	44m	36m
rust-targeted-unit-tests	8m	17m
forge-framework-upgrade-test / forge	6s	14m
execution-performance / single-node-performance	9s	21m

_{settings ⋅ feedback ⋅ docs ⋅ learn more about trunk.io}

[github-actions]

✅ Forge suite compat success on a68e71c05caebf01504d4499110f3fba213fb53d ==> f4d9c638dfc744ccdce274bff40e5f3c57761391

Compatibility test results for a68e71c05caebf01504d4499110f3fba213fb53d ==> f4d9c638dfc744ccdce274bff40e5f3c57761391 (PR)
1. Check liveness of validators at old version: a68e71c05caebf01504d4499110f3fba213fb53d
compatibility::simple-validator-upgrade::liveness-check : committed: 9489.5079719551 txn/s, latency: 3079.0443898422145 ms, (p50: 2700 ms, p90: 3600 ms, p99: 11400 ms), latency samples: 376460
2. Upgrading first Validator to new version: f4d9c638dfc744ccdce274bff40e5f3c57761391
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 3074.0687078955975 txn/s, latency: 10058.790492572321 ms, (p50: 10400 ms, p90: 14000 ms, p99: 14300 ms), latency samples: 127900
3. Upgrading rest of first batch to new version: f4d9c638dfc744ccdce274bff40e5f3c57761391
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 3402.192693899978 txn/s, latency: 9147.191965836711 ms, (p50: 9600 ms, p90: 13900 ms, p99: 14200 ms), latency samples: 138160
4. upgrading second batch to new version: f4d9c638dfc744ccdce274bff40e5f3c57761391
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 6395.13899373177 txn/s, latency: 5102.501155898044 ms, (p50: 4800 ms, p90: 8400 ms, p99: 9300 ms), latency samples: 236180
5. check swarm health
Compatibility test for a68e71c05caebf01504d4499110f3fba213fb53d ==> f4d9c638dfc744ccdce274bff40e5f3c57761391 passed
Test Ok

• Grafana dashboard
• Humio Logs
• Axiom Logs
• Validator CPU Profile
• Fullnode CPU Profile
• Test runner output
• Test run is land-blocking

[github-actions]

✅ Forge suite realistic_env_max_load success on f4d9c638dfc744ccdce274bff40e5f3c57761391

two traffics test: inner traffic : committed: 8819.497816556985 txn/s, latency: 4450.079961135537 ms, (p50: 4500 ms, p90: 5100 ms, p99: 9600 ms), latency samples: 3802960
two traffics test : committed: 100.08344766205356 txn/s, latency: 1973.4252873563219 ms, (p50: 1900 ms, p90: 2200 ms, p99: 2500 ms), latency samples: 1740
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.210, avg: 0.205", "QsPosToProposal: max: 0.246, avg: 0.236", "ConsensusProposalToOrdered: max: 0.311, avg: 0.283", "ConsensusOrderedToCommit: max: 0.360, avg: 0.345", "ConsensusProposalToCommit: max: 0.640, avg: 0.629"]
Max round gap was 1 [limit 4] at version 1844104. Max no progress secs was 5.123456 [limit 15] at version 1844104.
Test Ok

• Grafana dashboard
• Humio Logs
• Axiom Logs
• Validator CPU Profile
• Fullnode CPU Profile
• Test runner output
• Test run is land-blocking