Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry-pick commit to stop warn logs from DB API #13722

Merged
merged 3 commits into from
Jun 17, 2024
Merged

Cherry-pick commit to stop warn logs from DB API #13722

merged 3 commits into from
Jun 17, 2024

Conversation

areshand
Copy link
Contributor

Description

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Other (specify)

How Has This Been Tested?

Key Areas to Review

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

@trunk-io Trunk.io
Copy link

trunk-io bot commented Jun 16, 2024 •
edited
Loading

⏱️ 10h 54m total CI duration on this PR
Job Cumulative Duration Recent Runs
windows-build 2h 🟩 🟩 🟩 
rust-smoke-tests 1h 55m 🟩 🟩 🟩 
execution-performance / single-node-performance 1h 47m 🟥 🟥 🟥 🟩 
rust-targeted-unit-tests 1h 17m 🟩 🟩 🟩 
rust-move-tests 43m 🟩 🟩 🟩 
rust-lints 26m 🟩 🟩 🟩 
rust-build-cached-packages 19m 🟩 🟩 🟩 
execution-performance / test-target-determinator 19m 🟩 🟩 🟩 
test-target-determinator 18m 🟩 🟩 🟩 
rust-images / rust-all 18m ⬜ ⬜ ⬜ 🟩 
forge-framework-upgrade-test / forge 17m 🟩 
forge-e2e-test / forge 15m 🟩 
run-tests-main-branch 14m ⬜ 🟩 🟩 🟩 
forge-compat-test / forge 12m 🟩 
check 11m 🟩 🟩 🟩 
general-lints 6m 🟩 🟩 🟩 
cli-e2e-tests / run-cli-tests 6m 🟩 
check-dynamic-deps 4m 🟩 🟩 🟩 
node-api-compatibility-tests / node-api-compatibility-tests 1m 🟩 
semgrep/ci 1m 🟩 🟩 🟩 
file_change_determinator 46s 🟩 🟩 🟩 🟩 
file_change_determinator 35s 🟩 🟩 🟩 
file_change_determinator 31s 🟩 🟩 🟩 
permission-check 18s 🟩 🟩 🟩 🟩 
permission-check 12s 🟩 🟩 🟩 🟩 
permission-check 12s 🟩 🟩 🟩 🟩 
permission-check 10s 🟩 🟩 🟩 🟩 
permission-check 6s 🟩 🟩 🟩 
determine-docker-build-metadata 4s 🟩 🟩 🟩 
🚨 9 jobs on the last run were significantly faster/slower than expected
Job Duration vs 7d avg Delta
test-target-determinator 11m 4m +189%
execution-performance / test-target-determinator 12m 4m +173%
execution-performance / single-node-performance 27m 14m +94%
rust-targeted-unit-tests 28m 15m +83%
rust-move-tests 16m 9m +73%
rust-build-cached-packages 8m 5m +67%
rust-lints 10m 7m +55%
forge-framework-upgrade-test / forge 17m 12m +39%
rust-images / rust-all 18m 14m +27%

settings ⋅ feedback ⋅ docs ⋅ learn more about trunk.io

@areshand areshand changed the base branch from main to aptos-release-v1.14 June 16, 2024 17:45
@areshand areshand enabled auto-merge (rebase) June 16, 2024 17:46
gregnazario
gregnazario approved these changes Jun 16, 2024
View reviewed changes
api/types/src/convert.rs
.get_transaction_auxiliary_data_by_version(data.version)
.ok();
.get_transaction_auxiliary_data_by_version(data.version)?;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a case where a transaction will never parse because of this? Or I guess it looks like it wouldn't work before

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no as I know of

@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions
Copy link
Contributor

✅ Forge suite compat success on 3ffe0986b5fe4acb76544ae7ae85d73b91a6a411 ==> 4ac946e78299faa80236e7ddf592fe8ad10d87b1

Compatibility test results for 3ffe0986b5fe4acb76544ae7ae85d73b91a6a411 ==> 4ac946e78299faa80236e7ddf592fe8ad10d87b1 (PR)
1. Check liveness of validators at old version: 3ffe0986b5fe4acb76544ae7ae85d73b91a6a411
compatibility::simple-validator-upgrade::liveness-check : committed: 6855.871961323655 txn/s, latency: 4794.868269701419 ms, (p50: 4800 ms, p90: 8000 ms, p99: 8400 ms), latency samples: 245160
2. Upgrading first Validator to new version: 4ac946e78299faa80236e7ddf592fe8ad10d87b1
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 1977.297253056935 txn/s, latency: 15500.363503293485 ms, (p50: 15100 ms, p90: 26400 ms, p99: 27100 ms), latency samples: 81980
3. Upgrading rest of first batch to new version: 4ac946e78299faa80236e7ddf592fe8ad10d87b1
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 2931.7830413689553 txn/s, latency: 10546.871317384892 ms, (p50: 11000 ms, p90: 13900 ms, p99: 14300 ms), latency samples: 122060
4. upgrading second batch to new version: 4ac946e78299faa80236e7ddf592fe8ad10d87b1
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 6356.1155815228585 txn/s, latency: 5130.745815845825 ms, (p50: 4800 ms, p90: 8300 ms, p99: 9400 ms), latency samples: 233500
5. check swarm health
Compatibility test for 3ffe0986b5fe4acb76544ae7ae85d73b91a6a411 ==> 4ac946e78299faa80236e7ddf592fe8ad10d87b1 passed
Test Ok

@github-actions GitHub Actions
Copy link
Contributor

✅ Forge suite realistic_env_max_load success on 4ac946e78299faa80236e7ddf592fe8ad10d87b1

two traffics test: inner traffic : committed: 7952.762792421878 txn/s, latency: 4926.175564920777 ms, (p50: 4800 ms, p90: 6200 ms, p99: 10500 ms), latency samples: 3435880
two traffics test : committed: 99.87874588159544 txn/s, latency: 1802.6623595505619 ms, (p50: 1700 ms, p90: 2000 ms, p99: 3700 ms), latency samples: 1780
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.212, avg: 0.203", "QsPosToProposal: max: 0.395, avg: 0.299", "ConsensusProposalToOrdered: max: 0.363, avg: 0.341", "ConsensusOrderedToCommit: max: 0.368, avg: 0.351", "ConsensusProposalToCommit: max: 0.720, avg: 0.692"]
Max round gap was 1 [limit 4] at version 1535578. Max no progress secs was 4.916276 [limit 15] at version 1535578.
Test Ok

@github-actions GitHub Actions
Copy link
Contributor

✅ Forge suite framework_upgrade success on 3ffe0986b5fe4acb76544ae7ae85d73b91a6a411 ==> 4ac946e78299faa80236e7ddf592fe8ad10d87b1

Compatibility test results for 3ffe0986b5fe4acb76544ae7ae85d73b91a6a411 ==> 4ac946e78299faa80236e7ddf592fe8ad10d87b1 (PR)
Upgrade the nodes to version: 4ac946e78299faa80236e7ddf592fe8ad10d87b1
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1240.7835485877997 txn/s, submitted: 1242.3848547898858 txn/s, failed submission: 1.6013062020860247 txn/s, expired: 1.6013062020860247 txn/s, latency: 2524.890495943953 ms, (p50: 1800 ms, p90: 4500 ms, p99: 8100 ms), latency samples: 108480
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1206.4464273731712 txn/s, submitted: 1207.7612120586257 txn/s, failed submission: 1.314784685454633 txn/s, expired: 1.314784685454633 txn/s, latency: 2988.247362685266 ms, (p50: 2300 ms, p90: 5400 ms, p99: 9600 ms), latency samples: 91760
5. check swarm health
Compatibility test for 3ffe0986b5fe4acb76544ae7ae85d73b91a6a411 ==> 4ac946e78299faa80236e7ddf592fe8ad10d87b1 passed
Upgrade the remaining nodes to version: 4ac946e78299faa80236e7ddf592fe8ad10d87b1
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1220.8166959447522 txn/s, submitted: 1222.8996059473118 txn/s, failed submission: 2.0829100025597667 txn/s, expired: 2.0829100025597667 txn/s, latency: 2792.0571279620854 ms, (p50: 2100 ms, p90: 5100 ms, p99: 9300 ms), latency samples: 105500
Test Ok

@areshand areshand merged commit 52532b6 into aptos-release-v1.14 Jun 17, 2024
51 checks passed
@areshand areshand deleted the c114 branch June 17, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gregnazario gregnazario gregnazario approved these changes

@ibalajiarun ibalajiarun ibalajiarun approved these changes

@grao1991 grao1991 grao1991 approved these changes

@msmouse msmouse Awaiting requested review from msmouse msmouse is a code owner

@lightmark lightmark Awaiting requested review from lightmark lightmark is a code owner

@alinush alinush Awaiting requested review from alinush

@davidiw davidiw Awaiting requested review from davidiw

@movekevin movekevin Awaiting requested review from movekevin

@wrwg wrwg Awaiting requested review from wrwg

@banool banool Awaiting requested review from banool banool is a code owner

@0xmaayan 0xmaayan Awaiting requested review from 0xmaayan 0xmaayan is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@areshand @gregnazario @ibalajiarun @grao1991