Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FA migration proposal to release v1.14 #13849

Merged
merged 1 commit into from
Jun 28, 2024

Conversation

lightmark
Copy link
Contributor

Description

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Other (specify)

How Has This Been Tested?

Key Areas to Review

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

Copy link

trunk-io bot commented Jun 27, 2024

⏱️ 5h 47m total CI duration on this PR
Job Cumulative Duration Recent Runs
rust-targeted-unit-tests 55m 🟩🟩
windows-build 44m 🟩
rust-smoke-tests 40m 🟩
rust-move-tests 36m 🟩🟩
execution-performance / single-node-performance 27m 🟩
rust-lints 22m 🟩🟩
forge-framework-upgrade-test / forge 18m 🟩
forge-e2e-test / forge 15m 🟩
rust-images / rust-all 15m 🟩
forge-compat-test / forge 13m 🟩
run-tests-main-branch 13m 🟩🟩🟩
test-target-determinator 11m 🟩
execution-performance / test-target-determinator 11m 🟩
rust-build-cached-packages 8m 🟩
check-dynamic-deps 6m 🟩🟩🟩🟩
general-lints 5m 🟩🟩🟩
check 4m 🟩
semgrep/ci 1m 🟩🟩🟩🟩
node-api-compatibility-tests / node-api-compatibility-tests 1m 🟩
file_change_determinator 40s 🟩🟩🟩
file_change_determinator 28s 🟩🟩🟩
permission-check 11s 🟩🟩🟩🟩
permission-check 11s 🟩🟩🟩🟩
file_change_determinator 10s 🟩
permission-check 10s 🟩🟩🟩🟩
permission-check 8s 🟩🟩🟩
permission-check 3s 🟩
determine-docker-build-metadata 2s 🟩

🚨 5 jobs on the last run were significantly faster/slower than expected

Job Duration vs 7d avg Delta
test-target-determinator 11m 5m +122%
execution-performance / test-target-determinator 11m 5m +111%
rust-build-cached-packages 8m 5m +66%
execution-performance / single-node-performance 27m 18m +52%
forge-framework-upgrade-test / forge 18m 12m +48%

settingsfeedbackdocs ⋅ learn more about trunk.io

@lightmark lightmark requested review from sherry-x, davidiw, movekevin and a team June 27, 2024 20:41
@lightmark lightmark changed the title [testnet] migration proposal FA migration proposal to release v1.15 Jun 27, 2024
@lightmark lightmark changed the base branch from aptos-release-v1.15 to aptos-release-v1.14 June 27, 2024 20:48
@lightmark lightmark changed the title FA migration proposal to release v1.15 FA migration proposal to release v1.14 Jun 27, 2024
proposals:
- name: enable_coin_to_fa_migration
metadata:
title: "Enable the mapping from coin to fungible asset including APT"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Enable the mapping for coin to fungible asset migration, including APT" ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's wrong?

@lightmark lightmark enabled auto-merge (squash) June 28, 2024 04:37

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

✅ Forge suite compat success on 3ffe0986b5fe4acb76544ae7ae85d73b91a6a411 ==> 9efb19fd4d7f17675adedb3f285574ccb0278ca5

Compatibility test results for 3ffe0986b5fe4acb76544ae7ae85d73b91a6a411 ==> 9efb19fd4d7f17675adedb3f285574ccb0278ca5 (PR)
1. Check liveness of validators at old version: 3ffe0986b5fe4acb76544ae7ae85d73b91a6a411
compatibility::simple-validator-upgrade::liveness-check : committed: 6589.751298632606 txn/s, latency: 4684.377225005966 ms, (p50: 4800 ms, p90: 5400 ms, p99: 7600 ms), latency samples: 251460
2. Upgrading first Validator to new version: 9efb19fd4d7f17675adedb3f285574ccb0278ca5
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 3329.9642430464623 txn/s, latency: 9387.561207639288 ms, (p50: 9500 ms, p90: 14200 ms, p99: 14500 ms), latency samples: 139280
3. Upgrading rest of first batch to new version: 9efb19fd4d7f17675adedb3f285574ccb0278ca5
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 3354.9820247714174 txn/s, latency: 9288.586465196218 ms, (p50: 9400 ms, p90: 13900 ms, p99: 14200 ms), latency samples: 139640
4. upgrading second batch to new version: 9efb19fd4d7f17675adedb3f285574ccb0278ca5
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 5400.018572903419 txn/s, latency: 6054.675833161901 ms, (p50: 6100 ms, p90: 8700 ms, p99: 9900 ms), latency samples: 194440
5. check swarm health
Compatibility test for 3ffe0986b5fe4acb76544ae7ae85d73b91a6a411 ==> 9efb19fd4d7f17675adedb3f285574ccb0278ca5 passed
Test Ok

Copy link
Contributor

✅ Forge suite realistic_env_max_load success on 9efb19fd4d7f17675adedb3f285574ccb0278ca5

two traffics test: inner traffic : committed: 8335.493573643962 txn/s, latency: 4699.6819187322635 ms, (p50: 4500 ms, p90: 6300 ms, p99: 9600 ms), latency samples: 3608320
two traffics test : committed: 100.0046273932189 txn/s, latency: 1961.2758823529412 ms, (p50: 1800 ms, p90: 2100 ms, p99: 7100 ms), latency samples: 1700
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.220, avg: 0.210", "QsPosToProposal: max: 0.275, avg: 0.249", "ConsensusProposalToOrdered: max: 0.347, avg: 0.334", "ConsensusOrderedToCommit: max: 0.383, avg: 0.369", "ConsensusProposalToCommit: max: 0.724, avg: 0.703"]
Max round gap was 1 [limit 4] at version 1731603. Max no progress secs was 4.806526 [limit 15] at version 1731603.
Test Ok

Copy link
Contributor

✅ Forge suite framework_upgrade success on 3ffe0986b5fe4acb76544ae7ae85d73b91a6a411 ==> 9efb19fd4d7f17675adedb3f285574ccb0278ca5

Compatibility test results for 3ffe0986b5fe4acb76544ae7ae85d73b91a6a411 ==> 9efb19fd4d7f17675adedb3f285574ccb0278ca5 (PR)
Upgrade the nodes to version: 9efb19fd4d7f17675adedb3f285574ccb0278ca5
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1272.7627089228681 txn/s, submitted: 1274.6116469420044 txn/s, failed submission: 1.8489380191361804 txn/s, expired: 1.8489380191361804 txn/s, latency: 2573.570038133285 ms, (p50: 2100 ms, p90: 4800 ms, p99: 7200 ms), latency samples: 110140
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1071.8752954736149 txn/s, submitted: 1074.2425112321696 txn/s, failed submission: 2.367215758554803 txn/s, expired: 2.367215758554803 txn/s, latency: 2945.5804770318023 ms, (p50: 2100 ms, p90: 5700 ms, p99: 9900 ms), latency samples: 90560
5. check swarm health
Compatibility test for 3ffe0986b5fe4acb76544ae7ae85d73b91a6a411 ==> 9efb19fd4d7f17675adedb3f285574ccb0278ca5 passed
Upgrade the remaining nodes to version: 9efb19fd4d7f17675adedb3f285574ccb0278ca5
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 986.4017648776378 txn/s, submitted: 988.1112999987429 txn/s, failed submission: 1.7095351211050915 txn/s, expired: 1.7095351211050915 txn/s, latency: 3405.536011388958 ms, (p50: 2400 ms, p90: 6300 ms, p99: 9000 ms), latency samples: 80780
Test Ok

@lightmark lightmark merged commit 198fe34 into aptos-release-v1.14 Jun 28, 2024
83 of 98 checks passed
@lightmark lightmark deleted the fa_migration_proposal branch June 28, 2024 05:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants