-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add end of range for mainnet #13911
add end of range for mainnet #13911
Conversation
@@ -60,7 +60,7 @@ | |||
# Skip tapos range | |||
(949_000_000, 954_000_000), | |||
(954_000_000, 969_000_000), | |||
(969_000_000, sys.maxsize), | |||
(969_000_000, 984_000_000), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can remove (392_000_000, 408_000_000),
and add a new range like (984_000_001, sys.maxsize)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed the oldest range and replaced it with a more recent range.
I still think we should specify an end version instead of using sys.maxsize
. This started timing out recently and will likely happen again if we continue using sys.maxsize
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, on the other hand we do wanna make sure we're adding more transactions eventually
But there is a broader conversation here over whether or not this is the right, scalable way to ensure compatibility
72b0c72
to
836d1f9
Compare
836d1f9
to
f4c017b
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
✅ Forge suite
|
✅ Forge suite
|
✅ Forge suite
|
Description
Set the end of the range for mainnet to prevent it from replaying recent transactions. This was causing a timeout in the most recent run
Type of Change
Which Components or Systems Does This Change Impact?
How Has This Been Tested?
Manually run the workflow https://github.com/aptos-labs/aptos-core/actions/runs/9782591665
Key Areas to Review
Checklist