Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add end of range for mainnet #13911

Merged
merged 2 commits into from
Jul 8, 2024
Merged

add end of range for mainnet #13911

merged 2 commits into from
Jul 8, 2024

Conversation

aluon
Copy link
Contributor

@aluon aluon commented Jul 3, 2024

Description

Set the end of the range for mainnet to prevent it from replaying recent transactions. This was causing a timeout in the most recent run

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Other (specify)

How Has This Been Tested?

Manually run the workflow https://github.com/aptos-labs/aptos-core/actions/runs/9782591665

Key Areas to Review

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

@aluon aluon requested review from areshand, msmouse, perryjrandall and a team July 3, 2024 15:50
Copy link

trunk-io bot commented Jul 3, 2024

⏱️ 149h 19m total CI duration on this PR
Job Cumulative Duration Recent Runs
replay-testnet / replay-verify (17) 6h 49m 🟥🟩
replay-testnet / replay-verify (18) 6h 29m 🟥🟩
replay-testnet / replay-verify (16) 6h 23m 🟥🟩
replay-testnet / replay-verify (15) 6h 2m 🟥🟩
replay-testnet / replay-verify (14) 5h 25m 🟥🟩
replay-mainnet / replay-verify (1) 4h 54m 🟥🟩
replay-testnet / replay-verify (11) 4h 49m 🟥🟩
replay-mainnet / replay-verify (17) 4h 23m 🟥🟩
replay-mainnet / replay-verify (0) 4h 22m 🟥🟩
replay-testnet / replay-verify (5) 4h 6m 🟥🟩
replay-testnet / replay-verify (10) 3h 52m 🟥🟩
test-fuzzers 3h 49m 🟩🟩🟩🟩🟩 (+2 more)
replay-mainnet / replay-verify (18) 3h 45m 🟥🟩
replay-mainnet / replay-verify (12) 3h 40m 🟥🟩
replay-mainnet / replay-verify (15) 3h 39m 🟥🟩
replay-mainnet / replay-verify (14) 3h 32m 🟥🟩
replay-mainnet / replay-verify (16) 3h 31m 🟥🟩
replay-testnet / replay-verify (13) 3h 26m 🟥🟩
replay-mainnet / replay-verify (11) 3h 17m 🟥🟩
replay-testnet / replay-verify (12) 3h 11m 🟥🟩
replay-mainnet / replay-verify (9) 3h 9m 🟥🟩
replay-mainnet / replay-verify (10) 3h 8m 🟥🟩
replay-testnet / replay-verify (6) 3h 6m 🟥🟩
replay-mainnet / replay-verify (7) 3h 4m 🟥🟩
replay-testnet / replay-verify (2) 3h 1m 🟥🟩
replay-testnet / replay-verify (4) 3h 1m 🟥🟩
replay-testnet / replay-verify (1) 3h 🟥🟩
replay-testnet / replay-verify (9) 2h 59m 🟥🟩
replay-mainnet / replay-verify (8) 2h 59m 🟥🟩
replay-mainnet / replay-verify (6) 2h 56m 🟥🟩
replay-testnet / replay-verify (7) 2h 56m 🟥🟩
replay-mainnet / replay-verify (3) 2h 51m 🟥🟩
replay-testnet / replay-verify (8) 2h 50m 🟥🟩
replay-mainnet / replay-verify (2) 2h 50m 🟥🟩
replay-mainnet / replay-verify (4) 2h 49m 🟥🟩
replay-mainnet / replay-verify (5) 2h 46m 🟥🟩
replay-testnet / replay-verify (3) 2h 46m 🟥🟩
replay-testnet / replay-verify (0) 2h 46m 🟥🟩
replay-mainnet / replay-verify (13) 2h 22m 🟥🟥🟩
execution-performance / single-node-performance 1h 1m 🟩🟩
forge-framework-upgrade-test / forge 31m 🟩🟩
forge-e2e-test / forge 27m 🟩🟩
forge-compat-test / forge 27m 🟩🟩
rust-images / rust-all 27m 🟩🟩
rust-move-tests 15m 🟩
rust-move-tests 13m 🟩
general-lints 12m 🟩🟩🟥🟩 (+2 more)
rust-move-tests 9m 🟩
rust-move-tests 9m 🟩
rust-move-tests 9m 🟩
check 7m 🟥🟩
execution-performance / test-target-determinator 7m 🟩🟩
test-target-determinator 7m 🟩🟩
check-dynamic-deps 5m 🟩🟩🟩🟩🟩 (+2 more)
semgrep/ci 3m 🟩🟩🟩🟩🟩 (+2 more)
file_change_determinator 1m 🟩🟩🟩🟩🟩 (+2 more)
file_change_determinator 1m 🟩🟩🟩🟩🟩 (+2 more)
determine-test-metadata 1m 🟩🟩🟩🟩🟩 (+4 more)
rust-move-tests 32s
permission-check 31s 🟩🟩🟩🟩🟩 (+2 more)
permission-check 26s 🟩🟩🟩🟩🟩 (+2 more)
file_change_determinator 23s 🟩🟩
permission-check 23s 🟩🟩🟩🟩🟩 (+2 more)
permission-check 18s 🟩🟩🟩🟩🟩 (+2 more)
permission-check 6s 🟩🟩
determine-docker-build-metadata 6s 🟩🟩
rust-move-tests 1s

🚨 4 jobs on the last run were significantly faster/slower than expected

Job Duration vs 7d avg Delta
check 6m 4m +52%
execution-performance / single-node-performance 30m 20m +50%
test-target-determinator 3m 5m -29%
execution-performance / test-target-determinator 3m 5m -30%

settingsfeedbackdocs ⋅ learn more about trunk.io

areshand
areshand previously approved these changes Jul 3, 2024
@@ -60,7 +60,7 @@
# Skip tapos range
(949_000_000, 954_000_000),
(954_000_000, 969_000_000),
(969_000_000, sys.maxsize),
(969_000_000, 984_000_000),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can remove (392_000_000, 408_000_000),
and add a new range like (984_000_001, sys.maxsize)?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed the oldest range and replaced it with a more recent range.

I still think we should specify an end version instead of using sys.maxsize. This started timing out recently and will likely happen again if we continue using sys.maxsize

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, on the other hand we do wanna make sure we're adding more transactions eventually

But there is a broader conversation here over whether or not this is the right, scalable way to ensure compatibility

@areshand areshand dismissed their stale review July 3, 2024 15:57

accidental approve

@aluon aluon force-pushed the aluon/fix-mainnet-range branch 3 times, most recently from 72b0c72 to 836d1f9 Compare July 3, 2024 18:58
@aluon aluon enabled auto-merge (squash) July 5, 2024 00:08

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

github-actions bot commented Jul 8, 2024

✅ Forge suite realistic_env_max_load success on 6653ba327df833a056172071e2ac491905ac2671

two traffics test: inner traffic : committed: 8344.407623203677 txn/s, latency: 4663.123358624791 ms, (p50: 4200 ms, p90: 6000 ms, p99: 23200 ms), latency samples: 3632320
two traffics test : committed: 99.94166656008414 txn/s, latency: 2059.825287356322 ms, (p50: 1900 ms, p90: 2200 ms, p99: 7000 ms), latency samples: 1740
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.217, avg: 0.211", "QsPosToProposal: max: 0.218, avg: 0.190", "ConsensusProposalToOrdered: max: 0.302, avg: 0.287", "ConsensusOrderedToCommit: max: 0.362, avg: 0.349", "ConsensusProposalToCommit: max: 0.649, avg: 0.636"]
Max round gap was 1 [limit 4] at version 1667580. Max no progress secs was 5.015271 [limit 15] at version 1667580.
Test Ok

Copy link
Contributor

github-actions bot commented Jul 8, 2024

✅ Forge suite compat success on 1c2ee7082d6eff8c811ee25d6f5a7d00860a75d5 ==> 6653ba327df833a056172071e2ac491905ac2671

Compatibility test results for 1c2ee7082d6eff8c811ee25d6f5a7d00860a75d5 ==> 6653ba327df833a056172071e2ac491905ac2671 (PR)
1. Check liveness of validators at old version: 1c2ee7082d6eff8c811ee25d6f5a7d00860a75d5
compatibility::simple-validator-upgrade::liveness-check : committed: 6652.985932481594 txn/s, latency: 4178.387463803941 ms, (p50: 3200 ms, p90: 6900 ms, p99: 20200 ms), latency samples: 283180
2. Upgrading first Validator to new version: 6653ba327df833a056172071e2ac491905ac2671
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 2781.5288906197006 txn/s, latency: 9114.259272997033 ms, (p50: 9100 ms, p90: 13200 ms, p99: 13700 ms), latency samples: 67400
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 3215.1889075888116 txn/s, latency: 9614.300697573028 ms, (p50: 9400 ms, p90: 14800 ms, p99: 15100 ms), latency samples: 137620
3. Upgrading rest of first batch to new version: 6653ba327df833a056172071e2ac491905ac2671
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 3493.762304903537 txn/s, latency: 7472.084096162737 ms, (p50: 9000 ms, p90: 9900 ms, p99: 10300 ms), latency samples: 86520
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 3214.794390561913 txn/s, latency: 9629.301085697742 ms, (p50: 9500 ms, p90: 14800 ms, p99: 15200 ms), latency samples: 138160
4. upgrading second batch to new version: 6653ba327df833a056172071e2ac491905ac2671
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 3030.3122734888475 txn/s, latency: 8156.458591025343 ms, (p50: 8300 ms, p90: 13700 ms, p99: 17300 ms), latency samples: 86020
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 6270.167722252572 txn/s, latency: 5206.530029585799 ms, (p50: 4800 ms, p90: 9000 ms, p99: 10000 ms), latency samples: 229840
5. check swarm health
Compatibility test for 1c2ee7082d6eff8c811ee25d6f5a7d00860a75d5 ==> 6653ba327df833a056172071e2ac491905ac2671 passed
Test Ok

Copy link
Contributor

github-actions bot commented Jul 8, 2024

✅ Forge suite framework_upgrade success on 1c2ee7082d6eff8c811ee25d6f5a7d00860a75d5 ==> 6653ba327df833a056172071e2ac491905ac2671

Compatibility test results for 1c2ee7082d6eff8c811ee25d6f5a7d00860a75d5 ==> 6653ba327df833a056172071e2ac491905ac2671 (PR)
Upgrade the nodes to version: 6653ba327df833a056172071e2ac491905ac2671
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1271.5543602999758 txn/s, submitted: 1272.883881797571 txn/s, failed submission: 1.329521497595123 txn/s, expired: 1.329521497595123 txn/s, latency: 2770.902007528231 ms, (p50: 2100 ms, p90: 5000 ms, p99: 9300 ms), latency samples: 95640
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1201.4675989665777 txn/s, submitted: 1202.9212802720424 txn/s, failed submission: 1.4536813054647038 txn/s, expired: 1.4536813054647038 txn/s, latency: 2749.136862270619 ms, (p50: 2100 ms, p90: 4800 ms, p99: 9500 ms), latency samples: 99180
5. check swarm health
Compatibility test for 1c2ee7082d6eff8c811ee25d6f5a7d00860a75d5 ==> 6653ba327df833a056172071e2ac491905ac2671 passed
Upgrade the remaining nodes to version: 6653ba327df833a056172071e2ac491905ac2671
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1144.5270393734104 txn/s, submitted: 1146.7840439866493 txn/s, failed submission: 2.2570046132388293 txn/s, expired: 2.2570046132388293 txn/s, latency: 2798.9763261684084 ms, (p50: 2100 ms, p90: 5100 ms, p99: 8400 ms), latency samples: 101420
Test Ok

@aluon aluon merged commit 68bd244 into main Jul 8, 2024
56 checks passed
@aluon aluon deleted the aluon/fix-mainnet-range branch July 8, 2024 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants