Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] make the max supply unlimited #13915

Merged
merged 1 commit into from
Jul 12, 2024

Conversation

lightmark
Copy link
Contributor

cherry-pick #13913

Copy link

trunk-io bot commented Jul 3, 2024

⏱️ 1h 52m total CI duration on this PR
Job Cumulative Duration Recent Runs
test-fuzzers 35m 🟩
rust-targeted-unit-tests 28m 🟩
rust-move-tests 16m 🟩
rust-move-unit-coverage 14m 🟩
rust-lints 10m 🟩
run-tests-main-branch 4m 🟩
general-lints 2m 🟩
check-dynamic-deps 1m 🟩
semgrep/ci 20s 🟩
file_change_determinator 13s 🟩
file_change_determinator 10s 🟩
permission-check 3s 🟩
permission-check 2s 🟩
permission-check 2s 🟩
permission-check 2s 🟩

🚨 3 jobs on the last run were significantly faster/slower than expected

Job Duration vs 7d avg Delta
rust-move-tests 16m 9m +86%
rust-targeted-unit-tests 28m 16m +76%
rust-lints 10m 7m +51%

settingsfeedbackdocs ⋅ learn more about trunk.io

Copy link

codecov bot commented Jul 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (aptos-release-v1.16@b64130e). Learn more about missing BASE report.

Additional details and impacted files
@@                  Coverage Diff                   @@
##             aptos-release-v1.16   #13915   +/-   ##
======================================================
  Coverage                       ?    58.9%           
======================================================
  Files                          ?      820           
  Lines                          ?   197515           
  Branches                       ?        0           
======================================================
  Hits                           ?   116494           
  Misses                         ?    81021           
  Partials                       ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lightmark lightmark force-pushed the lightmark/v1.16/fix_supply_and_nits branch from 8102996 to 25a1333 Compare July 11, 2024 20:24
@lightmark lightmark enabled auto-merge (squash) July 12, 2024 14:15

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

✅ Forge suite compat success on f648076a280621dbfd4e73b1ca83e3a3f52878ed ==> 25a133328404505580ba4e974deb82b94c6bbecb

Compatibility test results for f648076a280621dbfd4e73b1ca83e3a3f52878ed ==> 25a133328404505580ba4e974deb82b94c6bbecb (PR)
1. Check liveness of validators at old version: f648076a280621dbfd4e73b1ca83e3a3f52878ed
compatibility::simple-validator-upgrade::liveness-check : committed: 7508.761698018085 txn/s, latency: 3839.5937520541643 ms, (p50: 3100 ms, p90: 3900 ms, p99: 20900 ms), latency samples: 304260
2. Upgrading first Validator to new version: 25a133328404505580ba4e974deb82b94c6bbecb
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 3487.3592104077056 txn/s, latency: 7237.7628349282295 ms, (p50: 8500 ms, p90: 9500 ms, p99: 9800 ms), latency samples: 83600
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 3181.6043520451776 txn/s, latency: 9689.151478083588 ms, (p50: 9300 ms, p90: 15000 ms, p99: 15400 ms), latency samples: 137340
3. Upgrading rest of first batch to new version: 25a133328404505580ba4e974deb82b94c6bbecb
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 3421.89227552809 txn/s, latency: 7655.455052681992 ms, (p50: 8100 ms, p90: 9700 ms, p99: 9900 ms), latency samples: 83520
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 3226.6775890035087 txn/s, latency: 9663.647732260424 ms, (p50: 9400 ms, p90: 15100 ms, p99: 15400 ms), latency samples: 136700
4. upgrading second batch to new version: 25a133328404505580ba4e974deb82b94c6bbecb
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 410.15005406817426 txn/s, submitted: 642.1561596942047 txn/s, failed submission: 204.38345358732317 txn/s, expired: 232.0061056260304 txn/s, latency: 35670.37121435354 ms, (p50: 52400 ms, p90: 54700 ms, p99: 55300 ms), latency samples: 30543
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 6606.374651806725 txn/s, latency: 4901.275477239354 ms, (p50: 5100 ms, p90: 6900 ms, p99: 8200 ms), latency samples: 231540
5. check swarm health
Compatibility test for f648076a280621dbfd4e73b1ca83e3a3f52878ed ==> 25a133328404505580ba4e974deb82b94c6bbecb passed
Test Ok

Copy link
Contributor

✅ Forge suite realistic_env_max_load success on 25a133328404505580ba4e974deb82b94c6bbecb

two traffics test: inner traffic : committed: 8484.56142382066 txn/s, latency: 4620.015605055551 ms, (p50: 4500 ms, p90: 5500 ms, p99: 10800 ms), latency samples: 3663300
two traffics test : committed: 99.954373765691 txn/s, latency: 2112.881460674157 ms, (p50: 2000 ms, p90: 2300 ms, p99: 5100 ms), latency samples: 1780
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.219, avg: 0.215", "QsPosToProposal: max: 0.230, avg: 0.223", "ConsensusProposalToOrdered: max: 0.304, avg: 0.290", "ConsensusOrderedToCommit: max: 0.409, avg: 0.395", "ConsensusProposalToCommit: max: 0.700, avg: 0.685"]
Max round gap was 1 [limit 4] at version 1775150. Max no progress secs was 5.3644238 [limit 15] at version 1775150.
Test Ok

Copy link
Contributor

✅ Forge suite framework_upgrade success on f648076a280621dbfd4e73b1ca83e3a3f52878ed ==> 25a133328404505580ba4e974deb82b94c6bbecb

Compatibility test results for f648076a280621dbfd4e73b1ca83e3a3f52878ed ==> 25a133328404505580ba4e974deb82b94c6bbecb (PR)
Upgrade the nodes to version: 25a133328404505580ba4e974deb82b94c6bbecb
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1244.2094207713242 txn/s, submitted: 1245.4955582747057 txn/s, failed submission: 1.2861375033815632 txn/s, expired: 1.2861375033815632 txn/s, latency: 3008.24578250982 ms, (p50: 2400 ms, p90: 5700 ms, p99: 8700 ms), latency samples: 96740
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1083.0292962343096 txn/s, submitted: 1085.3908952230454 txn/s, failed submission: 2.361598988735956 txn/s, expired: 2.361598988735956 txn/s, latency: 2927.9204862625384 ms, (p50: 2100 ms, p90: 5400 ms, p99: 10300 ms), latency samples: 91720
5. check swarm health
Compatibility test for f648076a280621dbfd4e73b1ca83e3a3f52878ed ==> 25a133328404505580ba4e974deb82b94c6bbecb passed
Upgrade the remaining nodes to version: 25a133328404505580ba4e974deb82b94c6bbecb
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1123.445010834065 txn/s, submitted: 1124.4263997930814 txn/s, failed submission: 0.9813889590164359 txn/s, expired: 0.9813889590164359 txn/s, latency: 3063.7897466695786 ms, (p50: 2400 ms, p90: 6000 ms, p99: 9900 ms), latency samples: 91580
Test Ok

@lightmark lightmark merged commit 98f3c8a into aptos-release-v1.16 Jul 12, 2024
101 of 103 checks passed
@lightmark lightmark deleted the lightmark/v1.16/fix_supply_and_nits branch July 12, 2024 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants