Use cargo deny to prevent onboarding certain crates #13938
Merged
+60
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #13938 +/- ##
=======================================
Coverage 59.0% 59.0%
=======================================
Files 821 821
Lines 198127 198127
=======================================
Hits 117008 117008
Misses 81119 81119 ☔ View full report in Codecov by Sentry. |
banool
force-pushed
the
banool/cargo-deny-license
branch
from
f02984e
to
b5fb4d8
Compare
JoshLind
approved these changes
Jul 9, 2024
| @@ -2,7 +2,7 @@ | |||
| name = "aptos-abstract-gas-usage" | |||
| version = "0.1.0" | |||
| edition = "2021" | |||
| # See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html | |||
| license = { workspace = true } | |||
There was a problem hiding this comment.
Silly question: why do we need to add this entry to some toml files, but not others? 😄
There was a problem hiding this comment.
I believe all the other ones have license already and just these ones were missing it and therefore unlicensed according to the tool.
There was a problem hiding this comment.
Aah, nice, didn't realize they were all missing the workspace keys, e.g.,
# Workspace inherited keys
authors = { workspace = true }
edition = { workspace = true }
homepage = { workspace = true }
license = { workspace = true }
publish = { workspace = true }
repository = { workspace = true }
rust-version = { workspace = true }
ibalajiarun
approved these changes
Jul 9, 2024
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
✅ Forge suite
|
✅ Forge suite
|
✅ Forge suite
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Internal context: https://aptos-org.slack.com/archives/C03K45JU90C/p1720451868050819.
Type of Change
Which Components or Systems Does This Change Impact?
How Has This Been Tested?
CI is expected to fail until @grao1991 lands his PR. See thread in summary for more context. Once that is done, see that the new CI passes.
Update: CI passes now that that PR has been landed. Let's land.
Key Areas to Review
Confirm that deny.toml is configured appropriately.
Checklist