Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

markuze/haproxy fullnode docker #4738

Closed
wants to merge 1 commit into from
Closed

markuze/haproxy fullnode docker #4738

wants to merge 1 commit into from

Conversation

Markuze
Copy link
Contributor

@Markuze Markuze commented Oct 3, 2022 •
edited by geekflyer

This change is Reviewable

@Markuze Markuze requested a review from a team as a code owner October 3, 2022 22:42
@perryjrandall
Copy link
Contributor

  1. There are some unrelated changes in here that need testing and more explanation
  2. In either case you need a test plan for this

perryjrandall
perryjrandall requested changes Oct 3, 2022
View reviewed changes
Copy link
Contributor

@perryjrandall perryjrandall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please show how you tested this

@Markuze
Copy link
Contributor Author

Markuze commented Oct 4, 2022 •
edited

A. docker haproxy.cfg is aligned with terraform haproxy.cfg.
B. Tested on my aws ubuntu VM:
docker compose -f up

I can join the Testnet with same machine but I need this VMs credentials added to the chain. @sherry-x .

@Markuze Markuze force-pushed the markuze/haproxy_fullnode_docker branch from 87a4552 to 3128697 Compare October 10, 2022 22:47
@Markuze Markuze closed this Oct 17, 2022
@davidiw davidiw deleted the markuze/haproxy_fullnode_docker branch December 4, 2022 17:29
@Abuchtela Abuchtela mentioned this pull request Apr 22, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@perryjrandall perryjrandall perryjrandall approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Markuze @perryjrandall