[Spec] Added specs for module gas_schedule & aptos_coin & chain_id & chain_status. #5771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xOutOfGas
requested review from
areshand,
junkil-park,
davidiw,
movekevin and
wrwg
as code owners
junkil-park
reviewed
Dec 8, 2022
| spec set_genesis_end { | ||
| pragma verify = false; | ||
| } | ||
|
|
||
| spec schema RequiresIsOperating { | ||
| requires is_operating(); | ||
| requires !is_operating(); |
There was a problem hiding this comment.
@junkil-park Sorry, this was a mistake. Fixed.
junkil-park
reviewed
Dec 8, 2022
| @@ -1,6 +1,10 @@ | |||
| spec aptos_framework::util { | |||
| spec from_bytes { | |||
| spec from_bytes<T>(bytes: vector<u8>): T { | |||
| // TODO: temporary mockup. | |||
There was a problem hiding this comment.
This comment line can be deleted.
|
This PR looks good overall. I left some comments. |
movekevin
approved these changes
Dec 8, 2022
junkil-park
approved these changes
Dec 13, 2022
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
✅ Forge suite
|
✅ Forge suite
|
areshand
pushed a commit
to areshand/aptos-core-1
that referenced
this pull request
Dec 18, 2022
…chain_status. (aptos-labs#5771) * Updated the spec of gas_schedule * add aptos_coin & chain_id & chain_status spec * Generate spec doc * Updated chain_status.spec.move * Updated chain_status.spec.move * Generate spec doc Co-authored-by: yoyoping <zhangping_ymd@outlook.com> Co-authored-by: tiutiutiu <qiu971009@gmail.com>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a part of spec work for Aptos Framework from MoveBit, we updated below files/modules in this PR:
Test Plan
aptos move prove --package-dir ./aptos-framework