Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new terms to spellcheck dictionary from glossary PR #7254 and Use CLI #7526

Merged
merged 3 commits into from
Apr 3, 2023

Conversation

clay-aptos
Copy link
Contributor

Description

Test Plan

@clay-aptos clay-aptos changed the title Add new terms to spellcheck dictionary from glassary PR #7254 Add new terms to spellcheck dictionary from glossary PR #7254 Apr 3, 2023
@clay-aptos clay-aptos changed the title Add new terms to spellcheck dictionary from glossary PR #7254 Add new terms to spellcheck dictionary from glossary PR #7254 and Use CLI Apr 3, 2023
@@ -140,6 +138,8 @@ Labs's
Leaderboard
Liveness
MOV
MSVC
MVM
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is MVM -> MoveVM?

(I'll accept it for now, but let's make sure if it is, to get rid of it and move to MoveVM

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not coming from the new Glossary PR and appears long existent:
https://aptos.dev/reference/glossary/#move-virtual-machine-mvm

@movekevin or @wrwg , Do we use MVM?

@clay-aptos clay-aptos enabled auto-merge (squash) April 3, 2023 17:55
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 3, 2023

✅ Forge suite compat success on testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> 8863a1b93df4a689c207e00d32e756885cd03547

Compatibility test results for testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> 8863a1b93df4a689c207e00d32e756885cd03547 (PR)
1. Check liveness of validators at old version: testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b
compatibility::simple-validator-upgrade::liveness-check : 8168 TPS, 4699 ms latency, 7000 ms p99 latency,no expired txns
2. Upgrading first Validator to new version: 8863a1b93df4a689c207e00d32e756885cd03547
compatibility::simple-validator-upgrade::single-validator-upgrade : 4408 TPS, 9009 ms latency, 12400 ms p99 latency,no expired txns
3. Upgrading rest of first batch to new version: 8863a1b93df4a689c207e00d32e756885cd03547
compatibility::simple-validator-upgrade::half-validator-upgrade : 4848 TPS, 8363 ms latency, 10400 ms p99 latency,no expired txns
4. upgrading second batch to new version: 8863a1b93df4a689c207e00d32e756885cd03547
compatibility::simple-validator-upgrade::rest-validator-upgrade : 6809 TPS, 5642 ms latency, 9000 ms p99 latency,no expired txns
5. check swarm health
Compatibility test for testnet_2d8b1b57553d869190f61df1aaf7f31a8fc19a7b ==> 8863a1b93df4a689c207e00d32e756885cd03547 passed
Test Ok

@github-actions
Copy link
Contributor

github-actions bot commented Apr 3, 2023

✅ Forge suite land_blocking success on 8863a1b93df4a689c207e00d32e756885cd03547

performance benchmark with full nodes : 5531 TPS, 7151 ms latency, 11200 ms p99 latency,(!) expired 580 out of 2362540 txns
Test Ok

@github-actions
Copy link
Contributor

github-actions bot commented Apr 3, 2023

✅ Forge suite framework_upgrade success on aptos-node-v1.3.0_3fc3d42b6cfe27460004f9a0326451bcda840a60 ==> 8863a1b93df4a689c207e00d32e756885cd03547

Compatibility test results for aptos-node-v1.3.0_3fc3d42b6cfe27460004f9a0326451bcda840a60 ==> 8863a1b93df4a689c207e00d32e756885cd03547 (PR)
Upgrade the nodes to version: 8863a1b93df4a689c207e00d32e756885cd03547
framework_upgrade::framework-upgrade::full-framework-upgrade : 6224 TPS, 6224 ms latency, 8700 ms p99 latency,no expired txns
5. check swarm health
Compatibility test for aptos-node-v1.3.0_3fc3d42b6cfe27460004f9a0326451bcda840a60 ==> 8863a1b93df4a689c207e00d32e756885cd03547 passed
Test Ok

@clay-aptos clay-aptos merged commit 2898b05 into main Apr 3, 2023
35 checks passed
@clay-aptos clay-aptos deleted the clay-aptos-glossary-spellcheck branch April 3, 2023 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants