Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CLI] Fix empty vector, and cleanup vec<u8> parsing #7789

Closed
wants to merge 2 commits into from
Closed

[CLI] Fix empty vector, and cleanup vec<u8> parsing #7789

wants to merge 2 commits into from

Conversation

gregnazario
Copy link
Contributor

Description

Test Plan

@gregnazario gregnazario changed the title Empty vector cli input [CLI] Fix empty vector, and cleanup vec<u8> parsing Apr 15, 2023
@lightmark
Copy link
Contributor

could we use recursive [] to represent vectors? I don't think we should ensure backwards compatibility for CLI if we witness a significant shortcoming of the current input format.

@alnoki
Copy link
Contributor

alnoki commented Apr 15, 2023

could we use recursive [] to represent vectors? I don't think we should ensure backwards compatibility for CLI if we witness a significant shortcoming of the current input format.

@lightmark @gregnazario #7790 adds recursive [].

@gregnazario gregnazario closed this May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lightmark lightmark Awaiting requested review from lightmark

@banool banool Awaiting requested review from banool banool will be requested when the pull request is marked ready for review banool is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gregnazario @lightmark @alnoki