Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[circleci] retry docker-compose testnet startup #872

Merged
merged 3 commits into from May 10, 2022

Conversation

rustielin
Copy link
Contributor

@rustielin rustielin commented May 9, 2022

Docker-compose networking is a bit flaky on CircleCI machines (tracking in a separate issue). Introduce some retry logic to the startup step, blocking for a maximum of 5 minutes.

Resolves #788 for ecosystem tests. Forge improvements coming separately as well :)

Test locally and by canary. To roll this out, we can enable DOCKER_COMPOSE_BLOCKING again, to start testing ecosystem stuff that relies on docker-compose.

@aptos-bot aptos-bot added this to In Review in bors May 9, 2022
@rustielin
Copy link
Contributor Author

/canary

@aptos-bot aptos-bot moved this from In Review to Canary in bors May 9, 2022
@rustielin rustielin marked this pull request as ready for review May 9, 2022 19:02
@aptos-bot
Copy link
Contributor

Forge run: https://circleci.com/gh/aptos-labs/aptos-core/15390
Forge test result: all up : 1367 TPS, 3184 ms latency, 4800 ms p99 latency,no expired txns

@aptos-bot aptos-bot moved this from Canary to In Review in bors May 9, 2022
@aptos-bot
Copy link
Contributor

☀️ Canary successful

@rustielin
Copy link
Contributor Author

/land

here goes

@aptos-bot aptos-bot moved this from In Review to Queued in bors May 9, 2022
@aptos-bot aptos-bot moved this from Queued to Testing in bors May 9, 2022
@aptos-bot
Copy link
Contributor

Forge run: https://circleci.com/gh/aptos-labs/aptos-core/15494
Forge test result: all up : 1381 TPS, 3169 ms latency, 4700 ms p99 latency,no expired txns

@aptos-bot
Copy link
Contributor

💔 Test Failed - build-test-deploy

@aptos-bot aptos-bot moved this from Testing to In Review in bors May 9, 2022
@rustielin
Copy link
Contributor Author

rustielin commented May 9, 2022

/land

fixed typescript lint woo

@aptos-bot aptos-bot moved this from In Review to Queued in bors May 9, 2022
@aptos-bot aptos-bot moved this from Queued to Testing in bors May 9, 2022
@aptos-bot
Copy link
Contributor

Forge run: https://circleci.com/gh/aptos-labs/aptos-core/15602
Forge test result: all up : 1394 TPS, 3156 ms latency, 4700 ms p99 latency,no expired txns

@aptos-bot
Copy link
Contributor

💔 Test Failed - build-test-deploy

@aptos-bot aptos-bot moved this from Testing to In Review in bors May 10, 2022
@rustielin
Copy link
Contributor Author

/land

@aptos-bot aptos-bot moved this from In Review to Queued in bors May 10, 2022
@aptos-bot
Copy link
Contributor

❗ Land has been canceled due to this PR being updated with new commits. Please issue another Land command if you want to requeue this PR.

@aptos-bot aptos-bot moved this from Queued to In Review in bors May 10, 2022
@rustielin
Copy link
Contributor Author

/land

@aptos-bot aptos-bot moved this from In Review to Queued in bors May 10, 2022
@aptos-bot aptos-bot moved this from Queued to Testing in bors May 10, 2022
@aptos-bot
Copy link
Contributor

💔 Test Failed - build-test-deploy

@aptos-bot aptos-bot moved this from Testing to In Review in bors May 10, 2022
@rustielin
Copy link
Contributor Author

/land

@aptos-bot aptos-bot moved this from In Review to Queued in bors May 10, 2022
@aptos-bot aptos-bot moved this from Queued to Testing in bors May 10, 2022
@aptos-bot
Copy link
Contributor

Forge run: https://circleci.com/gh/aptos-labs/aptos-core/15754
Forge test result: all up : 1393 TPS, 3144 ms latency, 4700 ms p99 latency,no expired txns

@aptos-bot aptos-bot removed this from Testing in bors May 10, 2022
@aptos-bot aptos-bot merged commit 491aa33 into aptos-labs:main May 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[cicd] enable ecosystem test and forge as blocking
3 participants