Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

% sig in deprecation message breaks synfony on php8 #57

Closed
Richard87 opened this issue Apr 1, 2021 · 2 comments
Closed

% sig in deprecation message breaks synfony on php8 #57

Richard87 opened this issue Apr 1, 2021 · 2 comments

Comments

@Richard87
Copy link
Contributor

Master branch is broken on php8 / symfony, the % sign is not supported in the deprecation message: symfony/symfony#40630.

The problem is in services.xml, i would submit a PR, but im out of the office 馃槄

@rvanlaak
Copy link
Collaborator

rvanlaak commented Apr 8, 2021

I just merged PR #58 to test on PHP8 and Symfony latest. No code changes were needed to get that PR green, just changes to the CI.yaml file to include these versions. As you can see, tests on all latest versions are green.

@Richard87 Could it be that the latest release is broken on the latest Symfony, instead of master as you're mentioning? Can you verify that by requiring dev-master in your project and run bin/console cache:warmup again? If that solves your problem, I will tag a new release.

And, can you share a sample of the code where you are using this bundle?

@Richard87
Copy link
Contributor Author

Thanks, it works perfect here to after running composer update in php8 environment... maybe I messed it up by using composer install in php7 and running it in php8 or something....

Thanks for checking it out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants