Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Obsolete parsing and File not found fix #264

Merged
merged 2 commits into from Jan 29, 2023
Merged

Obsolete parsing and File not found fix #264

merged 2 commits into from Jan 29, 2023

Conversation

l-bick
Copy link

@l-bick l-bick commented Jan 25, 2023

Fix for #4
The problem is that the obsolete.dat is parsed, but old references are not replaced by newer ones.
I pulled the obsolete last week and still got 'file not found' errors. I could trace it back to the file itself. I added code after parsing, which replaces all cross-references with the latest pdb-ids, replacing all older ones. An example can be shown in the following table:

< OLD > | < NEW >
OBSLTE 13-MAY-20 6L2V 7BYZ | OBSLTE 13-MAY-20 6L2V 7DE5
OBSLTE 22-JUL-20 7BYZ 7CH2 | OBSLTE 22-JUL-20 7BYZ 7DE5
OBSLTE 25-NOV-20 7CH2 7DE5 | OBSLTE 25-NOV-20 7CH2 7DE5

If you had 6L2V as input, it currently searches for 7BYZ and throws an error and stops.
In the new version, 6L2V gets replaced with 7DE5 and it works flawlessly.

@gahdritz
Copy link
Collaborator

Thanks for this! This bug's been around for a while...

@gahdritz gahdritz merged commit 386fd1a into aqlaboratory:main Jan 29, 2023
@l-bick l-bick deleted the obsolete_loading_fix branch August 31, 2023 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants