Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change test_compare_model in deepspeed test to use mean instead of max #396

Merged
merged 1 commit into from Jan 17, 2024

Conversation

jnwei
Copy link
Collaborator

@jnwei jnwei commented Jan 11, 2024

This test was flaky due to the large range of the difference in error (~0.2 - 1.3).

Using a mean difference instead will have a smaller range (0.05 - 0.15), and make the test less flaky.

@christinaflo christinaflo merged commit 9e057b7 into multimer Jan 17, 2024
2 checks passed
@jnwei jnwei deleted the deepspeed-mean-test branch February 2, 2024 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants