Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(99designs/aws-vault): support darwin #11204

Merged
merged 4 commits into from
Mar 31, 2023
Merged

Conversation

u-yas
Copy link
Contributor

@u-yas u-yas commented Mar 30, 2023

Now that we have support for the dmg format, we have also added it to the aqua-registry

https://github.com/aquaproj/aqua/blob/main/tests/macos/registry.yaml#L8-L23

@suzuki-shunsuke suzuki-shunsuke added this to the v3.150.0 milestone Mar 31, 2023
@suzuki-shunsuke
Copy link
Member

Thank you for your contribution!

@suzuki-shunsuke
Copy link
Member

📝 aqua >= v2.2.0 is required. https://github.com/aquaproj/aqua/releases/tag/v2.2.0 aquaproj/aqua#1706

```console
$ aqua-registry gr
```
@suzuki-shunsuke
Copy link
Member

Please don't forget to update registry.yaml by aqua-registry gr command.

$ aqua-registry gr

@suzuki-shunsuke
Copy link
Member

In this repository's CI, we simulate darwin/arm64 on linux/amd64, but hdiutil isn't installed in linux so CI failed.
https://github.com/aquaproj/aqua-registry/actions/runs/4570150891/jobs/8067155385?pr=11204

@suzuki-shunsuke suzuki-shunsuke changed the title chore(aws-vault): support darwin chore(99designs/aws-vault): support darwin Mar 31, 2023
```
rm pkgs/99designs/aws-vault/pkg.yaml pkgs/99designs/aws-vault/registry.yaml
aqua-registry scaffold --deep 99designs/aws-vault
```
@suzuki-shunsuke
Copy link
Member

Recreated configuration by --deep option.

rm pkgs/99designs/aws-vault/pkg.yaml pkgs/99designs/aws-vault/registry.yaml
aqua-registry scaffold --deep 99designs/aws-vault

@suzuki-shunsuke suzuki-shunsuke merged commit 1e28386 into aquaproj:main Mar 31, 2023
@suzuki-shunsuke
Copy link
Member

@u-yas
Copy link
Contributor Author

u-yas commented Mar 31, 2023

@suzuki-shunsuke

sorry. be careful from next time

@u-yas u-yas deleted the patch-1 branch March 31, 2023 02:27
@suzuki-shunsuke
Copy link
Member

No problem. Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants