Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use getsops/sops instead of deprecated mozilla/sops #15230

Merged
merged 1 commit into from
Sep 6, 2023

Conversation

natemccurdy
Copy link
Contributor

The Mozilla team has stopped development of SOPS and donated the project
to the CNCF. The GitHub repo has changed from mozilla/sops to
getsops/sops as well.

This updates the sops package to reflect the new Github owner and repo.

Old: mozilla/sops
New: getsops/sops

@suzuki-shunsuke
Copy link
Member

Thank you for your contribution!

@natemccurdy natemccurdy force-pushed the fix/getsops/sops branch 2 times, most recently from f392cff to ccc9932 Compare September 6, 2023 23:27
Copy link
Member

@suzuki-shunsuke suzuki-shunsuke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you update pkgs/*/registry.yaml, please run aqua-registry gr to update registry.yaml.
https://github.com/aquaproj/aqua-registry/actions/runs/6103454359/job/16563911481?pr=15230

pkgs/getsops/sops/registry.yaml Show resolved Hide resolved
pkgs/getsops/sops/registry.yaml Outdated Show resolved Hide resolved
@natemccurdy
Copy link
Contributor Author

natemccurdy commented Sep 6, 2023

@suzuki-shunsuke For a project that has changed owners and repos but is essentially the same tool, should these kinds of moves be using the new aliases feature? Or is what I did here fine?

@suzuki-shunsuke
Copy link
Member

@suzuki-shunsuke For a project that has changed owners and repos but is essentially the same tool, should these kinds of moves be using the new aliases feature? Or is what I did here fine?

Good point 👍 Could you set aliases?

The Mozilla team has stopped development of SOPS and donated the project
to the CNCF. The GitHub repo has changed from mozilla/sops to
getsops/sops as well.

This updates the sops package to reflect the new Github owner and repo.
@natemccurdy
Copy link
Contributor Author

@suzuki-shunsuke All comments have been addressed. Thanks for your review.

@suzuki-shunsuke
Copy link
Member

Thank you!

@suzuki-shunsuke suzuki-shunsuke merged commit 136ac04 into aquaproj:main Sep 6, 2023
16 checks passed
@suzuki-shunsuke suzuki-shunsuke added this to the v4.44.2 milestone Sep 6, 2023
@natemccurdy natemccurdy deleted the fix/getsops/sops branch September 6, 2023 23:45
@suzuki-shunsuke
Copy link
Member

v4.44.2 is out 🎉
https://github.com/aquaproj/aqua-registry/releases/tag/v4.44.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants