Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add aws/session-manager-plugin #15274

Merged

Conversation

ponkio-o
Copy link
Sponsor Contributor

@ponkio-o ponkio-o commented Sep 8, 2023

aws/session-manager-plugin: This plugin helps you to use the AWS Command Line Interface (AWS CLI) to start and end sessions to your managed instances

$ aqua g -i aws/session-manager-plugin

How to confirm if this package works well

Reviewers aren't necessarily familiar with this package, so please describe how to confirm if this package works well.
Please confirm if this package works well yourself as much as possible.

Command and output

$ session-manager-plugin --version
1.2.497.0

Note session-manager-plugin command doesn't have help command.

You can verify to work the command with aws cli.
https://docs.aws.amazon.com/systems-manager/latest/userguide/session-manager-working-with-sessions-start.html

Reference

@suzuki-shunsuke suzuki-shunsuke added the enhancement New feature or request label Sep 8, 2023
@suzuki-shunsuke
Copy link
Member

Thank you always!

@suzuki-shunsuke suzuki-shunsuke added this to the v4.45.1 milestone Sep 8, 2023
ponkio-o and others added 3 commits September 8, 2023 22:11
@suzuki-shunsuke
Copy link
Member

suzuki-shunsuke commented Sep 8, 2023

In my understanding, users don't run this tool directly.
Instead users run commands such as aws ssm start-session then this tool is run internally.

https://docs.aws.amazon.com/systems-manager/latest/userguide/session-manager-working-with-sessions-start.html

Did you test if this tool really worked via aqua?

@ponkio-o
Copy link
Sponsor Contributor Author

ponkio-o commented Sep 8, 2023

In my understanding, users don't run this tool directly.

Yes. This tool used by awscli internally.
https://github.com/aws/aws-cli/blob/f2ca1deb85d5eafbf904df5157488342edf2d602/awscli/customizations/sessionmanager.py#L57-L102

Therefore, session-manager-plugin can't be used by itself.

It worked in my environment.

$ which session-manager-plugin
/Users/<user>/.local/share/aquaproj-aqua/bin/session-manager-plugin

$ aws ssm start-session --target <instance-id>
Starting session with SessionId: botocore-session-1694179301-04fd2340c8a7bbc5d
sh-4.2$

@suzuki-shunsuke
Copy link
Member

Thank you for your confirmation! Looks good.

@suzuki-shunsuke suzuki-shunsuke merged commit a6a62aa into aquaproj:main Sep 8, 2023
16 checks passed
@suzuki-shunsuke
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants