Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(smallstep/certificates): src incorrect after 0.23.0-rc.1 #15480

Merged
merged 4 commits into from
Sep 16, 2023

Conversation

scottames
Copy link
Contributor

Follow up to #14385.

Fixes smallstep/certificates to only use 'bin/' path in 0.23.0-rc.1 as after this it is no longer present and breaks versions after this.

Follow up to aquaproj#14385.

Fixes smallstep/certificates to only use 'bin/' path in 0.23.0-rc.1 as after this it is no longer present and breaks versions after this.
@suzuki-shunsuke
Copy link
Member

Thank you for your contribution!

@suzuki-shunsuke
Copy link
Member

suzuki-shunsuke commented Sep 16, 2023

Indeed, I confirmed the bug. These versions couldn't be installed. Nice catch.

🤔 The tag v0.23.0-rc.1 exists, but the release v0.23.0-rc.1 isn't found. Perhaps it was deleted.

https://github.com/smallstep/certificates/tree/v0.23.0-rc.1
https://github.com/smallstep/certificates/releases/tag/v0.23.0-rc1

image

Affected versions

  • v0.24.2
  • v0.24.1
  • v0.24.0
  • v0.24.0-rc.2
  • v0.24.0-rc1
  • v0.23.2
  • v0.23.1
  • v0.23.1-rc.1
  • v0.23.0
  • v0.23.0-rc.3
  • v0.23.0-rc.2

We need to fix testdata pkgs/smallstep/certificates/pkg.yaml if we fix version constraints for testing.

I fixed the testdata. 4ec002c

Then CI failed. https://github.com/aquaproj/aqua-registry/actions/runs/6209579215/job/16856978485

ERRO[0004] check file_src is correct                     aqua_version=2.10.2-1 env=darwin/arm64 error="check file_src is correct: exe_path isn't found: stat /Users/runner/.local/share/aquaproj-aqua/pkgs/github_release/github.com/smallstep/certificates/v0.23.0-rc.2/step-ca_darwin_0.23.0-rc.2_amd64.tar.gz/step-ca_0.23.0-rc.2/bin/step-ca: no such file or directory" exe_path=/Users/runner/.local/share/aquaproj-aqua/pkgs/github_release/github.com/smallstep/certificates/v0.23.0-rc.2/step-ca_darwin_0.23.0-rc.2_amd64.tar.gz/step-ca_0.23.0-rc.2/bin/step-ca file_name=step-ca package_name=smallstep/certificates package_version=v0.23.0-rc.2 program=aqua registry=standard
ERRO[0004] executable files aren't found
Files in the unarchived package:
step-ca_0.23.0-rc.2/step-ca
   aqua_version=2.10.2-1 env=darwin/arm64 package_name=smallstep/certificates package_version=v0.23.0-rc.2 program=aqua registry=standard

So I fixed registry.yaml. 92593c0

@suzuki-shunsuke suzuki-shunsuke added the bug Something isn't working label Sep 16, 2023
@suzuki-shunsuke suzuki-shunsuke added this to the v4.48.2 milestone Sep 16, 2023
@suzuki-shunsuke suzuki-shunsuke merged commit 46506e4 into aquaproj:main Sep 16, 2023
16 checks passed
suzuki-shunsuke added a commit that referenced this pull request Sep 16, 2023
@suzuki-shunsuke
Copy link
Member

@scottames
Copy link
Contributor Author

Thanks @suzuki-shunsuke!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants