Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add anordal/shellharden #21239

Merged

Conversation

hituzi-no-sippo
Copy link
Sponsor Contributor

crates.io/shellharden: The corrective bash syntax highlighter

$ aqua g -i anordal/shellharden

How to confirm if this package works well

Reviewers aren't necessarily familiar with this package, so please
describe how to confirm if this package works well.
Please confirm if this package works well yourself as much as possible.

Command and output

$ echo '${a}' | shellharden --replace ''
"$a"

If files such as configuration file are needed, please share them.

None

Reference

Comment on lines +5 to +8
aliases:
# The registry had registered this name when this tool was first registered.
# https://github.com/aquaproj/aqua-registry/pull/13784
- name: crates.io/shellharden
Copy link
Sponsor Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wrote this code with reference to #17534.

Comment on lines +12 to +14
- version_constraint: semver("<= 4.3.0")
type: cargo
crate: shellharden
Copy link
Sponsor Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wrote this code with reference to #17534.

[anordal/shellharden](https://github.com/anordal/shellharden): The corrective bash syntax highlighter
@suzuki-shunsuke
Copy link
Member

Thank you for your contribution!

@suzuki-shunsuke
Copy link
Member

suzuki-shunsuke commented Mar 25, 2024

There are several issues.

  1. Update crates.io/shellharden to 4.3.1 or later gets broken.
- name: crates.io/shellharden@4.3.1

Renovate would update crates.io/shellharden to 4.3.1, which would break the package.

  1. aqua can't list versions 4.3.0 or older by aqua g -s anordal/shellharden and aqua g -s crates.io/shellharden command
> v4.3.1                                                               │                                                                      │
  1/1                                                                  │                                                                      │
>

We'll merge this pull request, but ideally we want to update aqua to solve these issues.

@suzuki-shunsuke suzuki-shunsuke merged commit 5047132 into aquaproj:main Mar 25, 2024
16 checks passed
@suzuki-shunsuke suzuki-shunsuke modified the milestones: v4.155.0, v4.155.1 Mar 25, 2024
@suzuki-shunsuke
Copy link
Member

v4.155.1 is out 🎉
https://github.com/aquaproj/aqua-registry/releases/tag/v4.155.1

@hituzi-no-sippo hituzi-no-sippo deleted the feat/anordal/shellharden branch March 25, 2024 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants