Skip to content

Commit

Permalink
test: add tests
Browse files Browse the repository at this point in the history
  • Loading branch information
@suzuki-shunsuke
suzuki-shunsuke committed Mar 26, 2023
1 parent 5704075 commit 45dcb68
Showing 1 changed file with 174 additions and 8 deletions.
182 changes: 174 additions & 8 deletions pkg/policy/validate_test.go
View file
Original file line number Diff line number Diff line change
Expand Up @@ -5,18 +5,17 @@ import (

"github.com/aquaproj/aqua/v2/pkg/config"
"github.com/aquaproj/aqua/v2/pkg/policy"
"github.com/aquaproj/aqua/v2/pkg/util"
"github.com/sirupsen/logrus"
"github.com/spf13/afero"
)

func TestValidator_Allow(t *testing.T) {
func TestValidator_Allow(t *testing.T) { //nolint:dupl
t.Parallel()
data := []struct {
name string
rootDir string
configFilePath string
files map[string]string
dirs map[string]struct{}
isErr bool
}{
{
Expand All @@ -28,8 +27,9 @@ func TestValidator_Allow(t *testing.T) {
},
},
{
name: "warn file exists",
rootDir: "/home/foo/.local/share/aquaproj-aqua",
name: "warn file exists",
rootDir: "/home/foo/.local/share/aquaproj-aqua",
configFilePath: "/home/foo/workspace/aqua-policy.yaml",
files: map[string]string{
"/home/foo/workspace/aqua-policy.yaml": "",
"/home/foo/.local/share/aquaproj-aqua/policy-warnings/home/foo/workspace/aqua-policy.yaml": "",
Expand All @@ -46,15 +46,181 @@ func TestValidator_Allow(t *testing.T) {
t.Fatal(err)
}
}
for name := range d.dirs {
if err := util.MkdirAll(fs, name); err != nil {
validator := policy.NewValidator(&config.Param{
RootDir: d.rootDir,
}, fs)
if err := validator.Allow(d.configFilePath); err != nil {
if d.isErr {
return
}
t.Fatal(err)
}
if d.isErr {
t.Fatal("error must be returend")
}
})
}
}

func TestValidator_Deny(t *testing.T) { //nolint:dupl
t.Parallel()
data := []struct {
name string
rootDir string
configFilePath string
files map[string]string
isErr bool
}{
{
name: "normal",
rootDir: "/home/foo/.local/share/aquaproj-aqua",
configFilePath: "/home/foo/workspace/aqua-policy.yaml",
files: map[string]string{
"/home/foo/workspace/aqua-policy.yaml": "",
},
},
{
name: "remove allowed policy file",
configFilePath: "/home/foo/workspace/aqua-policy.yaml",
rootDir: "/home/foo/.local/share/aquaproj-aqua",
files: map[string]string{
"/home/foo/workspace/aqua-policy.yaml": "",
"/home/foo/.local/share/aquaproj-aqua/policies/home/foo/workspace/aqua-policy.yaml": "",
},
},
}
for _, d := range data {
d := d
t.Run(d.name, func(t *testing.T) {
t.Parallel()
fs := afero.NewMemMapFs()
for name, body := range d.files {
if err := afero.WriteFile(fs, name, []byte(body), 0o644); err != nil {
t.Fatal(err)
}
}
validator := policy.NewValidator(&config.Param{
RootDir: d.rootDir,
}, fs)
if err := validator.Allow(d.configFilePath); err != nil {
if err := validator.Deny(d.configFilePath); err != nil {
if d.isErr {
return
}
t.Fatal(err)
}
if d.isErr {
t.Fatal("error must be returend")
}
})
}
}

func TestValidator_Warn(t *testing.T) {
t.Parallel()
data := []struct {
name string
rootDir string
configFilePath string
files map[string]string
isErr bool
}{
{
name: "normal",
rootDir: "/home/foo/.local/share/aquaproj-aqua",
configFilePath: "/home/foo/workspace/aqua-policy.yaml",
files: map[string]string{
"/home/foo/workspace/aqua-policy.yaml": "",
},
},
{
name: "warn file exists",
configFilePath: "/home/foo/workspace/aqua-policy.yaml",
rootDir: "/home/foo/.local/share/aquaproj-aqua",
files: map[string]string{
"/home/foo/workspace/aqua-policy.yaml": "",
"/home/foo/.local/share/aquaproj-aqua/policy-warnings/home/foo/workspace/aqua-policy.yaml": "",
},
},
}
logE := logrus.NewEntry(logrus.New())
for _, d := range data {
d := d
t.Run(d.name, func(t *testing.T) {
t.Parallel()
fs := afero.NewMemMapFs()
for name, body := range d.files {
if err := afero.WriteFile(fs, name, []byte(body), 0o644); err != nil {
t.Fatal(err)
}
}
validator := policy.NewValidator(&config.Param{
RootDir: d.rootDir,
}, fs)
if err := validator.Warn(logE, d.configFilePath); err != nil {
if d.isErr {
return
}
t.Fatal(err)
}
if d.isErr {
t.Fatal("error must be returend")
}
})
}
}

func TestValidator_Validate(t *testing.T) { //nolint:funlen
t.Parallel()
data := []struct {
name string
rootDir string
configFilePath string
files map[string]string
isErr bool
}{
{
name: "normal",
rootDir: "/home/foo/.local/share/aquaproj-aqua",
configFilePath: "/home/foo/workspace/aqua-policy.yaml",
files: map[string]string{
"/home/foo/workspace/aqua-policy.yaml": "",
"/home/foo/.local/share/aquaproj-aqua/policies/home/foo/workspace/aqua-policy.yaml": "",
},
},
{
name: "policy is not found",
configFilePath: "/home/foo/workspace/aqua-policy.yaml",
rootDir: "/home/foo/.local/share/aquaproj-aqua",
files: map[string]string{
"/home/foo/workspace/aqua-policy.yaml": "",
},
isErr: true,
},
{
name: "policy is changed",
configFilePath: "/home/foo/workspace/aqua-policy.yaml",
rootDir: "/home/foo/.local/share/aquaproj-aqua",
files: map[string]string{
"/home/foo/workspace/aqua-policy.yaml": "",
"/home/foo/.local/share/aquaproj-aqua/policies/home/foo/workspace/aqua-policy.yaml": "a",
},
isErr: true,
},
}
for _, d := range data {
d := d
t.Run(d.name, func(t *testing.T) {
t.Parallel()
fs := afero.NewMemMapFs()
for name, body := range d.files {
if err := afero.WriteFile(fs, name, []byte(body), 0o644); err != nil {
t.Fatal(err)
}
}
validator := policy.NewValidator(&config.Param{
RootDir: d.rootDir,
}, fs)
if err := validator.Validate(d.configFilePath); err != nil {
if d.isErr {
return
}
Expand Down

0 comments on commit 45dcb68

Please sign in to comment.