Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable require_checksum by default #1681

Closed
suzuki-shunsuke opened this issue Feb 28, 2023 · 2 comments · Fixed by #1686
Closed

Enable require_checksum by default #1681

suzuki-shunsuke opened this issue Feb 28, 2023 · 2 comments · Fixed by #1686

Comments

@suzuki-shunsuke
Copy link
Member

suzuki-shunsuke commented Feb 28, 2023

Feature Overview

Enable require_checksum by default.

Why is the feature needed?

Please explain the problem you want to solve.

To enforce the checksum verification and improve the security.
Checksum Verification has a trade off between security and user experience.
require_checksum was disabled for user experience, but I think we should make require_checksum enabled by default from aqua v2.

require_checksum will be changed from aqua v2.

Note that checksum verification is still disabled by default.
I think it is a bit difficult to enable checksum verification by default in terms of user experience.
Unfortunately, many users don't think checksum verification is mandatory.

Does the feature include Breaking Changes?

Yes.

Example Code

command and configuration

$ 
@suzuki-shunsuke
Copy link
Member Author

@suzuki-shunsuke suzuki-shunsuke linked a pull request Mar 3, 2023 that will close this issue
@suzuki-shunsuke
Copy link
Member Author

We changed the mind and decided to disable require_checksum by default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant