Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Execute commands by execve(2) by default #1925

Closed
suzuki-shunsuke opened this issue May 3, 2023 · 3 comments
Closed

Execute commands by execve(2) by default #1925

suzuki-shunsuke opened this issue May 3, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@suzuki-shunsuke
Copy link
Member

suzuki-shunsuke commented May 3, 2023 •
edited
Loading

Feature Overview

Execute commands by execve(2) by default.

Why is the feature needed?

Please explain the problem you want to solve.

The bug #729 (comment) seems to be resolved.
I'm checking if the bug is really resolved.

Does the feature include Breaking Changes?

No.

Example Code

Add the environment variable AQUA_X_SYS_EXEC.
The default value is true. If this is true, aqua executes commands by execve(2).
You don't want this behaviour, please set AQUA_X_SYS_EXEC to false.

export AQUA_X_SYS_EXEC=false

⚠️ Windows doesn't support execve(2)

Windows doesn't support execve(2), so aqua ignores AQUA_X_SYS_EXEC and AQUA_EXPERIMENTAL_X_SYS_EXEC and executes commands as subprocess in Windows.

Reference
@suzuki-shunsuke suzuki-shunsuke added the enhancement New feature or request label May 3, 2023
@suzuki-shunsuke suzuki-shunsuke changed the title Make AQUA_EXPERIMENTAL_X_SYS_EXEC enabled by default Execute commands by execve(2) by default May 3, 2023
suzuki-shunsuke added a commit that referenced this issue May 3, 2023
@suzuki-shunsuke
feat: execute commands by execve(2) by default
f88f774 
- #1925
@suzuki-shunsuke suzuki-shunsuke mentioned this issue May 3, 2023
Merged
@suzuki-shunsuke
Copy link
Member Author

We have to fix aqua-proxy too.
I'm working on it.

suzuki-shunsuke added a commit to aquaproj/aqua-proxy that referenced this issue May 5, 2023
@suzuki-shunsuke
feat: execute commands by execve(2) by default
48b3fe4 
- aquaproj/aqua#1925
@suzuki-shunsuke suzuki-shunsuke mentioned this issue May 5, 2023
Merged
@suzuki-shunsuke
Copy link
Member Author

suzuki-shunsuke commented May 5, 2023 •
edited
Loading

suzuki-shunsuke added a commit that referenced this issue May 6, 2023
@suzuki-shunsuke
feat: execute commands by execve(2) by default (#1926)
9e08f67 
* feat: execute commands by execve(2) by default

- #1925

* chore: update aqua-proxy to v1.2.0

https://github.com/aquaproj/aqua-proxy/releases/tag/v1.2.0
@suzuki-shunsuke suzuki-shunsuke mentioned this issue May 6, 2023
Merged
@suzuki-shunsuke
Copy link
Member Author

Released. https://github.com/aquaproj/aqua/releases/tag/v2.5.0

@suzuki-shunsuke suzuki-shunsuke mentioned this issue May 7, 2023
Closed
mikutas added a commit to mikutas/linkerd-installation that referenced this issue May 8, 2023
@mikutas
chore: AQUA_X_SYS_EXEC
11b502f 
aquaproj/aqua#1925
@suzuki-shunsuke suzuki-shunsuke mentioned this issue May 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
No open projects
main
Status: Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@suzuki-shunsuke