Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change the structure of aqua-checksums.json #1250

Merged
merged 2 commits into from
Oct 2, 2022

Conversation

suzuki-shunsuke
Copy link
Member

@suzuki-shunsuke suzuki-shunsuke commented Oct 2, 2022

AS IS

{
  "checksums": {
    "github_archive/github.com/b3nj5m1n/xdg-ninja/v0.2.0.1": "f4f9ab4500e7cf865ff8b68c343537e27b9ff1e6068cb1387e516e608f77cec8"
  }
}

TO BE

{
  "checksums": [
    {
      "id": "github_archive/github.com/b3nj5m1n/xdg-ninja/v0.2.0.1",
      "checksum": "f4f9ab4500e7cf865ff8b68c343537e27b9ff1e6068cb1387e516e608f77cec8",
      "algorithm": "sha256"
    }
  ]
}

WHY

The current format doesn't have the checksum algorithm.
The current default checksum algorithm is sha512, but when this will be changed, the configuration file will be broken.
To solve the problem, the new format has the checksum algorithm.
Additionally, the value is not a atring but a object, so we can add new fields in future keeping the compatibility.

@suzuki-shunsuke suzuki-shunsuke added bug Something isn't working checksum verification labels Oct 2, 2022
@suzuki-shunsuke suzuki-shunsuke added this to the v1.20.0 milestone Oct 2, 2022
@suzuki-shunsuke suzuki-shunsuke removed the bug Something isn't working label Oct 2, 2022
@suzuki-shunsuke suzuki-shunsuke merged commit e9be4d3 into main Oct 2, 2022
@suzuki-shunsuke suzuki-shunsuke deleted the fix/change-checksum-file-structure branch October 2, 2022 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant