Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support uninstalling packages #2249

Merged
merged 4 commits into from Sep 16, 2023
Merged

feat: support uninstalling packages #2249

merged 4 commits into from Sep 16, 2023

Conversation

suzuki-shunsuke
Copy link
Member

@suzuki-shunsuke suzuki-shunsuke commented Sep 16, 2023

Close #538

Features

Add a subcommand rm to uninstall packages

Usage

$ aqua rm --all [-a] # Uninstall all packages
$ aqua rm [<registry name>,]<package name> [...] # Uninstall packages

Example

$ aqua rm -a
$ aqua rm cli/cli direnv/direnv

⚠️ Limitation

The following package types can't be removed without --all option.

  • http
  • go_install

@suzuki-shunsuke
Copy link
Member Author

suzuki-shunsuke commented Sep 16, 2023

TODO

@4513ECHO
Copy link
Contributor

I think it is better to use remove for the command name and use rm as an alias.

@suzuki-shunsuke
Copy link
Member Author

Thank you for your comment.
It makes sense. Fixed. 389fb95

@suzuki-shunsuke
Copy link
Member Author

TODO

  • -c specify command names
  • -i select packages interactively with fuzzy finder

These features are useful, but I don't implement them for now.
We'll implement them when they are really necessary.
I'd like to release this command and check the feedback before implementing them.

@suzuki-shunsuke suzuki-shunsuke merged commit 9093715 into main Sep 16, 2023
10 of 11 checks passed
@suzuki-shunsuke suzuki-shunsuke deleted the feat-aqua-rm branch September 16, 2023 22:36
@suzuki-shunsuke suzuki-shunsuke restored the feat-aqua-rm branch September 16, 2023 22:38
@suzuki-shunsuke suzuki-shunsuke deleted the feat-aqua-rm branch September 17, 2023 00:00
@ryoppippi
Copy link

Thanks!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support "aqua remove" or "aqua clean" - removing package
3 participants