Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve the logic to get the latest version #2750

Merged
merged 3 commits into from
Mar 16, 2024

Conversation

suzuki-shunsuke
Copy link
Member

@suzuki-shunsuke suzuki-shunsuke commented Mar 16, 2024

Close #2354

Change the logic to get the latest version as the following.

  1. Get a latest release and 30 most recent releases by GitHub API
  2. Try to convert them to semver
  3. Compare them and get the latest release

prelease versions are ignored unless all releases are prelease versions.

@suzuki-shunsuke suzuki-shunsuke added this to the v2.24.2 milestone Mar 16, 2024
@suzuki-shunsuke suzuki-shunsuke added the bug Something isn't working label Mar 16, 2024
@suzuki-shunsuke suzuki-shunsuke merged commit be4494b into main Mar 16, 2024
10 checks passed
@suzuki-shunsuke suzuki-shunsuke deleted the fix-improve-get-latest-version branch March 16, 2024 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sometimes aqua g outputs non latest version
1 participant