feat: download assets from public repository's GitHub Release without GitHub API #389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… GitHub API I have tested if downloading assets from public repository's GitHub Releases anonymously is rate limited. As a result of test, it seems not to be limited. So at first aqua tries to download assets without GitHub API. And if it failed, aqua tries again with GitHub API. It avoids the rate limit of GitHub API.
suzuki-shunsuke
deleted the
feat/install_github_release_without_access_token
branch
suzuki-shunsuke
added a commit
to aquaproj/aqua-registry
that referenced
this pull request
Nov 10, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #388
I have tested if downloading assets from public repository's GitHub Releases anonymously is rate limited.
As a result of test, it seems not to be limited.
So at first aqua tries to download assets without GitHub API.
And if it failed, aqua tries again with GitHub API.
It avoids the rate limit of GitHub API.