Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Improve JSON Schema #927

Merged
merged 15 commits into from
Jun 26, 2022
Merged

Conversation

4513ECHO
Copy link
Contributor

@4513ECHO 4513ECHO commented Jun 25, 2022

Close #623
I have improved JSON Schema like below:

  • Add possible GOOS/GOArch values to the replacements properties
  • Add possible GOOS/GOArch values and all to the enum of the supported_envs items

I'm not familiar with golang. I think your check is needed for my codes.

TODO:
The definition of possible GOOS/GOArch values is duplicating in two functions. I'm considering moving these variables to runtime module.
Done.

@4513ECHO 4513ECHO marked this pull request as ready for review June 25, 2022 08:19
@4513ECHO
Copy link
Contributor Author

js/wasm is never available with aqua.

@suzuki-shunsuke suzuki-shunsuke added the enhancement New feature or request label Jun 26, 2022
@suzuki-shunsuke suzuki-shunsuke added this to the v1.14.0 milestone Jun 26, 2022
@suzuki-shunsuke
Copy link
Member

Thank you for your contribution.

@suzuki-shunsuke
Copy link
Member

I'm fixing the lint error.

@suzuki-shunsuke suzuki-shunsuke merged commit 7b763f2 into aquaproj:main Jun 26, 2022
@4513ECHO 4513ECHO deleted the json-schema branch June 26, 2022 07:43
@suzuki-shunsuke
Copy link
Member

Released. https://github.com/aquaproj/aqua/releases/tag/v1.14.0

@4513ECHO
Copy link
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Generate json schema for registry from Go structs
2 participants