Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/frontend progress #53

Merged
merged 9 commits into from
Jul 19, 2021
Merged

Feature/frontend progress #53

merged 9 commits into from
Jul 19, 2021

Conversation

alv67
Copy link
Collaborator

@alv67 alv67 commented Jul 19, 2021

No more linter errors.
Need to connect to the API exposed to the Server:

@gmacario gmacario added this to To Do in blobfishes-project via automation Jul 19, 2021
@gmacario
Copy link
Collaborator

@alv67 nitpick

gmacario@gmpowerhorse:~/github/gmacario/blobfishes (feature/frontend-progress)$ git status
gmacario@gmpowerhorse:~/github/gmacario/blobfishes/client (feature/frontend-progress)$ npm i
npm WARN ugly-frontend@0.0.1 No repository field.
npm WARN ugly-frontend@0.0.1 No license field.
npm WARN optional SKIPPING OPTIONAL DEPENDENCY: fsevents@2.3.2 (node_modules/fsevents):
npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for fsevents@2.3.2: wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})

added 4 packages from 5 contributors and audited 312 packages in 2.584s

44 packages are looking for funding
  run `npm fund` for details

found 0 vulnerabilities

gmacario@gmpowerhorse:~/github/gmacario/blobfishes/client (feature/frontend-progress)$

Please fix repository and license fields in client/package.json and regenerate package-lock.json accordingly

@gmacario gmacario requested review from gmacario and Raffone17 and removed request for gmacario July 19, 2021 22:11
@gmacario
Copy link
Collaborator

gmacario commented Jul 19, 2021

Apart from nitpick above, LGTM.

image

Thanks for your contribution @alv67 🎉

Merging PR and filing the minor request for fix in a separate bug --> #56

@gmacario gmacario merged commit 6d9145a into main Jul 19, 2021
blobfishes-project automation moved this from To Do to Done Jul 19, 2021
This was referenced Jul 19, 2021
@gmacario gmacario deleted the feature/frontend-progress branch July 20, 2021 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants