Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable bucket transition to versioning suspended #534

Closed
irq0 opened this issue May 17, 2023 · 0 comments · Fixed by aquarist-labs/ceph#172
Closed

Disable bucket transition to versioning suspended #534

irq0 opened this issue May 17, 2023 · 0 comments · Fixed by aquarist-labs/ceph#172
Assignees
@irq0
Labels
area/rgw-sfs RGW & SFS related kind/bug Something isn't working
Milestone
v0.19.0

Comments

@irq0
Copy link
Contributor

irq0 commented May 17, 2023

What needs to be done

In https://github.com/aquarist-labs/s3gw/pull/497 we decided not to support versioning suspended buckets for now. Therefore we should disable that mode.

The transition is done by updating the bucket-get_into().flags and calling bucket->put_info. We need to check for this flag in put_info and fail that operation.

Why it needs to be done

https://github.com/aquarist-labs/s3gw/pull/497

Acceptance Criteria

Additional Information
@irq0 irq0 added kind/bug Something isn't working area/rgw-sfs RGW & SFS related labels May 17, 2023
@github-actions github-actions bot added the triage/waiting Waiting for triage label May 17, 2023
@jhmarina jhmarina added triage/next-candidate This could be moved to the next milestone and removed triage/waiting Waiting for triage labels Jul 4, 2023
@jhmarina jhmarina added this to the v.0.19.0 milestone Jul 4, 2023
@jhmarina jhmarina removed the triage/next-candidate This could be moved to the next milestone label Jul 11, 2023
@irq0 irq0 mentioned this issue Jul 14, 2023
Merged
11 tasks
@irq0 irq0 mentioned this issue Aug 16, 2023
Closed
votdev referenced this issue in votdev/s3gw-ui Aug 16, 2023
@votdev
Disable versioning checkbox after bucket creation
34ffee3 
Fixes: https://github.com/aquarist-labs/s3gw/issues/672

References:
- https://github.com/aquarist-labs/s3gw/issues/534
- https://github.com/aquarist-labs/s3gw/pull/497

Signed-off-by: Volker Theile <vtheile@suse.com>
@votdev votdev mentioned this issue Aug 16, 2023
Merged
3 tasks
votdev referenced this issue in votdev/s3gw-ui Aug 17, 2023
@votdev
Disable versioning checkbox after bucket creation if it is already en…
7176c97 
…abled

This is to prevent the user from disabling the versioning because right now you can go from:

- unversioned to versioned any time.
- versioned -> unversioned is not supported in S3.
- versioned -> suspended versioned is not supported by us.

Fixes: https://github.com/aquarist-labs/s3gw/issues/672

References:
- https://github.com/aquarist-labs/s3gw/issues/534
- https://github.com/aquarist-labs/s3gw/pull/497

Signed-off-by: Volker Theile <vtheile@suse.com>
votdev referenced this issue in votdev/s3gw-ui Aug 17, 2023
@votdev
Disable versioning checkbox after bucket creation if it is already en…
d48b130 
…abled

This is to prevent the user from disabling the versioning because right now you can go from:

- unversioned to versioned any time.
- versioned -> unversioned is not supported in S3.
- versioned -> suspended versioned is not supported by us.

Fixes: https://github.com/aquarist-labs/s3gw/issues/672

References:
- https://github.com/aquarist-labs/s3gw/issues/534
- https://github.com/aquarist-labs/s3gw/pull/497

Signed-off-by: Volker Theile <vtheile@suse.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@irq0 irq0

Labels
area/rgw-sfs RGW & SFS related kind/bug Something isn't working
Projects
None yet
Milestone
v0.19.0
Development

Successfully merging a pull request may close this issue.

Disable Versioning Suspended Buckets irq0/ceph
2 participants
@irq0 @jhmarina