Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: on-disk format checker and release tests #348

Merged
merged 1 commit into from
Feb 22, 2023

Conversation

m-ildefons
Copy link
Contributor

@m-ildefons m-ildefons commented Feb 17, 2023

  • Add on-disk format checker able to detect the most egregious breaking on-disk format changes.
  • Incorporate simple tests into release workflow
  • Remove usage of Dockerhub from release workflow in favor of Quay.io
  • Fix whitespace errors

The purpose of the on-disk format change test is to ensure a release with on-disk format changes has an appropriate notice in the release notes.
The purpose of the smoke test is to ensure the packaging into the container image has been successful and the runtime works as expected.

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • CHANGELOG.md has been updated should there be relevant changes in this PR.

@m-ildefons m-ildefons added kind/design Design work kind/quality Quality improvements, Refactoring, Automation via CI, E2E, Integration, CLI or REST API area/tests Related to tests and testing area/CI Continuous Integration labels Feb 17, 2023
@m-ildefons m-ildefons added this to the v0.13.0 milestone Feb 17, 2023
@m-ildefons m-ildefons requested a review from irq0 February 17, 2023 13:20
@m-ildefons m-ildefons self-assigned this Feb 17, 2023
irq0
irq0 previously approved these changes Feb 22, 2023
tools/tests/on-disk-format-checker.sh Outdated Show resolved Hide resolved
tools/tests/on-disk-format-checker.sh Show resolved Hide resolved
- Add on-disk format checker able to detect the most egregious breaking
  on-disk format changes.
- Incorporate simple tests into releae workflow
- Remove usage of Dockerhub from release workflow in favor of Quay.io
- Fix whitespace errors

The purpose of the on-disk format change test is to ensure a release
with on-disk format changes has an appropriate notice in the release
notes.
The purpose of the smoke test is to ensure the packaging into the
container image has been successful and the runtime works as expected.

Signed-off-by: Moritz Röhrich <moritz.rohrich@suse.com>
Copy link
Contributor

@irq0 irq0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@m-ildefons m-ildefons merged commit 5c3bb49 into s3gw-tech:main Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/CI Continuous Integration area/tests Related to tests and testing kind/design Design work kind/quality Quality improvements, Refactoring, Automation via CI, E2E, Integration, CLI or REST API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants