Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking changes with active:active commit and chart version unchanged #82

Closed
cdunford opened this issue May 15, 2020 · 4 comments
Closed

Comments

@cdunford
Copy link

cdunford commented May 15, 2020

There was an update made to the server chart (specifically ce60ce8#diff-cf1e8c14e54505f60aa10ceb8d5d8ab3) that removed values that we were setting (specifically the audit DB parameters auditHost, auditUser and auditPassword). Now our console container will no longer start as it cannot connect to the audit DB and one of our environments is unusable.

The bigger problem here is that the chart version did not change whatsoever with this change, and was published to helm.aquasec.com replacing the previous revision of 4.6.0. We have no way to reference the previous, working version of the chart, as it appears it is completely replaced by this new version.

Whenever changes are made to the chart, at the very least the chart patch version should be changed (and possibly major/minor version depending on the scope/nature of the change) to avoid impacting anyone who has pinned to a specific version of the chart. Once a specific version of the chart is published, it should not be modified.

@agilgur5
Copy link
Contributor

agilgur5 commented Aug 11, 2020

Saw 70ae917 which also makes a large amount of breaking changes...

I'm not sure if the Chart registry was updated with those changes, but these kinds of drastic breaking changes without bumping major and without so much as a changelog (not to mention these commits and PRs basically just say "updates"), let alone upgrade directions, pretty much make this repo unusable due to poor maintenance and lack of care...

Overwriting an existing pinned version as you wrote means it's not even possible to rely on exact version pinning... 😬 😬 😕

@cdunford
Copy link
Author

@agilgur5 - I'm now using the helm git plugin to consume these charts direct from the github repo and I pin to a specific commit. Seems to be the only safe thing to do.

@agilgur5
Copy link
Contributor

agilgur5 commented Aug 19, 2020

Yea but without a changelog and without SemVer updates are basically ??? 😕

@xB-2048
Copy link
Member

xB-2048 commented Dec 10, 2020

@cdunford Thanks for reporting the issue.

We will manage the chart version and changelog going forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants