Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Tenant Manager Helm chart #99

Closed

Conversation

agilgur5
Copy link
Contributor

Description

  • taken from https://docs.aquasec.com/docs/tm-deploy#section-deployment-kubernetes-hosts
    and modified for usage with Helm

  • also standardized against existing Charts in the repo

    • use same LICENSE and .helmignore
    • use same ServiceAccount and image pull Secret
    • use same port protocol (TCP)
    • don't specify LoadBalancer as Service type
    • use same set of metadata and template metadata for all resources
    • use same values to define livenessProbe, readinessProbe, resources,
      nodeSelector, affinity, and tolerations
    • use same values to define image and imageCredentials
    • use similar Chart.yaml, NOTES.txt, _helpers.tpl, values.yaml, and
      README.md
  • add Tenant Manager to repo root README

Review Notes

  • I used "5.0.0" as that's what the other Charts use, but maybe this should be a more alpha version initially
  • Resources for Tenant Manager aren't specified in the sizing guide, so I'm not sure what to put in the commented out section in values.yaml, those were just copied from another Chart and therefore are arbitrary for Tenant Manager.
  • I'm guessing there should probably be more values for customizing the DB access, but I'm not sure what those should look like

Please feel free to iterate on top of any of that.

The README table change may conflict with my other PR around formatting: #97

- taken from https://docs.aquasec.com/docs/tm-deploy#section-deployment-kubernetes-hosts
  and modified for usage with Helm

- also standardized against existing Charts in the repo
  - use same LICENSE and .helmignore
  - use same ServiceAccount and image pull Secret
  - use same port protocol (TCP)
  - don't specify `LoadBalancer` as Service `type`
  - use same set of metadata and template metadata for all resources
  - use same values to define livenessProbe, readinessProbe, resources,
    nodeSelector, affinity, and tolerations
  - use same values to define image and imageCredentials
  - use similar Chart.yaml, NOTES.txt, _helpers.tpl, values.yaml, and
    README.md

- add Tenant Manager to repo root README
@niso120b
Copy link
Contributor

we currently don't need the tenant manager to be in the helm charts repository, thanks.

@niso120b niso120b closed this Jul 28, 2020
@agilgur5
Copy link
Contributor Author

agilgur5 commented Jul 28, 2020

@niso120b Er, I added it because I was looking to use it in a multi-cluster set-up and it didn't exist here (or in aqua-operator etc etc)...

Not sure what you mean by "you don't need it" when I use Helm, use Helm to install the other components, but can't install Tenant Manager that way... Clearly it's missing...
KubeEnforcer didn't exist here until recently either and still doesn't work per #96

This was referenced Aug 5, 2020
@agilgur5
Copy link
Contributor Author

@niso120b just going to add that we terminated our contract with Aqua and one of the reasons for that was because of responses like these (see also #92 ) and how this repo is maintained more broadly (not limited to, but including #123 and #82 ). I'm not the only frustrated user per the issues and what CS told me, but thought I'd add that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants