feat: add default Scanner user #116
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- set to the name "scanner"
- also consistently use "user" in the docs instead of "username"
- I read "username" and used that in my values in a live call with
Aqua Engineers, which didn't work since it is actually "user"
- this should make mistakes and confusion like that harder to happen
|
updated docs about user credentials prerequisite for scanner chart deployment. closing this PR, thanks! |
|
@KoppulaRajender I see #270 added docs for creating a Scanner, which did fix a portion of #119, but it does not replace this PR, which adds a default user and fixes some wording. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
set to the name "scanner"
also consistently use "user" in the docs instead of "username"
Aqua Engineers, which didn't work since it is actually "user"
Tags
This will merge conflict with #112 because it changes the line above this 😕
Ran into the "user" vs. "username" thing right after hitting #103
Review Notes
I'm not totally sure why the Scanner
userandpasswordaren't specified as pre-requisites one must create in the docs. If it wasn't for Aqua Engineers telling me on a call, I wouldn't have done that or known to do so until I got the required error.